From: Fan Wu <wufan@linux.microsoft.com>
To: Paul Moore <paul@paul-moore.com>, Guenter Roeck <linux@roeck-us.net>
Cc: "Serge E . Hallyn" <serge@hallyn.com>,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org,
Deven Bowers <deven.desai@linux.microsoft.com>
Subject: Re: [PATCH] ipe: Add missing terminator to list of unit tests
Date: Mon, 23 Sep 2024 10:40:45 -0700 [thread overview]
Message-ID: <e824b125-0ab0-4e1f-9411-abbc1984c124@linux.microsoft.com> (raw)
In-Reply-To: <CAHC9VhRWhknpRkKv7-yZza-kr1Bq2nhch8bYm9BsfDpurFir9Q@mail.gmail.com>
On 9/22/2024 5:27 PM, Paul Moore wrote:
> On Sun, Sep 22, 2024 at 10:52 AM Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> Add missing terminator to list of unit tests to avoid random crashes seen
>> when running the test.
>>
>> Fixes: 10ca05a76065 ("ipe: kunit test for parser")
>> Cc: Deven Bowers <deven.desai@linux.microsoft.com>
>> Cc: Paul Moore <paul@paul-moore.com>
>> Cc: Fan Wu <wufan@linux.microsoft.com>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>> security/ipe/policy_tests.c | 1 +
>> 1 file changed, 1 insertion(+)
>
> I'm guessing Fan doesn't have his tree setup yet, but if I can get an
> ACK from Fan I can send this up via the LSM tree for the next
> v6.12-rcX release.
>
>> diff --git a/security/ipe/policy_tests.c b/security/ipe/policy_tests.c
>> index 89521f6b9994..5f1654deeb04 100644
>> --- a/security/ipe/policy_tests.c
>> +++ b/security/ipe/policy_tests.c
>> @@ -286,6 +286,7 @@ static void ipe_parser_widestring_test(struct kunit *test)
>> static struct kunit_case ipe_parser_test_cases[] = {
>> KUNIT_CASE_PARAM(ipe_parser_unsigned_test, ipe_policies_gen_params),
>> KUNIT_CASE(ipe_parser_widestring_test),
>> + { }
>> };
>>
>> static struct kunit_suite ipe_parser_test_suite = {
>
Yes this looks good to me.
Acked-by: Fan Wu <wufan@linux.microsoft.com>
next prev parent reply other threads:[~2024-09-23 17:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-22 14:52 [PATCH] ipe: Add missing terminator to list of unit tests Guenter Roeck
2024-09-23 0:27 ` Paul Moore
2024-09-23 17:40 ` Fan Wu [this message]
2024-09-23 19:53 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e824b125-0ab0-4e1f-9411-abbc1984c124@linux.microsoft.com \
--to=wufan@linux.microsoft.com \
--cc=deven.desai@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox