From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "David E. Box" <david.e.box@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
rajvi.jingar@linux.intel.com,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/8] platform/x86/intel/pmc: Allow reenabling LTRs
Date: Wed, 27 Dec 2023 19:54:49 +0200 (EET) [thread overview]
Message-ID: <e83492f-8c94-b43b-6fdc-aed6ea6251@linux.intel.com> (raw)
In-Reply-To: <20231223032548.1680738-5-david.e.box@linux.intel.com>
On Fri, 22 Dec 2023, David E. Box wrote:
> Commit 804951203aa5 ("platform/x86:intel/pmc: Combine core_init() and
> core_configure()") caused a network performance regression due to the GBE
> LTR ignore that it added during probe. The fix will move the ignore to
> occur at suspend-time (so as to not affect suspend power). This will
> require the ability to enable the LTR again on resume. Modify
> pmc_core_send_ltr_ignore() to allow enabling an LTR.
>
> Fixes: 804951203aa5 ("platform/x86:intel/pmc: Combine core_init() and core_configure()")
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> ---
> drivers/platform/x86/intel/pmc/adl.c | 2 +-
> drivers/platform/x86/intel/pmc/cnp.c | 2 +-
> drivers/platform/x86/intel/pmc/core.c | 9 ++++++---
> drivers/platform/x86/intel/pmc/core.h | 3 ++-
> drivers/platform/x86/intel/pmc/mtl.c | 2 +-
> drivers/platform/x86/intel/pmc/tgl.c | 2 +-
> 6 files changed, 12 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/pmc/adl.c b/drivers/platform/x86/intel/pmc/adl.c
> index 882f2d5d8937..fbe0678f766c 100644
> --- a/drivers/platform/x86/intel/pmc/adl.c
> +++ b/drivers/platform/x86/intel/pmc/adl.c
> @@ -327,7 +327,7 @@ int adl_core_init(struct pmc_dev *pmcdev)
> * when a cable is attached. Tell the PMC to ignore it.
> */
> dev_dbg(&pmcdev->pdev->dev, "ignoring GBE LTR\n");
> - pmc_core_send_ltr_ignore(pmcdev, 3);
> + pmc_core_send_ltr_ignore(pmcdev, 3, 1);
>
> return 0;
> }
> diff --git a/drivers/platform/x86/intel/pmc/cnp.c b/drivers/platform/x86/intel/pmc/cnp.c
> index 59298f184d0e..80f73242f9dd 100644
> --- a/drivers/platform/x86/intel/pmc/cnp.c
> +++ b/drivers/platform/x86/intel/pmc/cnp.c
> @@ -220,7 +220,7 @@ int cnp_core_init(struct pmc_dev *pmcdev)
> * when a cable is attached. Tell the PMC to ignore it.
> */
> dev_dbg(&pmcdev->pdev->dev, "ignoring GBE LTR\n");
> - pmc_core_send_ltr_ignore(pmcdev, 3);
> + pmc_core_send_ltr_ignore(pmcdev, 3, 1);
>
> return 0;
> }
> diff --git a/drivers/platform/x86/intel/pmc/core.c b/drivers/platform/x86/intel/pmc/core.c
> index 31905003bb05..aa44c6612af9 100644
> --- a/drivers/platform/x86/intel/pmc/core.c
> +++ b/drivers/platform/x86/intel/pmc/core.c
> @@ -476,7 +476,7 @@ static int pmc_core_pll_show(struct seq_file *s, void *unused)
> }
> DEFINE_SHOW_ATTRIBUTE(pmc_core_pll);
>
> -int pmc_core_send_ltr_ignore(struct pmc_dev *pmcdev, u32 value)
> +int pmc_core_send_ltr_ignore(struct pmc_dev *pmcdev, u32 value, int ignore)
Nothing seems to need int for anything and it's used like a bool. So
> {
> struct pmc *pmc;
> const struct pmc_reg_map *map;
> @@ -514,7 +514,10 @@ int pmc_core_send_ltr_ignore(struct pmc_dev *pmcdev, u32 value)
> mutex_lock(&pmcdev->lock);
>
> reg = pmc_core_reg_read(pmc, map->ltr_ignore_offset);
> - reg |= BIT(ltr_index);
> + if (ignore)
> + reg |= BIT(ltr_index);
> + else
> + reg &= ~BIT(ltr_index);
> pmc_core_reg_write(pmc, map->ltr_ignore_offset, reg);
>
> mutex_unlock(&pmcdev->lock);
> @@ -537,7 +540,7 @@ static ssize_t pmc_core_ltr_ignore_write(struct file *file,
> if (err)
> return err;
>
> - err = pmc_core_send_ltr_ignore(pmcdev, value);
> + err = pmc_core_send_ltr_ignore(pmcdev, value, 1);
>
> return err == 0 ? count : err;
> }
> diff --git a/drivers/platform/x86/intel/pmc/core.h b/drivers/platform/x86/intel/pmc/core.h
> index ce9b9efc9790..90f2dbc4df72 100644
> --- a/drivers/platform/x86/intel/pmc/core.h
> +++ b/drivers/platform/x86/intel/pmc/core.h
> @@ -567,7 +567,8 @@ extern const struct pmc_reg_map arl_pchs_reg_map;
>
> extern void pmc_core_get_tgl_lpm_reqs(struct platform_device *pdev);
> extern int pmc_core_ssram_get_lpm_reqs(struct pmc_dev *pmcdev);
> -extern int pmc_core_send_ltr_ignore(struct pmc_dev *pmcdev, u32 value);
> +extern int
> +pmc_core_send_ltr_ignore(struct pmc_dev *pmcdev, u32 value, int ignore);
extern is unnecessary.
> int pmc_core_resume_common(struct pmc_dev *pmcdev);
> int get_primary_reg_base(struct pmc *pmc);
> diff --git a/drivers/platform/x86/intel/pmc/mtl.c b/drivers/platform/x86/intel/pmc/mtl.c
> index e75431325dda..ef78d14fc27f 100644
> --- a/drivers/platform/x86/intel/pmc/mtl.c
> +++ b/drivers/platform/x86/intel/pmc/mtl.c
> @@ -1023,7 +1023,7 @@ int mtl_core_init(struct pmc_dev *pmcdev)
> * when a cable is attached. Tell the PMC to ignore it.
> */
> dev_dbg(&pmcdev->pdev->dev, "ignoring GBE LTR\n");
> - pmc_core_send_ltr_ignore(pmcdev, 3);
> + pmc_core_send_ltr_ignore(pmcdev, 3, 1);
>
> if (ssram_init)
> return pmc_core_ssram_get_lpm_reqs(pmcdev);
> diff --git a/drivers/platform/x86/intel/pmc/tgl.c b/drivers/platform/x86/intel/pmc/tgl.c
> index 91fd725951e5..8213961975fc 100644
> --- a/drivers/platform/x86/intel/pmc/tgl.c
> +++ b/drivers/platform/x86/intel/pmc/tgl.c
> @@ -315,7 +315,7 @@ int tgl_core_generic_init(struct pmc_dev *pmcdev, int pch_tp)
> * when a cable is attached. Tell the PMC to ignore it.
> */
> dev_dbg(&pmcdev->pdev->dev, "ignoring GBE LTR\n");
> - pmc_core_send_ltr_ignore(pmcdev, 3);
> + pmc_core_send_ltr_ignore(pmcdev, 3, 1);
>
> return 0;
> }
>
--
i.
next prev parent reply other threads:[~2023-12-27 17:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-23 3:25 [PATCH 0/8] Intel PMC Core GBE LTR regression fix David E. Box
2023-12-23 3:25 ` [PATCH 1/8] platform/x86/intel/pmc/arl.c: Remove probe time LTR ignore David E. Box
2023-12-23 3:25 ` [PATCH 2/8] platform/x86/intel/pmc/lnl.c: " David E. Box
2023-12-23 3:25 ` [PATCH 3/8] platform/x86/intel/pmc: Add suspend callback David E. Box
2023-12-23 3:25 ` [PATCH 4/8] platform/x86/intel/pmc: Allow reenabling LTRs David E. Box
2023-12-27 17:54 ` Ilpo Järvinen [this message]
2023-12-28 15:43 ` Ilpo Järvinen
2023-12-23 3:25 ` [PATCH 5/8] platform/x86/intel/pmc: Move GBE LTR ignore to suspend callback David E. Box
2023-12-23 3:25 ` [PATCH 6/8] platform/x86/intel/pmc/arl: Add GBE LTR ignore during suspend David E. Box
2024-01-02 12:24 ` Hans de Goede
2023-12-23 3:25 ` [PATCH 7/8] platform/x86/intel/pmc/lnl: " David E. Box
2024-01-02 12:24 ` Hans de Goede
2023-12-23 3:25 ` [PATCH 8/8] platform/x86/intel/pmc: Add missing extern David E. Box
2024-01-02 12:24 ` Hans de Goede
2023-12-27 18:14 ` [PATCH 0/8] Intel PMC Core GBE LTR regression fix Ilpo Järvinen
2023-12-28 9:35 ` Hans de Goede
2023-12-28 15:38 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e83492f-8c94-b43b-6fdc-aed6ea6251@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=david.e.box@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rajvi.jingar@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox