public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Sergio Paracuellos <sergio.paracuellos@gmail.com>,
	devicetree@vger.kernel.org
Cc: linux-pci@vger.kernel.org, krzk+dt@kernel.org, robh@kernel.org,
	kw@linux.com, lpieralisi@kernel.org, bhelgaas@google.com,
	conor+dt@kernel.org, linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH] dt-bindings: PCI: mediatek,mt7621-pcie: add PCIe host topology ascii graph
Date: Wed, 22 May 2024 09:17:42 +0200	[thread overview]
Message-ID: <e856dbde-c712-473f-a761-cd29d6e8d8b5@collabora.com> (raw)
In-Reply-To: <20240522044321.3205160-1-sergio.paracuellos@gmail.com>

Il 22/05/24 06:43, Sergio Paracuellos ha scritto:
> MediaTek MT7621 PCIe subsys supports a single Root Complex (RC) with 3 Root
> Ports. Add PCIe host topology ascii graph to the binding for completeness.
> 
> Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>

Lovely.

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

> ---
>   .../bindings/pci/mediatek,mt7621-pcie.yaml    | 29 +++++++++++++++++++
>   1 file changed, 29 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> index 6fba42156db6..c41608863d6c 100644
> --- a/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/mediatek,mt7621-pcie.yaml
> @@ -13,6 +13,35 @@ description: |+
>     MediaTek MT7621 PCIe subsys supports a single Root Complex (RC)
>     with 3 Root Ports. Each Root Port supports a Gen1 1-lane Link
>   
> +                          MT7621 PCIe HOST Topology
> +
> +                                   .-------.
> +                                   |       |
> +                                   |  CPU  |
> +                                   |       |
> +                                   '-------'
> +                                       |
> +                                       |
> +                                       |
> +                                       v
> +                              .------------------.
> +                  .-----------|  HOST/PCI Bridge |------------.
> +                  |           '------------------'            | Type1
> +             BUS0 |                     |                     | Access
> +                  v                     v                     v On Bus0
> +          .-------------.        .-------------.       .-------------.
> +          | VIRTUAL P2P |        | VIRTUAL P2P |       | VIRTUAL P2P |
> +          |    BUS0     |        |    BUS0     |       |    BUS0     |
> +          |    DEV0     |        |    DEV1     |       |    DEV2     |
> +          '-------------'        '-------------'       '-------------'
> +    Type0        |          Type0       |         Type0       |
> +   Access   BUS1 |         Access   BUS2|        Access   BUS3|
> +   On Bus1       v         On Bus2      v        On Bus3      v
> +           .----------.           .----------.          .----------.
> +           | Device 0 |           | Device 0 |          | Device 0 |
> +           |  Func 0  |           |  Func 0  |          |  Func 0  |
> +           '----------'           '----------'          '----------'
> +
>   allOf:
>     - $ref: /schemas/pci/pci-host-bridge.yaml#
>   


  parent reply	other threads:[~2024-05-22  7:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22  4:43 [PATCH] dt-bindings: PCI: mediatek,mt7621-pcie: add PCIe host topology ascii graph Sergio Paracuellos
2024-05-22  6:48 ` Krzysztof Kozlowski
2024-05-22  7:17 ` AngeloGioacchino Del Regno [this message]
2024-07-01 20:22 ` Krzysztof Wilczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e856dbde-c712-473f-a761-cd29d6e8d8b5@collabora.com \
    --to=angelogioacchino.delregno@collabora.com \
    --cc=bhelgaas@google.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kw@linux.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=robh@kernel.org \
    --cc=sergio.paracuellos@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox