From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752149AbcGUJQd (ORCPT ); Thu, 21 Jul 2016 05:16:33 -0400 Received: from mail-lf0-f42.google.com ([209.85.215.42]:34765 "EHLO mail-lf0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751815AbcGUJQa (ORCPT ); Thu, 21 Jul 2016 05:16:30 -0400 Subject: Re: [PATCH 4/4] nvmx: check for shadow vmcs check on entry To: Bandan Das , kvm@vger.kernel.org References: <1469053536-11130-1-git-send-email-bsd@redhat.com> <1469053536-11130-5-git-send-email-bsd@redhat.com> Cc: rkrcmar@redhat.com, linux-kernel@vger.kernel.org From: Paolo Bonzini Message-ID: Date: Thu, 21 Jul 2016 11:16:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1469053536-11130-5-git-send-email-bsd@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/07/2016 00:25, Bandan Das wrote: > vmentry should check whether the vmcs provided by > the guest hypervisor is a shadow vmcs and fail. How can this happen, since vmptrld checks the revision_id as you said below? Paolo > Also, vmptrld should check whether a shadow vmcs > is being loaded by the guest without support being present > but this check happens as part of checking the revision_id.