* [PATCH] dma-buf: check the return value of kstrdup()
@ 2022-02-22 11:30 xkernel.wang
2022-02-22 11:31 ` Christian König
2022-02-22 13:41 ` Sumit Semwal
0 siblings, 2 replies; 3+ messages in thread
From: xkernel.wang @ 2022-02-22 11:30 UTC (permalink / raw)
To: sumit.semwal, christian.koenig
Cc: linux-media, dri-devel, linaro-mm-sig, linux-kernel, Xiaoke Wang
From: Xiaoke Wang <xkernel.wang@foxmail.com>
kstrdup() is a memory allocation function which can return NULL when
some internaly memory errors happen. It is better to check the return
value of it to prevent further wrong memory access.
Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
---
drivers/dma-buf/selftest.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/dma-buf/selftest.c b/drivers/dma-buf/selftest.c
index c60b694..2c29e2a 100644
--- a/drivers/dma-buf/selftest.c
+++ b/drivers/dma-buf/selftest.c
@@ -50,6 +50,9 @@ static bool apply_subtest_filter(const char *caller, const char *name)
bool result = true;
filter = kstrdup(__st_filter, GFP_KERNEL);
+ if (!filter)
+ return false;
+
for (sep = filter; (tok = strsep(&sep, ","));) {
bool allow = true;
char *sl;
--
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dma-buf: check the return value of kstrdup()
2022-02-22 11:30 [PATCH] dma-buf: check the return value of kstrdup() xkernel.wang
@ 2022-02-22 11:31 ` Christian König
2022-02-22 13:41 ` Sumit Semwal
1 sibling, 0 replies; 3+ messages in thread
From: Christian König @ 2022-02-22 11:31 UTC (permalink / raw)
To: xkernel.wang, sumit.semwal
Cc: linux-media, dri-devel, linaro-mm-sig, linux-kernel
Am 22.02.22 um 12:30 schrieb xkernel.wang@foxmail.com:
> From: Xiaoke Wang <xkernel.wang@foxmail.com>
>
> kstrdup() is a memory allocation function which can return NULL when
> some internaly memory errors happen. It is better to check the return
> value of it to prevent further wrong memory access.
>
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
Acked-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/dma-buf/selftest.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/dma-buf/selftest.c b/drivers/dma-buf/selftest.c
> index c60b694..2c29e2a 100644
> --- a/drivers/dma-buf/selftest.c
> +++ b/drivers/dma-buf/selftest.c
> @@ -50,6 +50,9 @@ static bool apply_subtest_filter(const char *caller, const char *name)
> bool result = true;
>
> filter = kstrdup(__st_filter, GFP_KERNEL);
> + if (!filter)
> + return false;
> +
> for (sep = filter; (tok = strsep(&sep, ","));) {
> bool allow = true;
> char *sl;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dma-buf: check the return value of kstrdup()
2022-02-22 11:30 [PATCH] dma-buf: check the return value of kstrdup() xkernel.wang
2022-02-22 11:31 ` Christian König
@ 2022-02-22 13:41 ` Sumit Semwal
1 sibling, 0 replies; 3+ messages in thread
From: Sumit Semwal @ 2022-02-22 13:41 UTC (permalink / raw)
To: xkernel.wang
Cc: christian.koenig, linux-media, dri-devel, linaro-mm-sig,
linux-kernel
Hi Xiaoke,
On Tue, 22 Feb 2022 at 17:00, <xkernel.wang@foxmail.com> wrote:
>
> From: Xiaoke Wang <xkernel.wang@foxmail.com>
>
> kstrdup() is a memory allocation function which can return NULL when
> some internaly memory errors happen. It is better to check the return
> value of it to prevent further wrong memory access.
Thanks for the patch; looks sane.
>
> Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
Acked-by: Sumit Semwal <sumit.semwal@linaro.org>
Will queue it up.
> ---
> drivers/dma-buf/selftest.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/dma-buf/selftest.c b/drivers/dma-buf/selftest.c
> index c60b694..2c29e2a 100644
> --- a/drivers/dma-buf/selftest.c
> +++ b/drivers/dma-buf/selftest.c
> @@ -50,6 +50,9 @@ static bool apply_subtest_filter(const char *caller, const char *name)
> bool result = true;
>
> filter = kstrdup(__st_filter, GFP_KERNEL);
> + if (!filter)
> + return false;
> +
> for (sep = filter; (tok = strsep(&sep, ","));) {
> bool allow = true;
> char *sl;
> --
Best,
Sumit.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-22 13:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-02-22 11:30 [PATCH] dma-buf: check the return value of kstrdup() xkernel.wang
2022-02-22 11:31 ` Christian König
2022-02-22 13:41 ` Sumit Semwal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox