From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD403C7618E for ; Mon, 24 Apr 2023 09:21:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231552AbjDXJVH (ORCPT ); Mon, 24 Apr 2023 05:21:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231447AbjDXJVF (ORCPT ); Mon, 24 Apr 2023 05:21:05 -0400 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D92C211D; Mon, 24 Apr 2023 02:20:50 -0700 (PDT) Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-958bb7731a9so304315066b.0; Mon, 24 Apr 2023 02:20:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682328048; x=1684920048; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UA6jSt5gQmRcw1KPPidEx6UfEGnWKcs24u88lBvdmFQ=; b=ZxR/h5iBTJ0MLTmY9fzuwPRroPSkHpVuhOb2Kju5rYDFaDIJxcE6MfinGPp8n5mikX jrOhx2+5gjfNa9NgzXGtJP1ZlAp1rr+EQju0bj5scSTXTPnQ1R3trwn7keu5g1TFhYiW FXUE2Cxf64pJM/PpsY6xaVfWIWMTGQCrUAMz36kXZ4BMO7OAhm4ttRO6xIneNYs9qsB2 Ikza2kkH/iCUIQbdTrZ/DfFo5fRFb9z3UvA4I2JzSvv1DIzdiNH0LoqrzsKC7kkuXZuV WL4QigIYur0VcAo66WTuFy2Xd+AvxjCuuulLPZshvXjz4EQ8iMNT5dj4+7b+ck8pXV/U mkjQ== X-Gm-Message-State: AAQBX9fbj9XJaiZWdmznCDFD5Fd5iWzaKnhM1yhsC7M1NLWvW7jt0ovy Rk0LWgGMzrWpdLBlTMUVtdvCd4V8OXw= X-Google-Smtp-Source: AKy350ZS7ohYuDvxcs3eJSlQ8UgKSMbR7vddFPaKhmUbmEKlSuNL05qiNE9VZNVNCJ0SDz7Z3DMopQ== X-Received: by 2002:a17:906:3698:b0:958:5c21:3fa7 with SMTP id a24-20020a170906369800b009585c213fa7mr4384903ejc.25.1682328048284; Mon, 24 Apr 2023 02:20:48 -0700 (PDT) Received: from [192.168.1.58] (185-219-167-24-static.vivo.cz. [185.219.167.24]) by smtp.gmail.com with ESMTPSA id lh15-20020a170906f8cf00b0094e62aa8bcesm5315525ejb.29.2023.04.24.02.20.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Apr 2023 02:20:47 -0700 (PDT) Message-ID: Date: Mon, 24 Apr 2023 11:20:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] serial: 8250: Document termios parameter of serial8250_em485_config() Content-Language: en-US To: Geert Uytterhoeven , Greg Kroah-Hartman , =?UTF-8?Q?Ilpo_J=c3=a4rvinen?= Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org References: <2bd1e62be1d5d33333002910372feecc6d52e78f.1682071013.git.geert+renesas@glider.be> From: Jiri Slaby In-Reply-To: <2bd1e62be1d5d33333002910372feecc6d52e78f.1682071013.git.geert+renesas@glider.be> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21. 04. 23, 11:58, Geert Uytterhoeven wrote: > With W=1: > > drivers/tty/serial/8250/8250_port.c:679: warning: Function parameter or member 'termios' not described in 'serial8250_em485_config' > > Fix this by documenting the parameter. > > Fixes: ae50bb2752836277 ("serial: take termios_rwsem for ->rs485_config() & pass termios as param") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Jiri Slaby thanks, -- js suse labs