From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932073AbdK1MOl (ORCPT ); Tue, 28 Nov 2017 07:14:41 -0500 Received: from mga03.intel.com ([134.134.136.65]:62443 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752571AbdK1MOj (ORCPT ); Tue, 28 Nov 2017 07:14:39 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,468,1505804400"; d="scan'208";a="1249443254" Subject: Re: [PATCH v2 04/10] perf util: Add rbtree node_delete ops To: Jiri Olsa Cc: acme@kernel.org, jolsa@kernel.org, peterz@infradead.org, mingo@redhat.com, alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org, ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com References: <1511791650-24072-1-git-send-email-yao.jin@linux.intel.com> <1511791650-24072-5-git-send-email-yao.jin@linux.intel.com> <20171128111222.GB2732@krava> From: "Jin, Yao" Message-ID: Date: Tue, 28 Nov 2017 20:14:32 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171128111222.GB2732@krava> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/28/2017 7:12 PM, Jiri Olsa wrote: > On Mon, Nov 27, 2017 at 10:07:24PM +0800, Jin Yao wrote: > > SNIP > >> @@ -124,13 +137,25 @@ static struct saved_value *saved_value_lookup(struct perf_evsel *evsel, >> return NULL; >> } >> >> +void runtime_stat__init(struct runtime_stat *stat) >> +{ >> + struct rblist *rblist = &stat->value_list; >> + >> + rblist__init(rblist); >> + rblist->node_cmp = saved_value_cmp; >> + rblist->node_new = saved_value_new; >> + rblist->node_delete = saved_value_delete; >> +} >> + >> +void runtime_stat__free(struct runtime_stat *stat) >> +{ >> + rblist__reset(&stat->value_list); >> +} >> + >> void perf_stat__init_shadow_stats(void) >> { >> have_frontend_stalled = pmu_have_event("cpu", "stalled-cycles-frontend"); >> - rblist__init(&runtime_saved_values); >> - runtime_saved_values.node_cmp = saved_value_cmp; >> - runtime_saved_values.node_new = saved_value_new; >> - /* No delete for now */ > > hum, you should you remove this at the switching point > to keep it bisectable.. now it crashes: > > [jolsa@krava perf]$ sudo ./perf stat -M Summary --metric-only -a sleep 1 > Segmentation fault > > > jirka > Oh, let me double check for the bisect issue. Thanks Jin Yao