From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-2392595-1517454801-2-13219578633567739772 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, FREEMAIL_FORGED_FROMDOMAIN 0.195, FREEMAIL_FROM 0.001, HEADER_FROM_DIFFERENT_DOMAINS 0.001, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='utf-8' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1517454800; b=lhfitzX3/tTfNbxk2euAVAcl1Ei6TxoKzdNgA7cY4LaDCZS 3pBOts5lsYB84bCbORejpyhKv/HgWWwGfdhJb0M89dFmBrEWXXhohRgljcQQXfSI XmqKe2QIYXGqS6cTCjrd/aO4FfS/f3Wj9ZwkrRZwqc2ail2qIpXykAVvBx+MFQ2f XJ6YjZwzGjLVpIro8C18gxYISQul+1J+ypH7oGTXu+zN007Bkgc4+F+TbDVSTd5q M450wp8hxcEkpjDGmo6Jp++xgUBjHp4NSrBVbaZR0PullqHm8NAa/zpaTrBrHkxX UyBhkdYFkDZdw/dQ5bh88u9sGZF39rXeSJHpiNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=subject:to:cc:references:from:message-id :date:mime-version:in-reply-to:content-type :content-transfer-encoding:sender:list-id; s=arctest; t= 1517454800; bh=XorRyV3pe3CxEosjSXmL5pb+HOg+FEwaEe3YYxGHggA=; b=o LzPK4YRqqLQwu9evVRqwkCyPyLPby85rbcbGhEOEUk+GBlw4wAhKV7i5c1nIApUW D139LDX5sP7/gdz+RO0KGFL1Xm2WgrPN2/lm+kv0Y+Mvpz+mLHclaYvkj9v9e3yz MOE8rPW9kSFzCxJlYyj4XwDPpBk9IXenqF3GM3Z4xkHDNNs8RHYuWQlAbyWDsDQX atP2VNLz38HTmnd1m02moI2ymk9KMvPwZg1M3Ch0CcQjBeNFB3TsXSvLp7RuU9l9 nyjbfZa4wE3C6mGrSiAWBp7ppXRK2Z1dUYRpG7fUO4ybjK02qkoAe7FD3AThhi2m xJou67mOWO1XxWDeIF0PQ== ARC-Authentication-Results: i=1; mx6.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=Q0Dh7CPb x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=gmail.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-google-dkim=fail (body has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=g7v+3u1c; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=gmail.com header.result=pass header_is_org_domain=yes Authentication-Results: mx6.messagingengine.com; arc=none (no signatures found); dkim=fail (body has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=Q0Dh7CPb x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=gmail.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-google-dkim=fail (body has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=g7v+3u1c; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=gmail.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751296AbeBADNF (ORCPT ); Wed, 31 Jan 2018 22:13:05 -0500 Received: from mail-pl0-f67.google.com ([209.85.160.67]:42623 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750829AbeBADNE (ORCPT ); Wed, 31 Jan 2018 22:13:04 -0500 X-Google-Smtp-Source: AH8x225zcyxc8tiHVQnpWfZxcLJiP0Vi2OyHNAqt2hwm9oSQ+x7j1kPc7/iqYggMj1gcIYTZTH4tYA== Subject: Re: [PATCH 3/5] USB: serial: f81232: enable remote wakeup via RX/RI pin To: Johan Hovold Cc: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, peter_hong@fintek.com.tw, "Ji-Ze Hong (Peter Hong)" References: <1516607927-8887-1-git-send-email-hpeter+linux_kernel@gmail.com> <1516607927-8887-3-git-send-email-hpeter+linux_kernel@gmail.com> <20180130035747.GB3434@localhost> From: "Ji-Ze Hong (Peter Hong)" Message-ID: Date: Thu, 1 Feb 2018 11:13:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180130035747.GB3434@localhost> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Hi Johan, Johan Hovold 於 2018/1/30 上午 11:57 寫道: > On Mon, Jan 22, 2018 at 03:58:45PM +0800, Ji-Ze Hong (Peter Hong) wrote: >> The F81232 can do remote wakeup via RX/RI pin with pulse. >> This patch will use device_set_wakeup_enable to enable this >> feature. > > This is a policy decision that should be made by user space by setting > the power/wakeup attribute, and not something that something that > drivers should enable directly themselves. > > Perhaps you really wanted to use device_set_wakeup_capable()? But then > you also need to honour the current setting in suspend() as well. > > How have you tested this feature? > Our USB-To-Serial support RI/ RX remote wakeup by Modem, Fax or other peripherals and we had tested it by following procedure with device_set_wakeup_enable() enabled: 1. Using pm-suspend to S3 2. Trigger a pulse to RI/RX to wake up system. In our test, we can do remote wakeup only with device_set_wakeup_enable() enabled. Should we add device_set_wakeup_capable() & device_set_wakeup_enable() like following link?? https://elixir.free-electrons.com/linux/latest/source/drivers/media/rc/mceusb.c#L1476 Thanks -- With Best Regards, Peter Hong