* RE: [RFC PATCH 0/2] Avoid booting stall caused by idmap_kpti_install_ng_mappings
@ 2021-01-20 4:51 Justin He
2021-01-20 10:58 ` Marc Zyngier
0 siblings, 1 reply; 4+ messages in thread
From: Justin He @ 2021-01-20 4:51 UTC (permalink / raw)
To: Catalin Marinas, Will Deacon,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: Anshuman Khandual, Suzuki Poulose, Mark Rutland,
Gustavo A. R. Silva, Richard Henderson, Dave P Martin,
Steven Price, Andrew Morton, Mike Rapoport, Ard Biesheuvel,
Gavin Shan, Kefeng Wang, Mark Brown, Marc Zyngier,
Cristian Marussi
Hi,
Kindly ping 😊
> -----Original Message-----
> From: Jia He <justin.he@arm.com>
> Sent: Wednesday, January 13, 2021 9:41 AM
> To: Catalin Marinas <Catalin.Marinas@arm.com>; Will Deacon
> <will@kernel.org>; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Cc: Anshuman Khandual <Anshuman.Khandual@arm.com>; Suzuki Poulose
> <Suzuki.Poulose@arm.com>; Justin He <Justin.He@arm.com>; Mark Rutland
> <Mark.Rutland@arm.com>; Gustavo A. R. Silva <gustavoars@kernel.org>;
> Richard Henderson <richard.henderson@linaro.org>; Dave P Martin
> <Dave.Martin@arm.com>; Steven Price <Steven.Price@arm.com>; Andrew Morton
> <akpm@linux-foundation.org>; Mike Rapoport <rppt@kernel.org>; Ard
> Biesheuvel <ardb@kernel.org>; Gavin Shan <gshan@redhat.com>; Kefeng Wang
> <wangkefeng.wang@huawei.com>; Mark Brown <broonie@kernel.org>; Marc Zyngier
> <maz@kernel.org>; Cristian Marussi <Cristian.Marussi@arm.com>
> Subject: [RFC PATCH 0/2] Avoid booting stall caused by
>
> There is a 10s stall in idmap_kpti_install_ng_mappings when kernel boots
> on a Ampere EMAG server.
>
> Commit f992b4dfd58b ("arm64: kpti: Add ->enable callback to remap
> swapper using nG mappings") updates the nG bit runtime if kpti is
> required.
>
> But things get worse if rodata=full in map_mem(). NO_BLOCK_MAPPINGS |
> NO_CONT_MAPPINGS is required when creating pagetable mapping. Hence all
> ptes are fully mapped in this case. On a Ampere EMAG server with 256G
> memory(pagesize=4k), it causes the 10s stall.
>
> After moving init_cpu_features() ahead of early_fixmap_init(), we can use
> cpu_have_const_cap earlier than before. Hence we can avoid this stall
> by updating arm64_use_ng_mappings.
>
> After this patch series, it reduces the kernel boot time from 14.7s to
> 4.1s:
> Before:
> [ 14.757569] Freeing initrd memory: 60752K
> After:
> [ 4.138819] Freeing initrd memory: 60752K
>
> Set it as RFC because I want to resolve any other points which I have
> misconerned.
>
> Jia He (2):
> arm64/cpuinfo: Move init_cpu_features() ahead of early_fixmap_init()
> arm64: kpti: Update arm64_use_ng_mappings before pagetable mapping
>
> arch/arm64/include/asm/cpu.h | 1 +
> arch/arm64/kernel/cpuinfo.c | 13 ++++++++++---
> arch/arm64/kernel/setup.c | 18 +++++++++++++-----
> arch/arm64/kernel/smp.c | 3 +--
> 4 files changed, 25 insertions(+), 10 deletions(-)
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [RFC PATCH 0/2] Avoid booting stall caused by idmap_kpti_install_ng_mappings
2021-01-20 4:51 [RFC PATCH 0/2] Avoid booting stall caused by idmap_kpti_install_ng_mappings Justin He
@ 2021-01-20 10:58 ` Marc Zyngier
2021-01-20 15:55 ` Justin He
0 siblings, 1 reply; 4+ messages in thread
From: Marc Zyngier @ 2021-01-20 10:58 UTC (permalink / raw)
To: Justin He
Cc: Catalin Marinas, Will Deacon, linux-arm-kernel, linux-kernel,
Anshuman Khandual, Suzuki Poulose, Mark Rutland,
Gustavo A. R. Silva, Richard Henderson, Dave P Martin,
Steven Price, Andrew Morton, Mike Rapoport, Ard Biesheuvel,
Gavin Shan, Kefeng Wang, Mark Brown, Cristian Marussi
Hi Justin,
On 2021-01-20 04:51, Justin He wrote:
> Hi,
> Kindly ping 😊
>
>> -----Original Message-----
>> From: Jia He <justin.he@arm.com>
>> Sent: Wednesday, January 13, 2021 9:41 AM
>> To: Catalin Marinas <Catalin.Marinas@arm.com>; Will Deacon
>> <will@kernel.org>; linux-arm-kernel@lists.infradead.org; linux-
>> kernel@vger.kernel.org
>> Cc: Anshuman Khandual <Anshuman.Khandual@arm.com>; Suzuki Poulose
>> <Suzuki.Poulose@arm.com>; Justin He <Justin.He@arm.com>; Mark Rutland
>> <Mark.Rutland@arm.com>; Gustavo A. R. Silva <gustavoars@kernel.org>;
>> Richard Henderson <richard.henderson@linaro.org>; Dave P Martin
>> <Dave.Martin@arm.com>; Steven Price <Steven.Price@arm.com>; Andrew
>> Morton
>> <akpm@linux-foundation.org>; Mike Rapoport <rppt@kernel.org>; Ard
>> Biesheuvel <ardb@kernel.org>; Gavin Shan <gshan@redhat.com>; Kefeng
>> Wang
>> <wangkefeng.wang@huawei.com>; Mark Brown <broonie@kernel.org>; Marc
>> Zyngier
>> <maz@kernel.org>; Cristian Marussi <Cristian.Marussi@arm.com>
>> Subject: [RFC PATCH 0/2] Avoid booting stall caused by
>>
>> There is a 10s stall in idmap_kpti_install_ng_mappings when kernel
>> boots
>> on a Ampere EMAG server.
>>
>> Commit f992b4dfd58b ("arm64: kpti: Add ->enable callback to remap
>> swapper using nG mappings") updates the nG bit runtime if kpti is
>> required.
>>
>> But things get worse if rodata=full in map_mem(). NO_BLOCK_MAPPINGS |
>> NO_CONT_MAPPINGS is required when creating pagetable mapping. Hence
>> all
>> ptes are fully mapped in this case. On a Ampere EMAG server with 256G
>> memory(pagesize=4k), it causes the 10s stall.
>>
>> After moving init_cpu_features() ahead of early_fixmap_init(), we can
>> use
>> cpu_have_const_cap earlier than before. Hence we can avoid this stall
>> by updating arm64_use_ng_mappings.
>>
>> After this patch series, it reduces the kernel boot time from 14.7s to
>> 4.1s:
>> Before:
>> [ 14.757569] Freeing initrd memory: 60752K
>> After:
>> [ 4.138819] Freeing initrd memory: 60752K
>>
>> Set it as RFC because I want to resolve any other points which I have
>> misconerned.
But you don't really explain *why* having the CPU Feature discovery
early helps at all. Is that so that you can bypass the idmap mapping?
I'd expect something that explain the problem instead of paraphrasing
the patches.
Another thing is whether you have tested this on some ThunderX HW
(the first version, not TX2), as this is the whole reason for this
code...
Thanks,
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [RFC PATCH 0/2] Avoid booting stall caused by idmap_kpti_install_ng_mappings
2021-01-20 10:58 ` Marc Zyngier
@ 2021-01-20 15:55 ` Justin He
2021-01-25 6:36 ` Justin He
0 siblings, 1 reply; 4+ messages in thread
From: Justin He @ 2021-01-20 15:55 UTC (permalink / raw)
To: Marc Zyngier
Cc: Catalin Marinas, Will Deacon,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Anshuman Khandual, Suzuki Poulose,
Mark Rutland, Gustavo A. R. Silva, Richard Henderson,
Dave P Martin, Steven Price, Andrew Morton, Mike Rapoport,
Ard Biesheuvel, Gavin Shan, Kefeng Wang, Mark Brown,
Cristian Marussi
Hi Marc
> -----Original Message-----
> From: Marc Zyngier <maz@kernel.org>
> Sent: Wednesday, January 20, 2021 6:58 PM
> To: Justin He <Justin.He@arm.com>
> Cc: Catalin Marinas <Catalin.Marinas@arm.com>; Will Deacon
> <will@kernel.org>; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; Anshuman Khandual <Anshuman.Khandual@arm.com>;
> Suzuki Poulose <Suzuki.Poulose@arm.com>; Mark Rutland
> <Mark.Rutland@arm.com>; Gustavo A. R. Silva <gustavoars@kernel.org>;
> Richard Henderson <richard.henderson@linaro.org>; Dave P Martin
> <Dave.Martin@arm.com>; Steven Price <Steven.Price@arm.com>; Andrew Morton
> <akpm@linux-foundation.org>; Mike Rapoport <rppt@kernel.org>; Ard
> Biesheuvel <ardb@kernel.org>; Gavin Shan <gshan@redhat.com>; Kefeng Wang
> <wangkefeng.wang@huawei.com>; Mark Brown <broonie@kernel.org>; Cristian
> Marussi <Cristian.Marussi@arm.com>
> Subject: Re: [RFC PATCH 0/2] Avoid booting stall caused by
> idmap_kpti_install_ng_mappings
>
> Hi Justin,
>
> On 2021-01-20 04:51, Justin He wrote:
> > Hi,
> > Kindly ping 😊
> >
> >> -----Original Message-----
> >> From: Jia He <justin.he@arm.com>
> >> Sent: Wednesday, January 13, 2021 9:41 AM
> >> To: Catalin Marinas <Catalin.Marinas@arm.com>; Will Deacon
> >> <will@kernel.org>; linux-arm-kernel@lists.infradead.org; linux-
> >> kernel@vger.kernel.org
> >> Cc: Anshuman Khandual <Anshuman.Khandual@arm.com>; Suzuki Poulose
> >> <Suzuki.Poulose@arm.com>; Justin He <Justin.He@arm.com>; Mark Rutland
> >> <Mark.Rutland@arm.com>; Gustavo A. R. Silva <gustavoars@kernel.org>;
> >> Richard Henderson <richard.henderson@linaro.org>; Dave P Martin
> >> <Dave.Martin@arm.com>; Steven Price <Steven.Price@arm.com>; Andrew
> >> Morton
> >> <akpm@linux-foundation.org>; Mike Rapoport <rppt@kernel.org>; Ard
> >> Biesheuvel <ardb@kernel.org>; Gavin Shan <gshan@redhat.com>; Kefeng
> >> Wang
> >> <wangkefeng.wang@huawei.com>; Mark Brown <broonie@kernel.org>; Marc
> >> Zyngier
> >> <maz@kernel.org>; Cristian Marussi <Cristian.Marussi@arm.com>
> >> Subject: [RFC PATCH 0/2] Avoid booting stall caused by
> >>
> >> There is a 10s stall in idmap_kpti_install_ng_mappings when kernel
> >> boots
> >> on a Ampere EMAG server.
> >>
> >> Commit f992b4dfd58b ("arm64: kpti: Add ->enable callback to remap
> >> swapper using nG mappings") updates the nG bit runtime if kpti is
> >> required.
> >>
> >> But things get worse if rodata=full in map_mem(). NO_BLOCK_MAPPINGS |
> >> NO_CONT_MAPPINGS is required when creating pagetable mapping. Hence
> >> all
> >> ptes are fully mapped in this case. On a Ampere EMAG server with 256G
> >> memory(pagesize=4k), it causes the 10s stall.
> >>
> >> After moving init_cpu_features() ahead of early_fixmap_init(), we can
> >> use
> >> cpu_have_const_cap earlier than before. Hence we can avoid this stall
> >> by updating arm64_use_ng_mappings.
> >>
> >> After this patch series, it reduces the kernel boot time from 14.7s to
> >> 4.1s:
> >> Before:
> >> [ 14.757569] Freeing initrd memory: 60752K
> >> After:
> >> [ 4.138819] Freeing initrd memory: 60752K
> >>
> >> Set it as RFC because I want to resolve any other points which I have
> >> misconerned.
>
> But you don't really explain *why* having the CPU Feature discovery
> early helps at all. Is that so that you can bypass the idmap mapping?
Adding nG bits can be avoided by having the discovery of boot cpu feature
earlier since the nG bit had been set in PTE_MAYBE_NG/PMD_MAYBE_NG
Before this patch:
1. kernel will firstly create mapping in setup_arch->paging_init->map_mem
-> __map_memblock
2. Then if kpti is required, kernel will add nG bits for each pte entry.
3. In extreme case, e.g. physical memory is 256G,rodata=full, and pagesize
is 4K, the nG bits updating in step 2 takes about 10s.
> I'd expect something that explain the problem instead of paraphrasing
> the patches.
>
> Another thing is whether you have tested this on some ThunderX HW
I will find a TX1 as you told to see any difference.
--
Cheers,
Justin (Jia He)
> (the first version, not TX2), as this is the whole reason for this
> code...
>
> Thanks,
>
> M.
> --
> Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [RFC PATCH 0/2] Avoid booting stall caused by idmap_kpti_install_ng_mappings
2021-01-20 15:55 ` Justin He
@ 2021-01-25 6:36 ` Justin He
0 siblings, 0 replies; 4+ messages in thread
From: Justin He @ 2021-01-25 6:36 UTC (permalink / raw)
To: Marc Zyngier
Cc: Catalin Marinas, Will Deacon,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Anshuman Khandual, Suzuki Poulose,
Mark Rutland, Gustavo A. R. Silva, Richard Henderson,
Dave P Martin, Steven Price, Andrew Morton, Mike Rapoport,
Ard Biesheuvel, Gavin Shan, Kefeng Wang, Mark Brown,
Cristian Marussi
Hi Marc
> -----Original Message-----
> From: Justin He
> Sent: Wednesday, January 20, 2021 11:56 PM
> To: Marc Zyngier <maz@kernel.org>
> Cc: Catalin Marinas <Catalin.Marinas@arm.com>; Will Deacon
> <will@kernel.org>; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org; Anshuman Khandual <Anshuman.Khandual@arm.com>;
> Suzuki Poulose <Suzuki.Poulose@arm.com>; Mark Rutland
> <Mark.Rutland@arm.com>; Gustavo A. R. Silva <gustavoars@kernel.org>;
> Richard Henderson <richard.henderson@linaro.org>; Dave P Martin
> <Dave.Martin@arm.com>; Steven Price <Steven.Price@arm.com>; Andrew Morton
> <akpm@linux-foundation.org>; Mike Rapoport <rppt@kernel.org>; Ard
> Biesheuvel <ardb@kernel.org>; Gavin Shan <gshan@redhat.com>; Kefeng Wang
> <wangkefeng.wang@huawei.com>; Mark Brown <broonie@kernel.org>; Cristian
> Marussi <Cristian.Marussi@arm.com>
> Subject: RE: [RFC PATCH 0/2] Avoid booting stall caused by
> idmap_kpti_install_ng_mappings
>
> Hi Marc
>
> > -----Original Message-----
> > From: Marc Zyngier <maz@kernel.org>
> > Sent: Wednesday, January 20, 2021 6:58 PM
> > To: Justin He <Justin.He@arm.com>
> > Cc: Catalin Marinas <Catalin.Marinas@arm.com>; Will Deacon
> > <will@kernel.org>; linux-arm-kernel@lists.infradead.org; linux-
> > kernel@vger.kernel.org; Anshuman Khandual <Anshuman.Khandual@arm.com>;
> > Suzuki Poulose <Suzuki.Poulose@arm.com>; Mark Rutland
> > <Mark.Rutland@arm.com>; Gustavo A. R. Silva <gustavoars@kernel.org>;
> > Richard Henderson <richard.henderson@linaro.org>; Dave P Martin
> > <Dave.Martin@arm.com>; Steven Price <Steven.Price@arm.com>; Andrew Morton
> > <akpm@linux-foundation.org>; Mike Rapoport <rppt@kernel.org>; Ard
> > Biesheuvel <ardb@kernel.org>; Gavin Shan <gshan@redhat.com>; Kefeng Wang
> > <wangkefeng.wang@huawei.com>; Mark Brown <broonie@kernel.org>; Cristian
> > Marussi <Cristian.Marussi@arm.com>
> > Subject: Re: [RFC PATCH 0/2] Avoid booting stall caused by
> > idmap_kpti_install_ng_mappings
> >
> > Hi Justin,
> >
> > On 2021-01-20 04:51, Justin He wrote:
> > > Hi,
> > > Kindly ping 😊
> > >
> > >> -----Original Message-----
> > >> From: Jia He <justin.he@arm.com>
> > >> Sent: Wednesday, January 13, 2021 9:41 AM
> > >> To: Catalin Marinas <Catalin.Marinas@arm.com>; Will Deacon
> > >> <will@kernel.org>; linux-arm-kernel@lists.infradead.org; linux-
> > >> kernel@vger.kernel.org
> > >> Cc: Anshuman Khandual <Anshuman.Khandual@arm.com>; Suzuki Poulose
> > >> <Suzuki.Poulose@arm.com>; Justin He <Justin.He@arm.com>; Mark Rutland
> > >> <Mark.Rutland@arm.com>; Gustavo A. R. Silva <gustavoars@kernel.org>;
> > >> Richard Henderson <richard.henderson@linaro.org>; Dave P Martin
> > >> <Dave.Martin@arm.com>; Steven Price <Steven.Price@arm.com>; Andrew
> > >> Morton
> > >> <akpm@linux-foundation.org>; Mike Rapoport <rppt@kernel.org>; Ard
> > >> Biesheuvel <ardb@kernel.org>; Gavin Shan <gshan@redhat.com>; Kefeng
> > >> Wang
> > >> <wangkefeng.wang@huawei.com>; Mark Brown <broonie@kernel.org>; Marc
> > >> Zyngier
> > >> <maz@kernel.org>; Cristian Marussi <Cristian.Marussi@arm.com>
> > >> Subject: [RFC PATCH 0/2] Avoid booting stall caused by
> > >>
> > >> There is a 10s stall in idmap_kpti_install_ng_mappings when kernel
> > >> boots
> > >> on a Ampere EMAG server.
> > >>
> > >> Commit f992b4dfd58b ("arm64: kpti: Add ->enable callback to remap
> > >> swapper using nG mappings") updates the nG bit runtime if kpti is
> > >> required.
> > >>
> > >> But things get worse if rodata=full in map_mem(). NO_BLOCK_MAPPINGS |
> > >> NO_CONT_MAPPINGS is required when creating pagetable mapping. Hence
> > >> all
> > >> ptes are fully mapped in this case. On a Ampere EMAG server with 256G
> > >> memory(pagesize=4k), it causes the 10s stall.
> > >>
> > >> After moving init_cpu_features() ahead of early_fixmap_init(), we can
> > >> use
> > >> cpu_have_const_cap earlier than before. Hence we can avoid this stall
> > >> by updating arm64_use_ng_mappings.
> > >>
> > >> After this patch series, it reduces the kernel boot time from 14.7s to
> > >> 4.1s:
> > >> Before:
> > >> [ 14.757569] Freeing initrd memory: 60752K
> > >> After:
> > >> [ 4.138819] Freeing initrd memory: 60752K
> > >>
> > >> Set it as RFC because I want to resolve any other points which I have
> > >> misconerned.
> >
> > But you don't really explain *why* having the CPU Feature discovery
> > early helps at all. Is that so that you can bypass the idmap mapping?
>
> Adding nG bits can be avoided by having the discovery of boot cpu feature
> earlier since the nG bit had been set in PTE_MAYBE_NG/PMD_MAYBE_NG
>
> Before this patch:
> 1. kernel will firstly create mapping in setup_arch->paging_init->map_mem
> -> __map_memblock
> 2. Then if kpti is required, kernel will add nG bits for each pte entry.
> 3. In extreme case, e.g. physical memory is 256G,rodata=full, and pagesize
> is 4K, the nG bits updating in step 2 takes about 10s.
>
> > I'd expect something that explain the problem instead of paraphrasing
> > the patches.
> >
> > Another thing is whether you have tested this on some ThunderX HW
>
> I will find a TX1 as you told to see any difference.
>
>
I fortunately found a cavium TX1.
Seems that unmap_kernel_at_el0 is false:
...
[ 0.000000] Machine model: Cavium ThunderX CN88XX board
...
[ 0.000000] CPU features: kernel page table isolation forced OFF by ARM64_WORKAROUND_CAVIUM_27456
...
Hence no such stall *before* and *after* this patch set because kpti is not enabled.
--
Cheers,
Justin (Jia He)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-01-25 6:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-20 4:51 [RFC PATCH 0/2] Avoid booting stall caused by idmap_kpti_install_ng_mappings Justin He
2021-01-20 10:58 ` Marc Zyngier
2021-01-20 15:55 ` Justin He
2021-01-25 6:36 ` Justin He
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox