From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13036C6377D for ; Thu, 22 Jul 2021 03:03:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECC8860FF3 for ; Thu, 22 Jul 2021 03:03:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230407AbhGVCXV (ORCPT ); Wed, 21 Jul 2021 22:23:21 -0400 Received: from mga07.intel.com ([134.134.136.100]:16804 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230093AbhGVCXT (ORCPT ); Wed, 21 Jul 2021 22:23:19 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10052"; a="275374957" X-IronPort-AV: E=Sophos;i="5.84,259,1620716400"; d="scan'208";a="275374957" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2021 20:03:54 -0700 X-IronPort-AV: E=Sophos;i="5.84,259,1620716400"; d="scan'208";a="512019825" Received: from lingshan-mobl5.ccr.corp.intel.com (HELO [10.255.29.38]) ([10.255.29.38]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Jul 2021 20:03:46 -0700 Subject: Re: [PATCH V8 01/18] perf/core: Use static_call to optimize perf_guest_info_callbacks To: Like Xu Cc: bp@alien8.de, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, kan.liang@linux.intel.com, ak@linux.intel.com, wei.w.wang@intel.com, eranian@google.com, liuxiangdong5@huawei.com, linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org, boris.ostrvsky@oracle.com, Like Xu , Will Deacon , Marc Zyngier , Guo Ren , Nick Hu , Paul Walmsley , Boris Ostrovsky , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-csky@vger.kernel.org, linux-riscv@lists.infradead.org, xen-devel@lists.xenproject.org, Peter Zijlstra , Paolo Bonzini References: <20210716085325.10300-1-lingshan.zhu@intel.com> <20210716085325.10300-2-lingshan.zhu@intel.com> From: "Zhu, Lingshan" Message-ID: Date: Thu, 22 Jul 2021 11:03:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/21/2021 7:57 PM, Like Xu wrote: > On 16/7/2021 4:53 pm, Zhu Lingshan wrote: >> +    } else if (xenpmu_data->pmu.r.regs.cpl & 3) > > Lingshan, serious for this version ? > > arch/x86/xen/pmu.c:438:9: error: expected identifier or ‘(’ before > ‘return’ >   438 |         return state; >       |         ^~~~~~ > arch/x86/xen/pmu.c:439:1: error: expected identifier or ‘(’ before ‘}’ > token >   439 | } >       | ^ > arch/x86/xen/pmu.c: In function ‘xen_guest_state’: > arch/x86/xen/pmu.c:436:9: error: control reaches end of non-void > function [-Werror=return-type] >   436 |         } >       |         ^ > cc1: some warnings being treated as errors > >> +            state |= PERF_GUEST_USER; >>       } forgot to enable XEN build in .config, V9 fixes this will come soon