From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3B444502F for ; Sun, 9 Aug 2026 18:13:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786299190; cv=none; b=Ijh7uVxJmcuH4ZcfvrmfODvRuU02Uj6yv/QL4VCxkTZ7utYHdp3zNwnowbpbXMx9aSH8OdcalM1uYg4bH4FwCr7feyOOOwFQoBJd0h0zIGjSpXfNKm1vFbH7iWYHo+S1z2LPtv1USiMs2rQ0GlTXc7TM93W6uu74E53fAndRv40= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786299190; c=relaxed/simple; bh=C/W7wOWNrlRT+JcD2OV2qFK3TxuVDUS4saNwYQXWIx4=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=hZUjLcyY1gvpfNzHR1ZixQiL7gbShpce7vryv5gFUhhR85AYnLDl2qfmXM53Y3BvjImcUWgOGRnbFX+JWgcBDEkivi01VQYufITcxLWvehvXYk7KYq8DXy3lCigdxa/B/BiBHMdWW+0rMYQLpogo0unkqqnRpMTjkmTpaeNyRsc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TgCJJJmK; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TgCJJJmK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1786299188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C/W7wOWNrlRT+JcD2OV2qFK3TxuVDUS4saNwYQXWIx4=; b=TgCJJJmKjjP/DgaZHeYDoQyuwqMi7YEvZRDqDjEoT7XzbhFoN/+Efy/gXftPgz0Dq8Tkmo Sa77KaI83ionCfV8VLv4olNa/PE8LPiFMtPoqzM19//UrZ4rdGfe/wHk9qs+dwyUuNBkz0 G2L4RmwFB/qyi33mAf+xtoU9beY/VJM= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-130-Ekk__YeoPAaiAKZ5b6WNTQ-1; Sun, 09 Aug 2026 14:12:59 -0400 X-MC-Unique: Ekk__YeoPAaiAKZ5b6WNTQ-1 X-Mimecast-MFC-AGG-ID: Ekk__YeoPAaiAKZ5b6WNTQ_1786299177 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 56FDE1800471; Sun, 9 Aug 2026 18:12:57 +0000 (UTC) Received: from [10.44.32.36] (unknown [10.44.32.36]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D247930001A2; Sun, 9 Aug 2026 18:12:52 +0000 (UTC) Message-ID: Date: Sun, 9 Aug 2026 20:12:49 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 1/2] dpll: zl3073x: update all DPLL channels on ref_sync_set From: Ivan Vecera To: netdev@vger.kernel.org Cc: Arkadiusz Kubalewski , Jakub Kicinski , Jiri Pirko , Min Li , Paolo Abeni , Petr Oros , Richard Cochran , Vadim Fedorenko , linux-kernel@vger.kernel.org, Jonathan Corbet , Shuah Khan , linux-doc@vger.kernel.org References: <20260807095926.386923-1-ivecera@redhat.com> <20260807095926.386923-2-ivecera@redhat.com> Content-Language: en-US In-Reply-To: <20260807095926.386923-2-ivecera@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Sahisko findings and my replies... > Is the loss of the error return here intentional? > ... > isn't the pair being already armed exactly the reason the sync input > must not stay selectable? Yes, this is intentional. The ref sync pair is configured by the preceding zl3073x_ref_state_set() call and is fully functional at that point - the priority exclusion is a separate, advisory step recommended by the datasheet. It prevents the automatic selection algorithm from picking the sync source as a clock reference, which would be counterproductive but does not affect the sync pair itself. A failure in zl3073x_chan_state_set() here means a mailbox or bus error, which is highly unlikely during normal operation and would indicate a serious hardware problem that surfaces through other error paths as well. Propagating it to userspace would falsely suggest that the ref sync pair was not configured, when in fact it was. The dev_warn is sufficient to flag the condition for debugging. The old code propagated the error only because it was a single return statement at the end of the function - not because the priority update was considered essential for the operation to succeed. Ivan