* [PATCH v1 0/2] Tegra114: switch Tegra Note 7 from tn7 to tegratab
@ 2024-02-12 7:18 Svyatoslav Ryhel
2024-02-12 7:18 ` [PATCH v1 1/2] ARM: tegra: set correct naming for Tegra Note 7 Svyatoslav Ryhel
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Svyatoslav Ryhel @ 2024-02-12 7:18 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding,
Jonathan Hunter, Svyatoslav Ryhel, Shubhi Garg
Cc: devicetree, linux-tegra, linux-kernel
Currently Tegra Note 7 uses tn7 compatible and device tree name which is
not quite correct. This device has proper codename which is tegratab.
Switch tn7 in compatible to tegratab and set a better device tree name
tegra114-nvidia-tegratab which aligns with newer trees.
Svyatoslav Ryhel (2):
ARM: tegra: set correct naming for Tegra Note 7
dt-bindings: arm: tegra: document NVIDIA Tegra Note 7 properly
Documentation/devicetree/bindings/arm/tegra.yaml | 5 ++++-
arch/arm/boot/dts/nvidia/Makefile | 4 ++--
.../{tegra114-tn7.dts => tegra114-nvidia-tegratab.dts} | 5 +++--
3 files changed, 9 insertions(+), 5 deletions(-)
rename arch/arm/boot/dts/nvidia/{tegra114-tn7.dts => tegra114-nvidia-tegratab.dts} (98%)
--
2.40.1
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v1 1/2] ARM: tegra: set correct naming for Tegra Note 7 2024-02-12 7:18 [PATCH v1 0/2] Tegra114: switch Tegra Note 7 from tn7 to tegratab Svyatoslav Ryhel @ 2024-02-12 7:18 ` Svyatoslav Ryhel 2024-02-12 7:33 ` Krzysztof Kozlowski 2024-02-12 16:14 ` Jon Hunter 2024-02-12 7:18 ` [PATCH v1 2/2] dt-bindings: arm: tegra: document NVIDIA Tegra Note 7 properly Svyatoslav Ryhel 2024-02-12 16:13 ` [PATCH v1 0/2] Tegra114: switch Tegra Note 7 from tn7 to tegratab Jon Hunter 2 siblings, 2 replies; 8+ messages in thread From: Svyatoslav Ryhel @ 2024-02-12 7:18 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding, Jonathan Hunter, Svyatoslav Ryhel, Shubhi Garg Cc: devicetree, linux-tegra, linux-kernel Correct codename of Tegra Note 7 is "tegratab", while model name should be "NVIDIA Tegra Note 7". Fix this inconsistency. Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> --- arch/arm/boot/dts/nvidia/Makefile | 4 ++-- .../{tegra114-tn7.dts => tegra114-nvidia-tegratab.dts} | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) rename arch/arm/boot/dts/nvidia/{tegra114-tn7.dts => tegra114-nvidia-tegratab.dts} (98%) diff --git a/arch/arm/boot/dts/nvidia/Makefile b/arch/arm/boot/dts/nvidia/Makefile index 7a422f150488..474f3fbbd99d 100644 --- a/arch/arm/boot/dts/nvidia/Makefile +++ b/arch/arm/boot/dts/nvidia/Makefile @@ -2,8 +2,8 @@ dtb-$(CONFIG_ARCH_TEGRA_114_SOC) += \ tegra114-asus-tf701t.dtb \ tegra114-dalmore.dtb \ - tegra114-roth.dtb \ - tegra114-tn7.dtb + tegra114-nvidia-tegratab.dtb \ + tegra114-roth.dtb dtb-$(CONFIG_ARCH_TEGRA_124_SOC) += \ tegra124-apalis-eval.dtb \ tegra124-apalis-v1.2-eval.dtb \ diff --git a/arch/arm/boot/dts/nvidia/tegra114-tn7.dts b/arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts similarity index 98% rename from arch/arm/boot/dts/nvidia/tegra114-tn7.dts rename to arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts index bfbdb345575a..30b2ed91be23 100644 --- a/arch/arm/boot/dts/nvidia/tegra114-tn7.dts +++ b/arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts @@ -5,8 +5,9 @@ #include "tegra114.dtsi" / { - model = "Tegra Note 7"; - compatible = "nvidia,tn7", "nvidia,tegra114"; + model = "NVIDIA Tegra Note 7"; + compatible = "nvidia,tegratab", "nvidia,tegra114"; + chassis-type = "tablet"; chosen { /* TN7's bootloader's arguments need to be overridden */ -- 2.40.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v1 1/2] ARM: tegra: set correct naming for Tegra Note 7 2024-02-12 7:18 ` [PATCH v1 1/2] ARM: tegra: set correct naming for Tegra Note 7 Svyatoslav Ryhel @ 2024-02-12 7:33 ` Krzysztof Kozlowski 2024-02-12 16:14 ` Jon Hunter 1 sibling, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2024-02-12 7:33 UTC (permalink / raw) To: Svyatoslav Ryhel, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding, Jonathan Hunter, Shubhi Garg Cc: devicetree, linux-tegra, linux-kernel On 12/02/2024 08:18, Svyatoslav Ryhel wrote: > Correct codename of Tegra Note 7 is "tegratab", while model Which has nothing to do with compatible... > name should be "NVIDIA Tegra Note 7". Fix this inconsistency. That part is fine. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 1/2] ARM: tegra: set correct naming for Tegra Note 7 2024-02-12 7:18 ` [PATCH v1 1/2] ARM: tegra: set correct naming for Tegra Note 7 Svyatoslav Ryhel 2024-02-12 7:33 ` Krzysztof Kozlowski @ 2024-02-12 16:14 ` Jon Hunter 2024-02-12 16:50 ` Thierry Reding 1 sibling, 1 reply; 8+ messages in thread From: Jon Hunter @ 2024-02-12 16:14 UTC (permalink / raw) To: Svyatoslav Ryhel, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding, Shubhi Garg Cc: devicetree, linux-tegra, linux-kernel On 12/02/2024 07:18, Svyatoslav Ryhel wrote: > Correct codename of Tegra Note 7 is "tegratab", while model > name should be "NVIDIA Tegra Note 7". Fix this inconsistency. > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> > --- > arch/arm/boot/dts/nvidia/Makefile | 4 ++-- > .../{tegra114-tn7.dts => tegra114-nvidia-tegratab.dts} | 5 +++-- > 2 files changed, 5 insertions(+), 4 deletions(-) > rename arch/arm/boot/dts/nvidia/{tegra114-tn7.dts => tegra114-nvidia-tegratab.dts} (98%) > > diff --git a/arch/arm/boot/dts/nvidia/Makefile b/arch/arm/boot/dts/nvidia/Makefile > index 7a422f150488..474f3fbbd99d 100644 > --- a/arch/arm/boot/dts/nvidia/Makefile > +++ b/arch/arm/boot/dts/nvidia/Makefile > @@ -2,8 +2,8 @@ > dtb-$(CONFIG_ARCH_TEGRA_114_SOC) += \ > tegra114-asus-tf701t.dtb \ > tegra114-dalmore.dtb \ > - tegra114-roth.dtb \ > - tegra114-tn7.dtb > + tegra114-nvidia-tegratab.dtb \ > + tegra114-roth.dtb > dtb-$(CONFIG_ARCH_TEGRA_124_SOC) += \ > tegra124-apalis-eval.dtb \ > tegra124-apalis-v1.2-eval.dtb \ > diff --git a/arch/arm/boot/dts/nvidia/tegra114-tn7.dts b/arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts > similarity index 98% > rename from arch/arm/boot/dts/nvidia/tegra114-tn7.dts > rename to arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts > index bfbdb345575a..30b2ed91be23 100644 > --- a/arch/arm/boot/dts/nvidia/tegra114-tn7.dts > +++ b/arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts > @@ -5,8 +5,9 @@ > #include "tegra114.dtsi" > > / { > - model = "Tegra Note 7"; > - compatible = "nvidia,tn7", "nvidia,tegra114"; > + model = "NVIDIA Tegra Note 7"; > + compatible = "nvidia,tegratab", "nvidia,tegra114"; > + chassis-type = "tablet"; No mention of adding the chassis-type in the commit message. Seems like that should be a separate change. Jon -- nvpublic ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 1/2] ARM: tegra: set correct naming for Tegra Note 7 2024-02-12 16:14 ` Jon Hunter @ 2024-02-12 16:50 ` Thierry Reding 0 siblings, 0 replies; 8+ messages in thread From: Thierry Reding @ 2024-02-12 16:50 UTC (permalink / raw) To: Jon Hunter, Svyatoslav Ryhel, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Shubhi Garg Cc: devicetree, linux-tegra, linux-kernel [-- Attachment #1: Type: text/plain, Size: 2406 bytes --] On Mon Feb 12, 2024 at 5:14 PM CET, Jon Hunter wrote: > > On 12/02/2024 07:18, Svyatoslav Ryhel wrote: > > Correct codename of Tegra Note 7 is "tegratab", while model > > name should be "NVIDIA Tegra Note 7". Fix this inconsistency. > > > > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> > > --- > > arch/arm/boot/dts/nvidia/Makefile | 4 ++-- > > .../{tegra114-tn7.dts => tegra114-nvidia-tegratab.dts} | 5 +++-- > > 2 files changed, 5 insertions(+), 4 deletions(-) > > rename arch/arm/boot/dts/nvidia/{tegra114-tn7.dts => tegra114-nvidia-tegratab.dts} (98%) > > > > diff --git a/arch/arm/boot/dts/nvidia/Makefile b/arch/arm/boot/dts/nvidia/Makefile > > index 7a422f150488..474f3fbbd99d 100644 > > --- a/arch/arm/boot/dts/nvidia/Makefile > > +++ b/arch/arm/boot/dts/nvidia/Makefile > > @@ -2,8 +2,8 @@ > > dtb-$(CONFIG_ARCH_TEGRA_114_SOC) += \ > > tegra114-asus-tf701t.dtb \ > > tegra114-dalmore.dtb \ > > - tegra114-roth.dtb \ > > - tegra114-tn7.dtb > > + tegra114-nvidia-tegratab.dtb \ > > + tegra114-roth.dtb > > dtb-$(CONFIG_ARCH_TEGRA_124_SOC) += \ > > tegra124-apalis-eval.dtb \ > > tegra124-apalis-v1.2-eval.dtb \ > > diff --git a/arch/arm/boot/dts/nvidia/tegra114-tn7.dts b/arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts > > similarity index 98% > > rename from arch/arm/boot/dts/nvidia/tegra114-tn7.dts > > rename to arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts > > index bfbdb345575a..30b2ed91be23 100644 > > --- a/arch/arm/boot/dts/nvidia/tegra114-tn7.dts > > +++ b/arch/arm/boot/dts/nvidia/tegra114-nvidia-tegratab.dts > > @@ -5,8 +5,9 @@ > > #include "tegra114.dtsi" > > > > / { > > - model = "Tegra Note 7"; > > - compatible = "nvidia,tn7", "nvidia,tegra114"; > > + model = "NVIDIA Tegra Note 7"; > > + compatible = "nvidia,tegratab", "nvidia,tegra114"; > > + chassis-type = "tablet"; > > No mention of adding the chassis-type in the commit message. Seems like > that should be a separate change. Agreed. Along with Krzysztof's comments maybe this should just be a single patch that updates the model property and adds the chassis-type. We haven't used chassis-type before, but I see that the devicetree specification has it marked as "optional-but-recommended", so maybe we should make a pass over all files and add these as appropriate. Thierry [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v1 2/2] dt-bindings: arm: tegra: document NVIDIA Tegra Note 7 properly 2024-02-12 7:18 [PATCH v1 0/2] Tegra114: switch Tegra Note 7 from tn7 to tegratab Svyatoslav Ryhel 2024-02-12 7:18 ` [PATCH v1 1/2] ARM: tegra: set correct naming for Tegra Note 7 Svyatoslav Ryhel @ 2024-02-12 7:18 ` Svyatoslav Ryhel 2024-02-12 7:32 ` Krzysztof Kozlowski 2024-02-12 16:13 ` [PATCH v1 0/2] Tegra114: switch Tegra Note 7 from tn7 to tegratab Jon Hunter 2 siblings, 1 reply; 8+ messages in thread From: Svyatoslav Ryhel @ 2024-02-12 7:18 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding, Jonathan Hunter, Svyatoslav Ryhel, Shubhi Garg Cc: devicetree, linux-tegra, linux-kernel Document correct codename for NVIDIA Tegra Note 7 which is tegratab, not tn7. Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> --- Documentation/devicetree/bindings/arm/tegra.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/arm/tegra.yaml b/Documentation/devicetree/bindings/arm/tegra.yaml index fcf956406168..fc10886235ad 100644 --- a/Documentation/devicetree/bindings/arm/tegra.yaml +++ b/Documentation/devicetree/bindings/arm/tegra.yaml @@ -97,7 +97,10 @@ properties: - asus,tf701t - nvidia,dalmore - nvidia,roth - - nvidia,tn7 + - const: nvidia,tegra114 + - description: NVIDIA Tegra Note 7 + items: + - const: nvidia,tegratab - const: nvidia,tegra114 - items: - enum: -- 2.40.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v1 2/2] dt-bindings: arm: tegra: document NVIDIA Tegra Note 7 properly 2024-02-12 7:18 ` [PATCH v1 2/2] dt-bindings: arm: tegra: document NVIDIA Tegra Note 7 properly Svyatoslav Ryhel @ 2024-02-12 7:32 ` Krzysztof Kozlowski 0 siblings, 0 replies; 8+ messages in thread From: Krzysztof Kozlowski @ 2024-02-12 7:32 UTC (permalink / raw) To: Svyatoslav Ryhel, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding, Jonathan Hunter, Shubhi Garg Cc: devicetree, linux-tegra, linux-kernel On 12/02/2024 08:18, Svyatoslav Ryhel wrote: > Document correct codename for NVIDIA Tegra Note 7 which is tegratab, > not tn7. This is compatible, not codename. Change is meaningless, because compatibles are just unique strings. Old string was fine. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 0/2] Tegra114: switch Tegra Note 7 from tn7 to tegratab 2024-02-12 7:18 [PATCH v1 0/2] Tegra114: switch Tegra Note 7 from tn7 to tegratab Svyatoslav Ryhel 2024-02-12 7:18 ` [PATCH v1 1/2] ARM: tegra: set correct naming for Tegra Note 7 Svyatoslav Ryhel 2024-02-12 7:18 ` [PATCH v1 2/2] dt-bindings: arm: tegra: document NVIDIA Tegra Note 7 properly Svyatoslav Ryhel @ 2024-02-12 16:13 ` Jon Hunter 2 siblings, 0 replies; 8+ messages in thread From: Jon Hunter @ 2024-02-12 16:13 UTC (permalink / raw) To: Svyatoslav Ryhel, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Thierry Reding, Shubhi Garg Cc: devicetree, linux-tegra, linux-kernel On 12/02/2024 07:18, Svyatoslav Ryhel wrote: > Currently Tegra Note 7 uses tn7 compatible and device tree name which is > not quite correct. This device has proper codename which is tegratab. Certainly news to me :-) I have always known it as Tegra Note 7 and so 'tn7' as an abbreviation seems fine. Jon -- nvpublic ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-02-12 16:50 UTC | newest] Thread overview: 8+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-02-12 7:18 [PATCH v1 0/2] Tegra114: switch Tegra Note 7 from tn7 to tegratab Svyatoslav Ryhel 2024-02-12 7:18 ` [PATCH v1 1/2] ARM: tegra: set correct naming for Tegra Note 7 Svyatoslav Ryhel 2024-02-12 7:33 ` Krzysztof Kozlowski 2024-02-12 16:14 ` Jon Hunter 2024-02-12 16:50 ` Thierry Reding 2024-02-12 7:18 ` [PATCH v1 2/2] dt-bindings: arm: tegra: document NVIDIA Tegra Note 7 properly Svyatoslav Ryhel 2024-02-12 7:32 ` Krzysztof Kozlowski 2024-02-12 16:13 ` [PATCH v1 0/2] Tegra114: switch Tegra Note 7 from tn7 to tegratab Jon Hunter
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox