From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034083AbcIVSWb (ORCPT ); Thu, 22 Sep 2016 14:22:31 -0400 Received: from mx2.mailbox.org ([80.241.60.215]:60067 "EHLO mx2.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1033978AbcIVSW0 (ORCPT ); Thu, 22 Sep 2016 14:22:26 -0400 Subject: Re: [PATCH] staging:android:io: Fix multiple styling issues To: Yannis Damigos , gregkh@linuxfoundation.org References: <20160922175521.21814-1-giannis.damigos@gmail.com> Cc: devel@driverdev.osuosl.org, arve@android.com, riandrews@android.com, linux-kernel@vger.kernel.org From: =?UTF-8?Q?Markus_B=c3=b6hme?= Message-ID: Date: Thu, 22 Sep 2016 20:22:03 +0200 MIME-Version: 1.0 In-Reply-To: <20160922175521.21814-1-giannis.damigos@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Yannis! There is a typo in your one-line description/subject ("ion"). On 09/22/2016 07:55 PM, Yannis Damigos wrote: > This patch fixes 1 error, 1 warning and 14 checks found by > checkpatch. Please be more specific in your commit message and mention what exactly you are doing to the code and why. > > Signed-off-by: Yannis Damigos > --- > drivers/staging/android/ion/ion_of.c | 49 ++++++++++++++++++------------------ > 1 file changed, 24 insertions(+), 25 deletions(-) > > diff --git a/drivers/staging/android/ion/ion_of.c b/drivers/staging/android/ion/ion_of.c > index de0899a..c930416 100644 > --- a/drivers/staging/android/ion/ion_of.c > +++ b/drivers/staging/android/ion/ion_of.c > @@ -26,17 +26,17 @@ > #include "ion_of.h" > > int ion_parse_dt_heap_common(struct device_node *heap_node, > - struct ion_platform_heap *heap, > - struct ion_of_heap *compatible) > + struct ion_platform_heap *heap, > + struct ion_of_heap *compatible) You are changing whitespace here, ... > { > int i; > > - for (i = 0; compatible[i].name != NULL; i++) { > + for (i = 0; compatible[i].name; i++) { ... and are making a different kind of change here. > (Rest of patch with yet other types of changes snipped.) It would be nice to have each kind of change in a separate patch with a more precise commit message. Thanks, Markus