From: Hans de Goede <hansg@kernel.org>
To: "Anton Khirnov" <anton@khirnov.net>,
"Corentin Chary" <corentin.chary@gmail.com>,
"Luke D. Jones" <luke@ljones.dev>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>
Cc: platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v2 1/2] Input: allocate a keycode for Fn+space
Date: Tue, 15 Jul 2025 14:26:51 +0200 [thread overview]
Message-ID: <e8f9f83d-2279-4d1b-9caf-27e00f3b0740@kernel.org> (raw)
In-Reply-To: <20250714150756.21197-2-anton@khirnov.net>
Hi,
On 14-Jul-25 5:07 PM, Anton Khirnov wrote:
> The Asus ExpertBook B9 laptop sends a WMI event when Fn+space is
> pressed. Since I could not find any information on what this combination
> is intended to do on this or any other Asus laptop, allocate a
> KEY_FN_SPACE keycode for it.
>
> Signed-off-by: Anton Khirnov <anton@khirnov.net>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hansg@kernel.org>
Regards,
Hans
> ---
> include/uapi/linux/input-event-codes.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> index 3b2524e4b667..a49b0782fd8a 100644
> --- a/include/uapi/linux/input-event-codes.h
> +++ b/include/uapi/linux/input-event-codes.h
> @@ -548,6 +548,7 @@
> #define KEY_FN_S 0x1e3
> #define KEY_FN_B 0x1e4
> #define KEY_FN_RIGHT_SHIFT 0x1e5
> +#define KEY_FN_SPACE 0x1e6
>
> #define KEY_BRL_DOT1 0x1f1
> #define KEY_BRL_DOT2 0x1f2
next prev parent reply other threads:[~2025-07-15 12:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 15:07 [PATCH v2 0/2] platform/x86: asus-wmi: map more keys on ExpertBook B9 Anton Khirnov
2025-07-14 15:07 ` [PATCH v2 1/2] Input: allocate a keycode for Fn+space Anton Khirnov
2025-07-15 12:26 ` Hans de Goede [this message]
2025-08-07 7:04 ` Anton Khirnov
2025-07-14 15:07 ` [PATCH v2 2/2] platform/x86: asus-wmi: map more keys on ExpertBook B9 Anton Khirnov
2025-07-15 12:27 ` Hans de Goede
2025-08-27 15:29 ` [PATCH v3] " Anton Khirnov
2025-08-28 16:18 ` Ilpo Järvinen
2025-08-31 9:21 ` Anton Khirnov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8f9f83d-2279-4d1b-9caf-27e00f3b0740@kernel.org \
--to=hansg@kernel.org \
--cc=anton@khirnov.net \
--cc=corentin.chary@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).