From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A9E91EB5E3 for ; Thu, 18 Dec 2025 07:15:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766042112; cv=none; b=E6AGupDP0AUXH9I1YwSZmKqJanFxmfx3to3dlBmG0HhkVSoFFKWy4/eQSg5KaKDVoTVZtJYEsDp2QEvLFPwC4Xa0XbxANGY4Etb59u90ccGZM39SMY+4826TSfoQeTXV+Rr4l+oxAoVN2/sG0jTvtpgA50SJks/iiiEpKCKtPug= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766042112; c=relaxed/simple; bh=xsSR5/gROtCj621epPFc8z9dY6QJQQ7gGEk35KMHxK0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uZDCmMJgb7N5Bq8a1wRdwTUg4aKZnGKjPpJylPtKHvXH4APiLv4jIfcWTQBX5iDgjCzee8yqfjWjoSwD0r3FMLAyrFiLwSIIP9lUsnO5TbhXTGu7a0OPT/3o1b5ZLilDuV6Mo1Zs76Yc/g5NLx2jmbQCALkxUOZd6ktRHBOVFZk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YDdm6kiF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YDdm6kiF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B67ADC4CEFB; Thu, 18 Dec 2025 07:15:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1766042111; bh=xsSR5/gROtCj621epPFc8z9dY6QJQQ7gGEk35KMHxK0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=YDdm6kiFrsHFIigCgTMUyicseMcXv/IwcfId/8Rfq9RBAKmGHk/dxaVfSmWuLOgx8 LqVEMmq+y42Fnad8K0nLh7urq/CzvVo+Ha7Jj4DcwPHGvcc4QilPG3MiwPu4N/fua6 td/XPdO5yVny/RhgUqN1GFnUN5Oe/3HTmoBZib3pCqI+oY2rwCXCyhwBPEWky6vSDj uCTxKrHQMVgT1awg/XR5WSy1Sta9e2f3yJiXFb9E/H+G76ard2Xd0HEtNiNRWeoeaC k1cVyHklkL5q3iRH5jMeXEEMDnCz2Xo2rGxcTJbwhjxvvgQlNxBNcDubXQHLndxrX9 HLbKAjrWdqEFQ== Message-ID: Date: Thu, 18 Dec 2025 08:15:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 4/8] highmem: do range clearing in clear_user_highpages() To: Ankur Arora , linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org Cc: akpm@linux-foundation.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, mjguzik@gmail.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, willy@infradead.org, raghavendra.kt@amd.com, chleroy@kernel.org, ioworker0@gmail.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com References: <20251215204922.475324-1-ankur.a.arora@oracle.com> <20251215204922.475324-5-ankur.a.arora@oracle.com> From: "David Hildenbrand (Red Hat)" Content-Language: en-US In-Reply-To: <20251215204922.475324-5-ankur.a.arora@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 12/15/25 21:49, Ankur Arora wrote: > Use the range clearing primitive clear_user_pages() when clearing > contiguous pages in clear_user_highpages(). > > We can safely do that when we have !CONFIG_HIGHMEM and when the > architecture does not have clear_user_highpage. > > The first is necessary because not doing intermediate maps for > pages lets contiguous page ranges stay contiguous. The second, > because if the architecture has clear_user_highpage(), it likely > needs flushing magic when clearing the page, magic that we aren't > privy to. > > Signed-off-by: Ankur Arora > --- Can't you squash #4 into #2 if you move #3 in front of them? Or is there a dependency with #2 that I am missing? -- Cheers David