From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE069C001DF for ; Fri, 4 Aug 2023 10:31:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231309AbjHDKbB (ORCPT ); Fri, 4 Aug 2023 06:31:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41508 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230086AbjHDKa7 (ORCPT ); Fri, 4 Aug 2023 06:30:59 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FFCA2118 for ; Fri, 4 Aug 2023 03:30:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 99D4C61F91 for ; Fri, 4 Aug 2023 10:30:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50467C433C8; Fri, 4 Aug 2023 10:30:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691145057; bh=LisFYqrHrFx436SkEAziF8A92P7uY+qSA0OgMAPh/Bk=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=HlF/5mCQOEUrJx14dljhhBCHpirfYCLy6M1w9mj7gncmtLrJMYh0vwf244TKRZ/Gq zg6N/uEGVqdVBMSk0A/GsF+n8MlwudcVTwpvddOyOTUSeObVPquDd7cA5Q2QMuocoU Ly1J9cw/xJkm9wQGDkl5yTC6FsXOC4AD1CY91C7LE8/dYn9/+hpygf0tAUEDSfqfQg ozBRkyYXD4xPyCAIgaVHojJ+NyZ9QJwvnVgScvDp+L1cNo0d5T8WbWDQtUANXxzDuH qkMp/zBzq5KMl2puFlB//tIEVKF+C2bkIMsd11AeN43zF312M32FHnu7RHeHQI06hN z5fVyS/iZQ0Cg== Message-ID: Date: Fri, 4 Aug 2023 12:30:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Maciej Fijalkowski , Larysa Zaremba , Yunsheng Lin , Alexander Duyck , Jesper Dangaard Brouer , Ilias Apalodimas , Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v3 5/6] page_pool: add a lockdep check for recycling in hardirq Content-Language: en-US To: Alexander Lobakin , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni References: <20230803182038.2646541-1-aleksander.lobakin@intel.com> <20230803182038.2646541-6-aleksander.lobakin@intel.com> From: Jesper Dangaard Brouer In-Reply-To: <20230803182038.2646541-6-aleksander.lobakin@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/08/2023 20.20, Alexander Lobakin wrote: > From: Jakub Kicinski > > Page pool use in hardirq is prohibited, add debug checks > to catch misuses. IIRC we previously discussed using > DEBUG_NET_WARN_ON_ONCE() for this, but there were concerns > that people will have DEBUG_NET enabled in perf testing. > I don't think anyone enables lockdep in perf testing, > so use lockdep to avoid pushback and arguing :) > > Signed-off-by: Jakub Kicinski > Signed-off-by: Alexander Lobakin I like this. Acked-by: Jesper Dangaard Brouer