From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69520C77B75 for ; Tue, 23 May 2023 08:25:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235882AbjEWIZ0 (ORCPT ); Tue, 23 May 2023 04:25:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235793AbjEWIYR (ORCPT ); Tue, 23 May 2023 04:24:17 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5C3711FC3 for ; Tue, 23 May 2023 01:21:48 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D7BF9139F; Tue, 23 May 2023 01:22:32 -0700 (PDT) Received: from [10.162.42.7] (unknown [10.162.42.7]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id AF07C3F762; Tue, 23 May 2023 01:21:44 -0700 (PDT) Message-ID: Date: Tue, 23 May 2023 13:51:41 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 5/5] arm64/sysreg: Convert OSLAR_EL1 to automatic generation Content-Language: en-US To: Oliver Upton , Mark Brown Cc: Catalin Marinas , Will Deacon , Marc Zyngier , James Morse , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev References: <20230419-arm64-syreg-gen-v1-0-936cd769cb9e@kernel.org> <20230419-arm64-syreg-gen-v1-5-936cd769cb9e@kernel.org> From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/23/23 13:43, Oliver Upton wrote: > On Mon, May 22, 2023 at 05:22:44PM +0100, Mark Brown wrote: >> Convert OSLAR_EL1 to automatic generation as per DDI0601 2023-03. No >> functional change. >> >> Signed-off-by: Mark Brown >> --- >> arch/arm64/include/asm/sysreg.h | 3 --- >> arch/arm64/tools/sysreg | 5 +++++ >> 2 files changed, 5 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm64/include/asm/sysreg.h b/arch/arm64/include/asm/sysreg.h >> index 09de958e79ed..3b51e532caa9 100644 >> --- a/arch/arm64/include/asm/sysreg.h >> +++ b/arch/arm64/include/asm/sysreg.h >> @@ -140,9 +140,6 @@ >> #define SYS_DBGWCRn_EL1(n) sys_reg(2, 0, 0, n, 7) >> #define SYS_MDRAR_EL1 sys_reg(2, 0, 1, 0, 0) >> >> -#define SYS_OSLAR_EL1 sys_reg(2, 0, 1, 0, 4) >> -#define OSLAR_EL1_OSLK BIT(0) >> - >> #define SYS_OSLSR_EL1 sys_reg(2, 0, 1, 1, 4) >> #define OSLSR_EL1_OSLM_MASK (BIT(3) | BIT(0)) >> #define OSLSR_EL1_OSLM_NI 0 > > Should the OSLSR_EL1 definitions be rolled over to the generated scheme > as well? Agreed, was about to ask the same question :) Any reason it got skipped ? > >> diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg >> index a5ae0e19fc9f..84df0b7feb45 100644 >> --- a/arch/arm64/tools/sysreg >> +++ b/arch/arm64/tools/sysreg >> @@ -83,6 +83,11 @@ Res0 5:1 >> Field 0 SS >> EndSysreg >> >> +Sysreg OSLAR_EL1 2 0 1 0 4 >> +Res0 63:1 >> +Field 0 OSLK >> +EndSysreg >> + >> Sysreg ID_PFR0_EL1 3 0 0 1 0 >> Res0 63:32 >> UnsignedEnum 31:28 RAS >> >> -- >> 2.30.2 >> >