RE: [PATCH v3 3/6] irqchip: Introduce RTD1319 support using the Realtek common interrupt controller driver

James Tai [戴志峰]
2023-12-19T05:10:43Z

Hi Rob,

>> --- /dev/null
>> +++ b/drivers/irqchip/irq-realtek-rtd1319.c
>> @@ -0,0 +1,218 @@
>> +// SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
>> +/*
>> + * Realtek RTD1319 interrupt controller driver
>> + *
>> + * Copyright (c) 2023 Realtek Semiconductor Corporation */
>> +
>> +#include <linux/init.h>
>> +#include <linux/io.h>
>> +#include <linux/irqchip.h>
>> +#include <linux/of_device.h>
>
>You probably don't need this header and the implicit includes it makes are
>dropped now in linux-next. Please check what you actually need and make them
>explicit.
>
Thanks for the reminder. I will adjust it.

Regards,
James