* [PATCH] arm64: dts: qcom: msm8953-xiaomi-daisy: fix cd-gpios
@ 2025-08-30 21:59 Barnabás Czémán
2025-09-01 16:01 ` Bjorn Andersson
0 siblings, 1 reply; 4+ messages in thread
From: Barnabás Czémán @ 2025-08-30 21:59 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Alejandro Tafalla, Luca Weiss
Cc: linux-arm-msm, devicetree, linux-kernel,
Barnabás Czémán
Correct cd-gpios in xiaomi-daisy according to downstream sources
it is using GPIO_ACTIVE_HIGH instead of GPIO_ACTIVE_LOW.
Fixes: 38d779c26395 ("arm64: dts: qcom: msm8953: Add device tree for Xiaomi Mi A2 Lite")
Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
---
arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts b/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
index 336b916729e4721b5ba8f4f7e368d0d838aa54ab..ddd7af616794290aa1f06228a95cfa1d42b006e6 100644
--- a/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
+++ b/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
@@ -296,7 +296,7 @@ &sdhc_2 {
vmmc-supply = <&pm8953_l11>;
vqmmc-supply = <&pm8953_l12>;
- cd-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>;
+ cd-gpios = <&tlmm 133 GPIO_ACTIVE_HIGH>;
pinctrl-names = "default", "sleep";
pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_on>;
---
base-commit: 3cace99d63192a7250461b058279a42d91075d0c
change-id: 20250830-daisy-sd-fix-011c23468e2a
Best regards,
--
Barnabás Czémán <barnabas.czeman@mainlining.org>
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: msm8953-xiaomi-daisy: fix cd-gpios
2025-08-30 21:59 [PATCH] arm64: dts: qcom: msm8953-xiaomi-daisy: fix cd-gpios Barnabás Czémán
@ 2025-09-01 16:01 ` Bjorn Andersson
2025-09-01 18:32 ` barnabas.czeman
0 siblings, 1 reply; 4+ messages in thread
From: Bjorn Andersson @ 2025-09-01 16:01 UTC (permalink / raw)
To: Barnabás Czémán
Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alejandro Tafalla, Luca Weiss, linux-arm-msm, devicetree,
linux-kernel
On Sat, Aug 30, 2025 at 11:59:30PM +0200, Barnabás Czémán wrote:
> Correct cd-gpios in xiaomi-daisy according to downstream sources
> it is using GPIO_ACTIVE_HIGH instead of GPIO_ACTIVE_LOW.
Is the problem you're solving that the DT doesn't match downstream, or
that card detect doesn't work? Does it work after this patch, or is it
just aligned with downstream?
Regards,
Bjorn
>
> Fixes: 38d779c26395 ("arm64: dts: qcom: msm8953: Add device tree for Xiaomi Mi A2 Lite")
> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
> ---
> arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts b/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
> index 336b916729e4721b5ba8f4f7e368d0d838aa54ab..ddd7af616794290aa1f06228a95cfa1d42b006e6 100644
> --- a/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
> @@ -296,7 +296,7 @@ &sdhc_2 {
> vmmc-supply = <&pm8953_l11>;
> vqmmc-supply = <&pm8953_l12>;
>
> - cd-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>;
> + cd-gpios = <&tlmm 133 GPIO_ACTIVE_HIGH>;
>
> pinctrl-names = "default", "sleep";
> pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_on>;
>
> ---
> base-commit: 3cace99d63192a7250461b058279a42d91075d0c
> change-id: 20250830-daisy-sd-fix-011c23468e2a
>
> Best regards,
> --
> Barnabás Czémán <barnabas.czeman@mainlining.org>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: msm8953-xiaomi-daisy: fix cd-gpios
2025-09-01 16:01 ` Bjorn Andersson
@ 2025-09-01 18:32 ` barnabas.czeman
2025-09-02 10:20 ` Konrad Dybcio
0 siblings, 1 reply; 4+ messages in thread
From: barnabas.czeman @ 2025-09-01 18:32 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alejandro Tafalla, Luca Weiss, linux-arm-msm, devicetree,
linux-kernel
On 2025-09-01 18:01, Bjorn Andersson wrote:
> On Sat, Aug 30, 2025 at 11:59:30PM +0200, Barnabás Czémán wrote:
>> Correct cd-gpios in xiaomi-daisy according to downstream sources
>> it is using GPIO_ACTIVE_HIGH instead of GPIO_ACTIVE_LOW.
>
> Is the problem you're solving that the DT doesn't match downstream, or
> that card detect doesn't work? Does it work after this patch, or is it
> just aligned with downstream?
>
> Regards,
> Bjorn
Both, it was not matching with downstream and card detect was not
working.
It is working with this patch.
>
>>
>> Fixes: 38d779c26395 ("arm64: dts: qcom: msm8953: Add device tree for
>> Xiaomi Mi A2 Lite")
>> Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
>> ---
>> arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
>> b/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
>> index
>> 336b916729e4721b5ba8f4f7e368d0d838aa54ab..ddd7af616794290aa1f06228a95cfa1d42b006e6
>> 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
>> +++ b/arch/arm64/boot/dts/qcom/msm8953-xiaomi-daisy.dts
>> @@ -296,7 +296,7 @@ &sdhc_2 {
>> vmmc-supply = <&pm8953_l11>;
>> vqmmc-supply = <&pm8953_l12>;
>>
>> - cd-gpios = <&tlmm 133 GPIO_ACTIVE_LOW>;
>> + cd-gpios = <&tlmm 133 GPIO_ACTIVE_HIGH>;
>>
>> pinctrl-names = "default", "sleep";
>> pinctrl-0 = <&sdc2_clk_on &sdc2_cmd_on &sdc2_data_on &sdc2_cd_on>;
>>
>> ---
>> base-commit: 3cace99d63192a7250461b058279a42d91075d0c
>> change-id: 20250830-daisy-sd-fix-011c23468e2a
>>
>> Best regards,
>> --
>> Barnabás Czémán <barnabas.czeman@mainlining.org>
>>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: msm8953-xiaomi-daisy: fix cd-gpios
2025-09-01 18:32 ` barnabas.czeman
@ 2025-09-02 10:20 ` Konrad Dybcio
0 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2025-09-02 10:20 UTC (permalink / raw)
To: barnabas.czeman, Bjorn Andersson
Cc: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Alejandro Tafalla, Luca Weiss, linux-arm-msm, devicetree,
linux-kernel
On 9/1/25 8:32 PM, barnabas.czeman@mainlining.org wrote:
> On 2025-09-01 18:01, Bjorn Andersson wrote:
>> On Sat, Aug 30, 2025 at 11:59:30PM +0200, Barnabás Czémán wrote:
>>> Correct cd-gpios in xiaomi-daisy according to downstream sources
>>> it is using GPIO_ACTIVE_HIGH instead of GPIO_ACTIVE_LOW.
>>
>> Is the problem you're solving that the DT doesn't match downstream, or
>> that card detect doesn't work? Does it work after this patch, or is it
>> just aligned with downstream?
>>
>> Regards,
>> Bjorn
>
> Both, it was not matching with downstream and card detect was not working.
> It is working with this patch.
"things now work" is a more convincing argument than "copy downstream" when
constructing a commit message, the latter can usually make sense as a
sidenote
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-09-02 10:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-30 21:59 [PATCH] arm64: dts: qcom: msm8953-xiaomi-daisy: fix cd-gpios Barnabás Czémán
2025-09-01 16:01 ` Bjorn Andersson
2025-09-01 18:32 ` barnabas.czeman
2025-09-02 10:20 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).