From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 100C73E0259 for ; Tue, 24 Mar 2026 06:47:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774334869; cv=none; b=mGNjgO+/wDE9SnZyBc1lEjL3XZ23DPHApEzINTTN3jHH0NYtLwc31kkz0eeGAm2Jz05KoOPzk0cv89ybpIf5nCXUtIB2XbEqRJRVgHpOT7qMAGKFGrx7/EN3UzJ1TRFawCn54JAiPFCxDcp5D++xNDkXR5T5nQY6u71aI4rr8/U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774334869; c=relaxed/simple; bh=bA/v4mtdOZsgGKThdGEBYWXNK79+l1gi7ofdI9ScFvI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UocgCp4gSL4Ut+jzbvMLMlsOvnfpChxcjvENb2hBZ50Oe/2kbYbIyRDS/js1BSnts+osiTcPPGZVzoBQGr47ne4nrn471yeIbIDPxeigesqOPGaEl6R20LocIKUjByyNRr8+fa0WfzQM6AVTRoQYPCHFHTHlM7PrbZcz8kXYRF4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IAxWK/6g; arc=none smtp.client-ip=209.85.167.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IAxWK/6g" Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-5a27c021b58so988226e87.2 for ; Mon, 23 Mar 2026 23:47:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774334863; x=1774939663; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=s8UwCQsySqx+q1odYBwQx8b0Up7yqPq7GDlTrQkEIPE=; b=IAxWK/6gqogA7NQ3yUeEtLkcOLlX+QipcD5rEi1f+ZFxEU9oks6sdYC7D9HmmVXa3V DmVKjKqoNhaEAoiR5voKr0VYGvsVhu7aReKa+RHyoQp3MyMnB+pjd2W26gMVfg//o/lF UJkoWbC/+gfV7rz48S36OpB+GmRvZgQvn86r/NrHZJutgvMAWF9EbLiMhxRLiRwlnEit n2i1BTNVS0yAj9CuTxk//rwvLnj0suvllnAy6Vgf01++/lgMRgTwFEFv8a5CaL7DAYEF AoY6zIIGcIsJpq04rfEGJtk2ukWqXG1XilIuAFU5JwdJfmIIMrPS90VvXi11pgNXatUM XcIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774334863; x=1774939663; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=s8UwCQsySqx+q1odYBwQx8b0Up7yqPq7GDlTrQkEIPE=; b=pXCpPHC2hTcsV6igT5xW5h1tDe0kMKorjqWqoy0aZUYMMi0LWsp/fXEjqg6nvVwJ0/ aPmt4OEuMj7r0QUJdsKL5OBVTzI+YjmqaRMT4vT5ttQEKWUfl8zVRBc2Ub0P9A3LG1QV PWRK+et0W1mFwYM6dEE92L9JlPRpb4IoigKKXX4Bext0HsITo+LYw3xanXAXz/Vyvuiq Q0oiuAz4upkS8RAiOlAQwxMHpSuNpKpi0hkEFelWbKj3mt5JU13X4wqN9YPgb2F+16mU g9ap5kh50mCIAiPSTkEcUS2ssLNdIWy2eHKRR6lccJE08WAyJ/smy/NzdO2rkLzZXgIy O1/w== X-Gm-Message-State: AOJu0YyvE09zex5v8aNW0N33n6JdUua3ib85sdw42FFBmMtTLpNrm3sD GXsRSL9Xack1TiULBe6xW6wemp7I6yu9lw/tkt41kBbpg3Z8lhUDh8hv X-Gm-Gg: ATEYQzytA7/SN/kTKJT4IRN0x964bQA8rzCnCw9EqdTtexfzy301iCFdNIm70gpyq01 dmCVwMz8BVyn30mkZMR/Zpx98RAyqd84EkS8/A32cneUuGmlfrxuWTR/j5qNYF02k6ie7XT5+Qz kCaH1NpS5D5a1SR8w0is/MlkvonIGooTYGLenrHLfAcXQTpG4uHoEGybB2SYTcMZYaYf8IxfPlV ioSM0NjAPgTHKgacE9N5pO1LAp09tcsU2EHCjqUd/qD07YX9DokfJQ3IdyvVJkKnRskMK5gegQB utyEA0n3LhKGr3E+K7VUmM381EcG7II9+jGCu7KrkGZNKVIKwVdfCuHANf38Ff0BjUQ2dSvmqpK en5q0tqYIYkM70LW8b9g9AjTwj3iE4mv0H1iHt0qc25leOy0Of7wkrt7RYGSJ2m1yMXuEmVk17I Ib7tXLXIOUssrCnKAVsPTSXYr4MWx62Vxy9alwDIuC9MuUqkLu8ytuwoJKGOvR9vYb251Y3E92E XULIhV6 X-Received: by 2002:a05:6512:ad4:b0:5a1:38c4:4247 with SMTP id 2adb3069b0e04-5a285ae5251mr5093599e87.1.1774334862340; Mon, 23 Mar 2026 23:47:42 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a288268a0bsm2732817e87.14.2026.03.23.23.47.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2026 23:47:41 -0700 (PDT) Message-ID: Date: Tue, 24 Mar 2026 08:47:41 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] mfd: rohm-bd718x7: Use software nodes for gpio-keys To: Dmitry Torokhov , Lee Jones Cc: linux-kernel@vger.kernel.org References: <20260322-rohm-software-nodes-v2-0-3c7d21336d37@gmail.com> <20260322-rohm-software-nodes-v2-2-3c7d21336d37@gmail.com> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: <20260322-rohm-software-nodes-v2-2-3c7d21336d37@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 23/03/2026 03:37, Dmitry Torokhov wrote: > Refactor the rohm-bd7182x7 MFD driver to use software nodes for > instantiating the gpio-keys child device, replacing the old > platform_data mechanism. > > The power key's properties are now defined using software nodes and > property entries. The IRQ is passed as a resource attached to the > platform device. > > This will allow dropping support for using platform data for configuring > gpio-keys in the future. I think we miss Signed-off-by -line here. Other than that, similar comments as I had for the 1/2. Yours, -- Matti --- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~