From: Luiz Capitulino <luizcap@redhat.com>
To: david@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org
Cc: ryan.roberts@arm.com, akpm@linux-foundation.org,
lorenzo.stoakes@oracle.com
Subject: [RFC 09/10] mm: thp: always enable mTHP support
Date: Thu, 6 Nov 2025 16:28:56 -0500 [thread overview]
Message-ID: <e9a6a123a03a122010cc10708391db901b11c7a7.1762464515.git.luizcap@redhat.com> (raw)
In-Reply-To: <cover.1762464515.git.luizcap@redhat.com>
If PMD-sized pages are not supported on an architecture (ie. the
arch implements arch_has_pmd_leaves() and it returns false) then the
current code disables all THP, including mTHP.
This commit fixes this by allowing mTHP to be always enabled for all
archs. When PMD-sized pages are not supported, its sysfs entry won't be
created and their mapping will be disallowed at page-fault time.
Signed-off-by: Luiz Capitulino <luizcap@redhat.com>
---
mm/huge_memory.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 0f016ea7082d..4117833c53ef 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -115,6 +115,9 @@ unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma,
else
supported_orders = THP_ORDERS_ALL_FILE_DEFAULT;
+ if (!pgtable_has_pmd_leaves())
+ supported_orders &= ~BIT(PMD_ORDER);
+
orders &= supported_orders;
if (!orders)
return 0;
@@ -122,7 +125,7 @@ unsigned long __thp_vma_allowable_orders(struct vm_area_struct *vma,
if (!vma->vm_mm) /* vdso */
return 0;
- if (!pgtable_has_pmd_leaves() || vma_thp_disabled(vma, vm_flags, forced_collapse))
+ if (vma_thp_disabled(vma, vm_flags, forced_collapse))
return 0;
/* khugepaged doesn't collapse DAX vma, but page fault is fine. */
@@ -805,6 +808,9 @@ static int __init hugepage_init_sysfs(struct kobject **hugepage_kobj)
}
orders = THP_ORDERS_ALL_ANON | THP_ORDERS_ALL_FILE_DEFAULT;
+ if (!pgtable_has_pmd_leaves())
+ orders &= ~BIT(PMD_ORDER);
+
order = highest_order(orders);
while (orders) {
thpsize = thpsize_create(order, *hugepage_kobj);
@@ -904,9 +910,6 @@ static int __init hugepage_init(void)
int err;
struct kobject *hugepage_kobj;
- if (!pgtable_has_pmd_leaves())
- return -EINVAL;
-
/*
* hugepages can't be allocated by the buddy allocator
*/
--
2.51.1
next prev parent reply other threads:[~2025-11-06 21:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 21:28 [RFC 00/10] mm: thp: always enable mTHP support Luiz Capitulino
2025-11-06 21:28 ` [RFC 01/10] docs: tmpfs: remove implementation detail reference Luiz Capitulino
2025-11-06 21:28 ` [RFC 02/10] mm: introduce pgtable_has_pmd_leaves() Luiz Capitulino
2025-11-06 21:28 ` [RFC 03/10] drivers: dax: use pgtable_has_pmd_leaves() Luiz Capitulino
2025-11-06 21:28 ` [RFC 04/10] drivers: i915 selftest: " Luiz Capitulino
2025-11-06 21:28 ` [RFC 05/10] drivers: nvdimm: " Luiz Capitulino
2025-11-06 21:28 ` [RFC 06/10] mm: debug_vm_pgtable: " Luiz Capitulino
2025-11-06 21:28 ` [RFC 07/10] treewide: rename has_transparent_hugepage() to arch_has_pmd_leaves() Luiz Capitulino
2025-11-06 21:28 ` [RFC 08/10] mm: replace thp_disabled_by_hw() with pgtable_has_pmd_leaves() Luiz Capitulino
2025-11-06 21:28 ` Luiz Capitulino [this message]
2025-11-06 21:28 ` [RFC 10/10] mm: thp: x86: cleanup PSE feature bit usage Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9a6a123a03a122010cc10708391db901b11c7a7.1762464515.git.luizcap@redhat.com \
--to=luizcap@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=ryan.roberts@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).