From: Martin KaFai Lau <martin.lau@linux.dev>
To: "Daniel Müller" <deso@posteo.net>, "David Vernet" <void@manifault.com>
Cc: bpf@vger.kernel.org, andrii@kernel.org, ast@kernel.org,
daniel@iogearbox.net, haoluo@google.com,
john.fastabend@gmail.com, jolsa@kernel.org, kpsingh@kernel.org,
sdf@google.com, song@kernel.org, yhs@fb.com, kernel-team@fb.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests/bpf: Alphabetize DENYLISTs
Date: Tue, 11 Oct 2022 23:02:24 -0700 [thread overview]
Message-ID: <e9abe604-2d64-f05a-7e54-c1331bc08c62@linux.dev> (raw)
In-Reply-To: <20221011171357.dqecmkyjinxy2m7u@muellerd-fedora-MJ0AC3F3>
On 10/11/22 10:13 AM, Daniel Müller wrote:
> On Tue, Oct 11, 2022 at 11:52:55AM -0500, David Vernet wrote:
>> The DENYLIST and DENYLIST.s390x files are used to specify testcases
>> which should not be run on CI. Currently, testcases are appended to the
>> end of these files as needed. This can make it a pain to resolve merge
>> conflicts. This patch alphabetizes the DENYLIST files to ease this
>> burden.
[ ... ]
> Looks good to me, thanks! Not sure if we should add a comment indicating lexical
> ordering or solely watch out for that through review.
Added the ordering comment and applied. Thanks.
next prev parent reply other threads:[~2022-10-12 6:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 16:52 [PATCH] selftests/bpf: Alphabetize DENYLISTs David Vernet
2022-10-11 17:13 ` Daniel Müller
2022-10-12 6:02 ` Martin KaFai Lau [this message]
2022-10-12 6:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9abe604-2d64-f05a-7e54-c1331bc08c62@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=deso@posteo.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kernel-team@fb.com \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=void@manifault.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox