[PATCH v5 0/3] Add support for OLED panel used on Snapdragon Lenovo T14s Gen6

[PATCH v5 0/3] Add support for OLED panel used on Snapdragon Lenovo T14s Gen6

[Christopher Obbard]

The Snapdragon Lenovo T14s Gen6 can be bought with a number of different
panels. This patch series adds support for the OLED model which has a
Samsung ATNA40YK20 panel.

With this patch series the backlight of the OLED eDP panel does not
illuminate since the brightness is incorrectly read from the eDP panel
as (to be clear this is not a regression). This is fixed in [0].

[0]: https://lore.kernel.org/all/20250330-wip-obbardc-qcom-t14s-oled-panel-brightness-v6-1-84ad1cd1078a@linaro.org/

Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
---
Changes in v5:
- Move edp_hpd_active from T14s DTS into SoC DTSI (Dmitry).
- Link to v4: https://lore.kernel.org/r/20250402-wip-obbardc-qcom-t14s-oled-panel-v4-0-41ba3f3739d0@linaro.org

Changes in v4:
- Rework HPD GPIO into eDP device rather than panel (Johan).
- Drop review tags for HPD GPIO patch.
- Link to v3: https://lore.kernel.org/r/20250327-wip-obbardc-qcom-t14s-oled-panel-v3-0-45d5f2747398@linaro.org

Changes in v3:
- Added review trailers from v2.
- Dropped dt-binding documentation patch (applied by Douglas Anderson into
  drm-misc-next).
- Dropped eDP maximum brightness patch (will be sent in separate
  series).
- Removed duplicate nodes in T14s OLED device tree.
- Reworked WIP comments from commit messages.
- Link to v2: https://lore.kernel.org/r/20250325-wip-obbardc-qcom-t14s-oled-panel-v2-0-e9bc7c9d30cc@linaro.org

Changes in v2:
- Use the existing atna33xc20 driver rather than panel-edp.
- Add eDP panel into OLED devicetree.
- Add patch to read the correct maximum brightness from the eDP panel.
- Link to v1: https://lore.kernel.org/r/20250320-wip-obbardc-qcom-t14s-oled-panel-v1-1-05bc4bdcd82a@linaro.org

---
Christopher Obbard (3):
      arm64: dts: qcom: x1e80100: add epd hpd pinctrl
      arm64: dts: qcom: x1e78100-t14s: add hpd gpio to dp controller
      arm64: dts: qcom: x1e78100-t14s-oled: add edp panel

 arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s-oled.dts | 8 ++++++++
 arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi     | 3 +++
 arch/arm64/boot/dts/qcom/x1e80100.dtsi                          | 5 +++++
 3 files changed, 16 insertions(+)
---
base-commit: b6ae34803e82511009e2b78dc4fd154330ecdc2d
change-id: 20250320-wip-obbardc-qcom-t14s-oled-panel-b74fed21d600

Best regards,
-- 
Christopher Obbard <christopher.obbard@linaro.org>

[PATCH v5 1/3] arm64: dts: qcom: x1e80100: add epd hpd pinctrl

[Christopher Obbard]

Add edp_hpd_active pinctrl to the X1E80100 device tree.

Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e80100.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
index 46b79fce92c90d969e3de48bc88e27915d1592bb..5b1b80c445404fd02e9f6e5dab207610b03ff9c5 100644
--- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
@@ -6389,6 +6389,11 @@ data-pins {
 					bias-pull-up;
 				};
 			};
+
+			edp_hpd_active: edp-hpd-active-state {
+				pins = "gpio119";
+				function = "edp_hot";
+			};
 		};
 
 		stm@10002000 {

-- 
2.49.0

[PATCH v5 2/3] arm64: dts: qcom: x1e78100-t14s: add hpd gpio to dp controller

[Christopher Obbard]

The eDP controller has an HPD GPIO. Describe it in the device tree
for the generic T14s model, as the HPD GPIO is used in both the
OLED and LCD models which inherit this device tree.

Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
index 962fb050c55c4fd33f480a21a8c47a484d0c82b8..bbeb2e6f039957e443f0f6d16dc00fc62b012425 100644
--- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
+++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi
@@ -975,6 +975,9 @@ &mdss_dp3 {
 	compatible = "qcom,x1e80100-dp";
 	/delete-property/ #sound-dai-cells;
 
+	pinctrl-names = "default";
+	pinctrl-0 = <&edp_hpd_active>;
+
 	status = "okay";
 
 	aux-bus {

-- 
2.49.0

[PATCH v5 3/3] arm64: dts: qcom: x1e78100-t14s-oled: add edp panel

[Christopher Obbard]

Add the Samsung ATNA40YK20 eDP panel to the device tree for the
Snapdragon T14s OLED model.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
---
 arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s-oled.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s-oled.dts b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s-oled.dts
index be65fafafa736a0401a5872c40f69cb20cfbbd90..d524afa12d19b2a6f22a24b9bed6b6b40248375f 100644
--- a/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s-oled.dts
+++ b/arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s-oled.dts
@@ -10,3 +10,11 @@ / {
 	compatible = "lenovo,thinkpad-t14s-oled", "lenovo,thinkpad-t14s",
 		     "qcom,x1e78100", "qcom,x1e80100";
 };
+
+&panel {
+	compatible = "samsung,atna40yk20", "samsung,atna33xc20";
+	enable-gpios = <&pmc8380_3_gpios 4 GPIO_ACTIVE_HIGH>;
+
+	pinctrl-0 = <&edp_bl_en>;
+	pinctrl-names = "default";
+};

-- 
2.49.0

Re: [PATCH v5 1/3] arm64: dts: qcom: x1e80100: add epd hpd pinctrl

[Dmitry Baryshkov]

On Wed, Apr 02, 2025 at 03:36:32PM +0100, Christopher Obbard wrote:
> Add edp_hpd_active pinctrl to the X1E80100 device tree.
> 
> Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/x1e80100.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry

Re: [PATCH v5 2/3] arm64: dts: qcom: x1e78100-t14s: add hpd gpio to dp controller

[Dmitry Baryshkov]

On Wed, Apr 02, 2025 at 03:36:33PM +0100, Christopher Obbard wrote:
> The eDP controller has an HPD GPIO. Describe it in the device tree
> for the generic T14s model, as the HPD GPIO is used in both the
> OLED and LCD models which inherit this device tree.
> 
> Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry

Re: [PATCH v5 3/3] arm64: dts: qcom: x1e78100-t14s-oled: add edp panel

[Dmitry Baryshkov]

On Wed, Apr 02, 2025 at 03:36:34PM +0100, Christopher Obbard wrote:
> Add the Samsung ATNA40YK20 eDP panel to the device tree for the
> Snapdragon T14s OLED model.
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s-oled.dts | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

-- 
With best wishes
Dmitry

Re: [PATCH v5 0/3] Add support for OLED panel used on Snapdragon Lenovo T14s Gen6

[Rob Herring (Arm)]

On Wed, 02 Apr 2025 15:36:31 +0100, Christopher Obbard wrote:
> The Snapdragon Lenovo T14s Gen6 can be bought with a number of different
> panels. This patch series adds support for the OLED model which has a
> Samsung ATNA40YK20 panel.
> 
> With this patch series the backlight of the OLED eDP panel does not
> illuminate since the brightness is incorrectly read from the eDP panel
> as (to be clear this is not a regression). This is fixed in [0].
> 
> [0]: https://lore.kernel.org/all/20250330-wip-obbardc-qcom-t14s-oled-panel-brightness-v6-1-84ad1cd1078a@linaro.org/
> 
> Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
> ---
> Changes in v5:
> - Move edp_hpd_active from T14s DTS into SoC DTSI (Dmitry).
> - Link to v4: https://lore.kernel.org/r/20250402-wip-obbardc-qcom-t14s-oled-panel-v4-0-41ba3f3739d0@linaro.org
> 
> Changes in v4:
> - Rework HPD GPIO into eDP device rather than panel (Johan).
> - Drop review tags for HPD GPIO patch.
> - Link to v3: https://lore.kernel.org/r/20250327-wip-obbardc-qcom-t14s-oled-panel-v3-0-45d5f2747398@linaro.org
> 
> Changes in v3:
> - Added review trailers from v2.
> - Dropped dt-binding documentation patch (applied by Douglas Anderson into
>   drm-misc-next).
> - Dropped eDP maximum brightness patch (will be sent in separate
>   series).
> - Removed duplicate nodes in T14s OLED device tree.
> - Reworked WIP comments from commit messages.
> - Link to v2: https://lore.kernel.org/r/20250325-wip-obbardc-qcom-t14s-oled-panel-v2-0-e9bc7c9d30cc@linaro.org
> 
> Changes in v2:
> - Use the existing atna33xc20 driver rather than panel-edp.
> - Add eDP panel into OLED devicetree.
> - Add patch to read the correct maximum brightness from the eDP panel.
> - Link to v1: https://lore.kernel.org/r/20250320-wip-obbardc-qcom-t14s-oled-panel-v1-1-05bc4bdcd82a@linaro.org
> 
> ---
> Christopher Obbard (3):
>       arm64: dts: qcom: x1e80100: add epd hpd pinctrl
>       arm64: dts: qcom: x1e78100-t14s: add hpd gpio to dp controller
>       arm64: dts: qcom: x1e78100-t14s-oled: add edp panel
> 
>  arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s-oled.dts | 8 ++++++++
>  arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtsi     | 3 +++
>  arch/arm64/boot/dts/qcom/x1e80100.dtsi                          | 5 +++++
>  3 files changed, 16 insertions(+)
> ---
> base-commit: b6ae34803e82511009e2b78dc4fd154330ecdc2d
> change-id: 20250320-wip-obbardc-qcom-t14s-oled-panel-b74fed21d600
> 
> Best regards,
> --
> Christopher Obbard <christopher.obbard@linaro.org>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


This patch series was applied (using b4) to base:
 Base: using specified base-commit b6ae34803e82511009e2b78dc4fd154330ecdc2d

If this is not the correct base, please add 'base-commit' tag
(or use b4 which does this automatically)

New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/qcom/' for 20250402-wip-obbardc-qcom-t14s-oled-panel-v5-0-ff33f4d0020f@linaro.org:

arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s-oled.dtb: panel: compatible: 'oneOf' conditional failed, one must be fixed:
	['samsung,atna40yk20', 'samsung,atna33xc20'] is too long
	'samsung,atna33xc20' was expected
	'samsung,atna40yk20' is not one of ['samsung,atna45af01', 'samsung,atna45dc02', 'samsung,atna56ac03']
	from schema $id: http://devicetree.org/schemas/display/panel/samsung,atna33xc20.yaml#
arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s-oled.dtb: /soc@0/display-subsystem@ae00000/displayport-controller@aea0000/aux-bus/panel: failed to match any schema with compatible: ['samsung,atna40yk20', 'samsung,atna33xc20']
arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dtb: pinctrl@f100000: edp-hpd-active-state: 'oneOf' conditional failed, one must be fixed:
	'function', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
	'edp_hot' is not one of ['aon_cci', 'aoss_cti', 'atest_char', 'atest_char0', 'atest_char1', 'atest_char2', 'atest_char3', 'atest_usb', 'audio_ext', 'audio_ref', 'cam_aon', 'cam_mclk', 'cci_async', 'cci_i2c', 'cci_timer0', 'cci_timer1', 'cci_timer2', 'cci_timer3', 'cci_timer4', 'cmu_rng0', 'cmu_rng1', 'cmu_rng2', 'cmu_rng3', 'cri_trng', 'dbg_out', 'ddr_bist', 'ddr_pxi0', 'ddr_pxi1', 'ddr_pxi2', 'ddr_pxi3', 'ddr_pxi4', 'ddr_pxi5', 'ddr_pxi6', 'ddr_pxi7', 'edp0_hot', 'edp0_lcd', 'edp1_hot', 'edp1_lcd', 'eusb0_ac', 'eusb1_ac', 'eusb2_ac', 'eusb3_ac', 'eusb5_ac', 'eusb6_ac', 'gcc_gp1', 'gcc_gp2', 'gcc_gp3', 'gpio', 'i2s0_data0', 'i2s0_data1', 'i2s0_sck', 'i2s0_ws', 'i2s1_data0', 'i2s1_data1', 'i2s1_sck', 'i2s1_ws', 'ibi_i3c', 'jitter_bist', 'mdp_vsync0', 'mdp_vsync1', 'mdp_vsync2', 'mdp_vsync3', 'mdp_vsync4', 'mdp_vsync5', 'mdp_vsync6', 'mdp_vsync7', 'mdp_vsync8', 'pcie3_clk', 'pcie4_clk', 'pcie5_clk', 'pcie6a_clk', 'pcie6b_clk', 'phase_flag', 'pll_bist', 'pll_clk', 'prng_rosc0', 'prng_rosc1', 'prng_rosc2', 'prng_rosc3', 'qdss_cti', 'qdss_gpio', 'qspi00', 'qspi01', 'qspi02', 'qspi03', 'qspi0_clk', 'qspi0_cs0', 'qspi0_cs1', 'qup0_se0', 'qup0_se1', 'qup0_se2', 'qup0_se3', 'qup0_se4', 'qup0_se5', 'qup0_se6', 'qup0_se7', 'qup1_se0', 'qup1_se1', 'qup1_se2', 'qup1_se3', 'qup1_se4', 'qup1_se5', 'qup1_se6', 'qup1_se7', 'qup2_se0', 'qup2_se1', 'qup2_se2', 'qup2_se3', 'qup2_se4', 'qup2_se5', 'qup2_se6', 'qup2_se7', 'sd_write', 'sdc4_clk', 'sdc4_cmd', 'sdc4_data0', 'sdc4_data1', 'sdc4_data2', 'sdc4_data3', 'sys_throttle', 'tb_trig', 'tgu_ch0', 'tgu_ch1', 'tgu_ch2', 'tgu_ch3', 'tgu_ch4', 'tgu_ch5', 'tgu_ch6', 'tgu_ch7', 'tmess_prng0', 'tmess_prng1', 'tmess_prng2', 'tmess_prng3', 'tsense_pwm1', 'tsense_pwm2', 'sense_pwm3', 'tsense_pwm4', 'usb0_dp', 'usb0_phy', 'usb0_sbrx', 'usb0_sbtx', 'usb1_dp', 'usb1_phy', 'usb1_sbrx', 'usb1_sbtx', 'usb2_dp', 'usb2_phy', 'usb2_sbrx', 'usb2_sbtx', 'vsense_trigger']
	from schema $id: http://devicetree.org/schemas/pinctrl/qcom,x1e80100-tlmm.yaml#
arch/arm64/boot/dts/qcom/x1e80100-lenovo-yoga-slim7x.dtb: pinctrl@f100000: edp-hpd-active-state: 'oneOf' conditional failed, one must be fixed:
	'function', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
	'edp_hot' is not one of ['aon_cci', 'aoss_cti', 'atest_char', 'atest_char0', 'atest_char1', 'atest_char2', 'atest_char3', 'atest_usb', 'audio_ext', 'audio_ref', 'cam_aon', 'cam_mclk', 'cci_async', 'cci_i2c', 'cci_timer0', 'cci_timer1', 'cci_timer2', 'cci_timer3', 'cci_timer4', 'cmu_rng0', 'cmu_rng1', 'cmu_rng2', 'cmu_rng3', 'cri_trng', 'dbg_out', 'ddr_bist', 'ddr_pxi0', 'ddr_pxi1', 'ddr_pxi2', 'ddr_pxi3', 'ddr_pxi4', 'ddr_pxi5', 'ddr_pxi6', 'ddr_pxi7', 'edp0_hot', 'edp0_lcd', 'edp1_hot', 'edp1_lcd', 'eusb0_ac', 'eusb1_ac', 'eusb2_ac', 'eusb3_ac', 'eusb5_ac', 'eusb6_ac', 'gcc_gp1', 'gcc_gp2', 'gcc_gp3', 'gpio', 'i2s0_data0', 'i2s0_data1', 'i2s0_sck', 'i2s0_ws', 'i2s1_data0', 'i2s1_data1', 'i2s1_sck', 'i2s1_ws', 'ibi_i3c', 'jitter_bist', 'mdp_vsync0', 'mdp_vsync1', 'mdp_vsync2', 'mdp_vsync3', 'mdp_vsync4', 'mdp_vsync5', 'mdp_vsync6', 'mdp_vsync7', 'mdp_vsync8', 'pcie3_clk', 'pcie4_clk', 'pcie5_clk', 'pcie6a_clk', 'pcie6b_clk', 'phase_flag', 'pll_bist', 'pll_clk', 'prng_rosc0', 'prng_rosc1', 'prng_rosc2', 'prng_rosc3', 'qdss_cti', 'qdss_gpio', 'qspi00', 'qspi01', 'qspi02', 'qspi03', 'qspi0_clk', 'qspi0_cs0', 'qspi0_cs1', 'qup0_se0', 'qup0_se1', 'qup0_se2', 'qup0_se3', 'qup0_se4', 'qup0_se5', 'qup0_se6', 'qup0_se7', 'qup1_se0', 'qup1_se1', 'qup1_se2', 'qup1_se3', 'qup1_se4', 'qup1_se5', 'qup1_se6', 'qup1_se7', 'qup2_se0', 'qup2_se1', 'qup2_se2', 'qup2_se3', 'qup2_se4', 'qup2_se5', 'qup2_se6', 'qup2_se7', 'sd_write', 'sdc4_clk', 'sdc4_cmd', 'sdc4_data0', 'sdc4_data1', 'sdc4_data2', 'sdc4_data3', 'sys_throttle', 'tb_trig', 'tgu_ch0', 'tgu_ch1', 'tgu_ch2', 'tgu_ch3', 'tgu_ch4', 'tgu_ch5', 'tgu_ch6', 'tgu_ch7', 'tmess_prng0', 'tmess_prng1', 'tmess_prng2', 'tmess_prng3', 'tsense_pwm1', 'tsense_pwm2', 'sense_pwm3', 'tsense_pwm4', 'usb0_dp', 'usb0_phy', 'usb0_sbrx', 'usb0_sbtx', 'usb1_dp', 'usb1_phy', 'usb1_sbrx', 'usb1_sbtx', 'usb2_dp', 'usb2_phy', 'usb2_sbrx', 'usb2_sbtx', 'vsense_trigger']
	from schema $id: http://devicetree.org/schemas/pinctrl/qcom,x1e80100-tlmm.yaml#
arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s-oled.dtb: pinctrl@f100000: edp-hpd-active-state: 'oneOf' conditional failed, one must be fixed:
	'function', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
	'edp_hot' is not one of ['aon_cci', 'aoss_cti', 'atest_char', 'atest_char0', 'atest_char1', 'atest_char2', 'atest_char3', 'atest_usb', 'audio_ext', 'audio_ref', 'cam_aon', 'cam_mclk', 'cci_async', 'cci_i2c', 'cci_timer0', 'cci_timer1', 'cci_timer2', 'cci_timer3', 'cci_timer4', 'cmu_rng0', 'cmu_rng1', 'cmu_rng2', 'cmu_rng3', 'cri_trng', 'dbg_out', 'ddr_bist', 'ddr_pxi0', 'ddr_pxi1', 'ddr_pxi2', 'ddr_pxi3', 'ddr_pxi4', 'ddr_pxi5', 'ddr_pxi6', 'ddr_pxi7', 'edp0_hot', 'edp0_lcd', 'edp1_hot', 'edp1_lcd', 'eusb0_ac', 'eusb1_ac', 'eusb2_ac', 'eusb3_ac', 'eusb5_ac', 'eusb6_ac', 'gcc_gp1', 'gcc_gp2', 'gcc_gp3', 'gpio', 'i2s0_data0', 'i2s0_data1', 'i2s0_sck', 'i2s0_ws', 'i2s1_data0', 'i2s1_data1', 'i2s1_sck', 'i2s1_ws', 'ibi_i3c', 'jitter_bist', 'mdp_vsync0', 'mdp_vsync1', 'mdp_vsync2', 'mdp_vsync3', 'mdp_vsync4', 'mdp_vsync5', 'mdp_vsync6', 'mdp_vsync7', 'mdp_vsync8', 'pcie3_clk', 'pcie4_clk', 'pcie5_clk', 'pcie6a_clk', 'pcie6b_clk', 'phase_flag', 'pll_bist', 'pll_clk', 'prng_rosc0', 'prng_rosc1', 'prng_rosc2', 'prng_rosc3', 'qdss_cti', 'qdss_gpio', 'qspi00', 'qspi01', 'qspi02', 'qspi03', 'qspi0_clk', 'qspi0_cs0', 'qspi0_cs1', 'qup0_se0', 'qup0_se1', 'qup0_se2', 'qup0_se3', 'qup0_se4', 'qup0_se5', 'qup0_se6', 'qup0_se7', 'qup1_se0', 'qup1_se1', 'qup1_se2', 'qup1_se3', 'qup1_se4', 'qup1_se5', 'qup1_se6', 'qup1_se7', 'qup2_se0', 'qup2_se1', 'qup2_se2', 'qup2_se3', 'qup2_se4', 'qup2_se5', 'qup2_se6', 'qup2_se7', 'sd_write', 'sdc4_clk', 'sdc4_cmd', 'sdc4_data0', 'sdc4_data1', 'sdc4_data2', 'sdc4_data3', 'sys_throttle', 'tb_trig', 'tgu_ch0', 'tgu_ch1', 'tgu_ch2', 'tgu_ch3', 'tgu_ch4', 'tgu_ch5', 'tgu_ch6', 'tgu_ch7', 'tmess_prng0', 'tmess_prng1', 'tmess_prng2', 'tmess_prng3', 'tsense_pwm1', 'tsense_pwm2', 'sense_pwm3', 'tsense_pwm4', 'usb0_dp', 'usb0_phy', 'usb0_sbrx', 'usb0_sbtx', 'usb1_dp', 'usb1_phy', 'usb1_sbrx', 'usb1_sbtx', 'usb2_dp', 'usb2_phy', 'usb2_sbrx', 'usb2_sbtx', 'vsense_trigger']
	from schema $id: http://devicetree.org/schemas/pinctrl/qcom,x1e80100-tlmm.yaml#
arch/arm64/boot/dts/qcom/x1p42100-crd.dtb: pinctrl@f100000: edp-hpd-active-state: 'oneOf' conditional failed, one must be fixed:
	'function', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
	'edp_hot' is not one of ['aon_cci', 'aoss_cti', 'atest_char', 'atest_char0', 'atest_char1', 'atest_char2', 'atest_char3', 'atest_usb', 'audio_ext', 'audio_ref', 'cam_aon', 'cam_mclk', 'cci_async', 'cci_i2c', 'cci_timer0', 'cci_timer1', 'cci_timer2', 'cci_timer3', 'cci_timer4', 'cmu_rng0', 'cmu_rng1', 'cmu_rng2', 'cmu_rng3', 'cri_trng', 'dbg_out', 'ddr_bist', 'ddr_pxi0', 'ddr_pxi1', 'ddr_pxi2', 'ddr_pxi3', 'ddr_pxi4', 'ddr_pxi5', 'ddr_pxi6', 'ddr_pxi7', 'edp0_hot', 'edp0_lcd', 'edp1_hot', 'edp1_lcd', 'eusb0_ac', 'eusb1_ac', 'eusb2_ac', 'eusb3_ac', 'eusb5_ac', 'eusb6_ac', 'gcc_gp1', 'gcc_gp2', 'gcc_gp3', 'gpio', 'i2s0_data0', 'i2s0_data1', 'i2s0_sck', 'i2s0_ws', 'i2s1_data0', 'i2s1_data1', 'i2s1_sck', 'i2s1_ws', 'ibi_i3c', 'jitter_bist', 'mdp_vsync0', 'mdp_vsync1', 'mdp_vsync2', 'mdp_vsync3', 'mdp_vsync4', 'mdp_vsync5', 'mdp_vsync6', 'mdp_vsync7', 'mdp_vsync8', 'pcie3_clk', 'pcie4_clk', 'pcie5_clk', 'pcie6a_clk', 'pcie6b_clk', 'phase_flag', 'pll_bist', 'pll_clk', 'prng_rosc0', 'prng_rosc1', 'prng_rosc2', 'prng_rosc3', 'qdss_cti', 'qdss_gpio', 'qspi00', 'qspi01', 'qspi02', 'qspi03', 'qspi0_clk', 'qspi0_cs0', 'qspi0_cs1', 'qup0_se0', 'qup0_se1', 'qup0_se2', 'qup0_se3', 'qup0_se4', 'qup0_se5', 'qup0_se6', 'qup0_se7', 'qup1_se0', 'qup1_se1', 'qup1_se2', 'qup1_se3', 'qup1_se4', 'qup1_se5', 'qup1_se6', 'qup1_se7', 'qup2_se0', 'qup2_se1', 'qup2_se2', 'qup2_se3', 'qup2_se4', 'qup2_se5', 'qup2_se6', 'qup2_se7', 'sd_write', 'sdc4_clk', 'sdc4_cmd', 'sdc4_data0', 'sdc4_data1', 'sdc4_data2', 'sdc4_data3', 'sys_throttle', 'tb_trig', 'tgu_ch0', 'tgu_ch1', 'tgu_ch2', 'tgu_ch3', 'tgu_ch4', 'tgu_ch5', 'tgu_ch6', 'tgu_ch7', 'tmess_prng0', 'tmess_prng1', 'tmess_prng2', 'tmess_prng3', 'tsense_pwm1', 'tsense_pwm2', 'sense_pwm3', 'tsense_pwm4', 'usb0_dp', 'usb0_phy', 'usb0_sbrx', 'usb0_sbtx', 'usb1_dp', 'usb1_phy', 'usb1_sbrx', 'usb1_sbtx', 'usb2_dp', 'usb2_phy', 'usb2_sbrx', 'usb2_sbtx', 'vsense_trigger']
	from schema $id: http://devicetree.org/schemas/pinctrl/qcom,x1e80100-tlmm.yaml#
arch/arm64/boot/dts/qcom/x1e001de-devkit.dtb: pinctrl@f100000: edp-hpd-active-state: 'oneOf' conditional failed, one must be fixed:
	'function', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
	'edp_hot' is not one of ['aon_cci', 'aoss_cti', 'atest_char', 'atest_char0', 'atest_char1', 'atest_char2', 'atest_char3', 'atest_usb', 'audio_ext', 'audio_ref', 'cam_aon', 'cam_mclk', 'cci_async', 'cci_i2c', 'cci_timer0', 'cci_timer1', 'cci_timer2', 'cci_timer3', 'cci_timer4', 'cmu_rng0', 'cmu_rng1', 'cmu_rng2', 'cmu_rng3', 'cri_trng', 'dbg_out', 'ddr_bist', 'ddr_pxi0', 'ddr_pxi1', 'ddr_pxi2', 'ddr_pxi3', 'ddr_pxi4', 'ddr_pxi5', 'ddr_pxi6', 'ddr_pxi7', 'edp0_hot', 'edp0_lcd', 'edp1_hot', 'edp1_lcd', 'eusb0_ac', 'eusb1_ac', 'eusb2_ac', 'eusb3_ac', 'eusb5_ac', 'eusb6_ac', 'gcc_gp1', 'gcc_gp2', 'gcc_gp3', 'gpio', 'i2s0_data0', 'i2s0_data1', 'i2s0_sck', 'i2s0_ws', 'i2s1_data0', 'i2s1_data1', 'i2s1_sck', 'i2s1_ws', 'ibi_i3c', 'jitter_bist', 'mdp_vsync0', 'mdp_vsync1', 'mdp_vsync2', 'mdp_vsync3', 'mdp_vsync4', 'mdp_vsync5', 'mdp_vsync6', 'mdp_vsync7', 'mdp_vsync8', 'pcie3_clk', 'pcie4_clk', 'pcie5_clk', 'pcie6a_clk', 'pcie6b_clk', 'phase_flag', 'pll_bist', 'pll_clk', 'prng_rosc0', 'prng_rosc1', 'prng_rosc2', 'prng_rosc3', 'qdss_cti', 'qdss_gpio', 'qspi00', 'qspi01', 'qspi02', 'qspi03', 'qspi0_clk', 'qspi0_cs0', 'qspi0_cs1', 'qup0_se0', 'qup0_se1', 'qup0_se2', 'qup0_se3', 'qup0_se4', 'qup0_se5', 'qup0_se6', 'qup0_se7', 'qup1_se0', 'qup1_se1', 'qup1_se2', 'qup1_se3', 'qup1_se4', 'qup1_se5', 'qup1_se6', 'qup1_se7', 'qup2_se0', 'qup2_se1', 'qup2_se2', 'qup2_se3', 'qup2_se4', 'qup2_se5', 'qup2_se6', 'qup2_se7', 'sd_write', 'sdc4_clk', 'sdc4_cmd', 'sdc4_data0', 'sdc4_data1', 'sdc4_data2', 'sdc4_data3', 'sys_throttle', 'tb_trig', 'tgu_ch0', 'tgu_ch1', 'tgu_ch2', 'tgu_ch3', 'tgu_ch4', 'tgu_ch5', 'tgu_ch6', 'tgu_ch7', 'tmess_prng0', 'tmess_prng1', 'tmess_prng2', 'tmess_prng3', 'tsense_pwm1', 'tsense_pwm2', 'sense_pwm3', 'tsense_pwm4', 'usb0_dp', 'usb0_phy', 'usb0_sbrx', 'usb0_sbtx', 'usb1_dp', 'usb1_phy', 'usb1_sbrx', 'usb1_sbtx', 'usb2_dp', 'usb2_phy', 'usb2_sbrx', 'usb2_sbtx', 'vsense_trigger']
	from schema $id: http://devicetree.org/schemas/pinctrl/qcom,x1e80100-tlmm.yaml#
arch/arm64/boot/dts/qcom/x1e80100-hp-omnibook-x14.dtb: pinctrl@f100000: edp-hpd-active-state: 'oneOf' conditional failed, one must be fixed:
	'function', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
	'edp_hot' is not one of ['aon_cci', 'aoss_cti', 'atest_char', 'atest_char0', 'atest_char1', 'atest_char2', 'atest_char3', 'atest_usb', 'audio_ext', 'audio_ref', 'cam_aon', 'cam_mclk', 'cci_async', 'cci_i2c', 'cci_timer0', 'cci_timer1', 'cci_timer2', 'cci_timer3', 'cci_timer4', 'cmu_rng0', 'cmu_rng1', 'cmu_rng2', 'cmu_rng3', 'cri_trng', 'dbg_out', 'ddr_bist', 'ddr_pxi0', 'ddr_pxi1', 'ddr_pxi2', 'ddr_pxi3', 'ddr_pxi4', 'ddr_pxi5', 'ddr_pxi6', 'ddr_pxi7', 'edp0_hot', 'edp0_lcd', 'edp1_hot', 'edp1_lcd', 'eusb0_ac', 'eusb1_ac', 'eusb2_ac', 'eusb3_ac', 'eusb5_ac', 'eusb6_ac', 'gcc_gp1', 'gcc_gp2', 'gcc_gp3', 'gpio', 'i2s0_data0', 'i2s0_data1', 'i2s0_sck', 'i2s0_ws', 'i2s1_data0', 'i2s1_data1', 'i2s1_sck', 'i2s1_ws', 'ibi_i3c', 'jitter_bist', 'mdp_vsync0', 'mdp_vsync1', 'mdp_vsync2', 'mdp_vsync3', 'mdp_vsync4', 'mdp_vsync5', 'mdp_vsync6', 'mdp_vsync7', 'mdp_vsync8', 'pcie3_clk', 'pcie4_clk', 'pcie5_clk', 'pcie6a_clk', 'pcie6b_clk', 'phase_flag', 'pll_bist', 'pll_clk', 'prng_rosc0', 'prng_rosc1', 'prng_rosc2', 'prng_rosc3', 'qdss_cti', 'qdss_gpio', 'qspi00', 'qspi01', 'qspi02', 'qspi03', 'qspi0_clk', 'qspi0_cs0', 'qspi0_cs1', 'qup0_se0', 'qup0_se1', 'qup0_se2', 'qup0_se3', 'qup0_se4', 'qup0_se5', 'qup0_se6', 'qup0_se7', 'qup1_se0', 'qup1_se1', 'qup1_se2', 'qup1_se3', 'qup1_se4', 'qup1_se5', 'qup1_se6', 'qup1_se7', 'qup2_se0', 'qup2_se1', 'qup2_se2', 'qup2_se3', 'qup2_se4', 'qup2_se5', 'qup2_se6', 'qup2_se7', 'sd_write', 'sdc4_clk', 'sdc4_cmd', 'sdc4_data0', 'sdc4_data1', 'sdc4_data2', 'sdc4_data3', 'sys_throttle', 'tb_trig', 'tgu_ch0', 'tgu_ch1', 'tgu_ch2', 'tgu_ch3', 'tgu_ch4', 'tgu_ch5', 'tgu_ch6', 'tgu_ch7', 'tmess_prng0', 'tmess_prng1', 'tmess_prng2', 'tmess_prng3', 'tsense_pwm1', 'tsense_pwm2', 'sense_pwm3', 'tsense_pwm4', 'usb0_dp', 'usb0_phy', 'usb0_sbrx', 'usb0_sbtx', 'usb1_dp', 'usb1_phy', 'usb1_sbrx', 'usb1_sbtx', 'usb2_dp', 'usb2_phy', 'usb2_sbrx', 'usb2_sbtx', 'vsense_trigger']
	from schema $id: http://devicetree.org/schemas/pinctrl/qcom,x1e80100-tlmm.yaml#
arch/arm64/boot/dts/qcom/x1e80100-asus-vivobook-s15.dtb: pinctrl@f100000: edp-hpd-active-state: 'oneOf' conditional failed, one must be fixed:
	'function', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
	'edp_hot' is not one of ['aon_cci', 'aoss_cti', 'atest_char', 'atest_char0', 'atest_char1', 'atest_char2', 'atest_char3', 'atest_usb', 'audio_ext', 'audio_ref', 'cam_aon', 'cam_mclk', 'cci_async', 'cci_i2c', 'cci_timer0', 'cci_timer1', 'cci_timer2', 'cci_timer3', 'cci_timer4', 'cmu_rng0', 'cmu_rng1', 'cmu_rng2', 'cmu_rng3', 'cri_trng', 'dbg_out', 'ddr_bist', 'ddr_pxi0', 'ddr_pxi1', 'ddr_pxi2', 'ddr_pxi3', 'ddr_pxi4', 'ddr_pxi5', 'ddr_pxi6', 'ddr_pxi7', 'edp0_hot', 'edp0_lcd', 'edp1_hot', 'edp1_lcd', 'eusb0_ac', 'eusb1_ac', 'eusb2_ac', 'eusb3_ac', 'eusb5_ac', 'eusb6_ac', 'gcc_gp1', 'gcc_gp2', 'gcc_gp3', 'gpio', 'i2s0_data0', 'i2s0_data1', 'i2s0_sck', 'i2s0_ws', 'i2s1_data0', 'i2s1_data1', 'i2s1_sck', 'i2s1_ws', 'ibi_i3c', 'jitter_bist', 'mdp_vsync0', 'mdp_vsync1', 'mdp_vsync2', 'mdp_vsync3', 'mdp_vsync4', 'mdp_vsync5', 'mdp_vsync6', 'mdp_vsync7', 'mdp_vsync8', 'pcie3_clk', 'pcie4_clk', 'pcie5_clk', 'pcie6a_clk', 'pcie6b_clk', 'phase_flag', 'pll_bist', 'pll_clk', 'prng_rosc0', 'prng_rosc1', 'prng_rosc2', 'prng_rosc3', 'qdss_cti', 'qdss_gpio', 'qspi00', 'qspi01', 'qspi02', 'qspi03', 'qspi0_clk', 'qspi0_cs0', 'qspi0_cs1', 'qup0_se0', 'qup0_se1', 'qup0_se2', 'qup0_se3', 'qup0_se4', 'qup0_se5', 'qup0_se6', 'qup0_se7', 'qup1_se0', 'qup1_se1', 'qup1_se2', 'qup1_se3', 'qup1_se4', 'qup1_se5', 'qup1_se6', 'qup1_se7', 'qup2_se0', 'qup2_se1', 'qup2_se2', 'qup2_se3', 'qup2_se4', 'qup2_se5', 'qup2_se6', 'qup2_se7', 'sd_write', 'sdc4_clk', 'sdc4_cmd', 'sdc4_data0', 'sdc4_data1', 'sdc4_data2', 'sdc4_data3', 'sys_throttle', 'tb_trig', 'tgu_ch0', 'tgu_ch1', 'tgu_ch2', 'tgu_ch3', 'tgu_ch4', 'tgu_ch5', 'tgu_ch6', 'tgu_ch7', 'tmess_prng0', 'tmess_prng1', 'tmess_prng2', 'tmess_prng3', 'tsense_pwm1', 'tsense_pwm2', 'sense_pwm3', 'tsense_pwm4', 'usb0_dp', 'usb0_phy', 'usb0_sbrx', 'usb0_sbtx', 'usb1_dp', 'usb1_phy', 'usb1_sbrx', 'usb1_sbtx', 'usb2_dp', 'usb2_phy', 'usb2_sbrx', 'usb2_sbtx', 'vsense_trigger']
	from schema $id: http://devicetree.org/schemas/pinctrl/qcom,x1e80100-tlmm.yaml#
arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus15.dtb: pinctrl@f100000: edp-hpd-active-state: 'oneOf' conditional failed, one must be fixed:
	'function', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
	'edp_hot' is not one of ['aon_cci', 'aoss_cti', 'atest_char', 'atest_char0', 'atest_char1', 'atest_char2', 'atest_char3', 'atest_usb', 'audio_ext', 'audio_ref', 'cam_aon', 'cam_mclk', 'cci_async', 'cci_i2c', 'cci_timer0', 'cci_timer1', 'cci_timer2', 'cci_timer3', 'cci_timer4', 'cmu_rng0', 'cmu_rng1', 'cmu_rng2', 'cmu_rng3', 'cri_trng', 'dbg_out', 'ddr_bist', 'ddr_pxi0', 'ddr_pxi1', 'ddr_pxi2', 'ddr_pxi3', 'ddr_pxi4', 'ddr_pxi5', 'ddr_pxi6', 'ddr_pxi7', 'edp0_hot', 'edp0_lcd', 'edp1_hot', 'edp1_lcd', 'eusb0_ac', 'eusb1_ac', 'eusb2_ac', 'eusb3_ac', 'eusb5_ac', 'eusb6_ac', 'gcc_gp1', 'gcc_gp2', 'gcc_gp3', 'gpio', 'i2s0_data0', 'i2s0_data1', 'i2s0_sck', 'i2s0_ws', 'i2s1_data0', 'i2s1_data1', 'i2s1_sck', 'i2s1_ws', 'ibi_i3c', 'jitter_bist', 'mdp_vsync0', 'mdp_vsync1', 'mdp_vsync2', 'mdp_vsync3', 'mdp_vsync4', 'mdp_vsync5', 'mdp_vsync6', 'mdp_vsync7', 'mdp_vsync8', 'pcie3_clk', 'pcie4_clk', 'pcie5_clk', 'pcie6a_clk', 'pcie6b_clk', 'phase_flag', 'pll_bist', 'pll_clk', 'prng_rosc0', 'prng_rosc1', 'prng_rosc2', 'prng_rosc3', 'qdss_cti', 'qdss_gpio', 'qspi00', 'qspi01', 'qspi02', 'qspi03', 'qspi0_clk', 'qspi0_cs0', 'qspi0_cs1', 'qup0_se0', 'qup0_se1', 'qup0_se2', 'qup0_se3', 'qup0_se4', 'qup0_se5', 'qup0_se6', 'qup0_se7', 'qup1_se0', 'qup1_se1', 'qup1_se2', 'qup1_se3', 'qup1_se4', 'qup1_se5', 'qup1_se6', 'qup1_se7', 'qup2_se0', 'qup2_se1', 'qup2_se2', 'qup2_se3', 'qup2_se4', 'qup2_se5', 'qup2_se6', 'qup2_se7', 'sd_write', 'sdc4_clk', 'sdc4_cmd', 'sdc4_data0', 'sdc4_data1', 'sdc4_data2', 'sdc4_data3', 'sys_throttle', 'tb_trig', 'tgu_ch0', 'tgu_ch1', 'tgu_ch2', 'tgu_ch3', 'tgu_ch4', 'tgu_ch5', 'tgu_ch6', 'tgu_ch7', 'tmess_prng0', 'tmess_prng1', 'tmess_prng2', 'tmess_prng3', 'tsense_pwm1', 'tsense_pwm2', 'sense_pwm3', 'tsense_pwm4', 'usb0_dp', 'usb0_phy', 'usb0_sbrx', 'usb0_sbtx', 'usb1_dp', 'usb1_phy', 'usb1_sbrx', 'usb1_sbtx', 'usb2_dp', 'usb2_phy', 'usb2_sbrx', 'usb2_sbtx', 'vsense_trigger']
	from schema $id: http://devicetree.org/schemas/pinctrl/qcom,x1e80100-tlmm.yaml#
arch/arm64/boot/dts/qcom/x1e80100-qcp.dtb: pinctrl@f100000: edp-hpd-active-state: 'oneOf' conditional failed, one must be fixed:
	'function', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
	'edp_hot' is not one of ['aon_cci', 'aoss_cti', 'atest_char', 'atest_char0', 'atest_char1', 'atest_char2', 'atest_char3', 'atest_usb', 'audio_ext', 'audio_ref', 'cam_aon', 'cam_mclk', 'cci_async', 'cci_i2c', 'cci_timer0', 'cci_timer1', 'cci_timer2', 'cci_timer3', 'cci_timer4', 'cmu_rng0', 'cmu_rng1', 'cmu_rng2', 'cmu_rng3', 'cri_trng', 'dbg_out', 'ddr_bist', 'ddr_pxi0', 'ddr_pxi1', 'ddr_pxi2', 'ddr_pxi3', 'ddr_pxi4', 'ddr_pxi5', 'ddr_pxi6', 'ddr_pxi7', 'edp0_hot', 'edp0_lcd', 'edp1_hot', 'edp1_lcd', 'eusb0_ac', 'eusb1_ac', 'eusb2_ac', 'eusb3_ac', 'eusb5_ac', 'eusb6_ac', 'gcc_gp1', 'gcc_gp2', 'gcc_gp3', 'gpio', 'i2s0_data0', 'i2s0_data1', 'i2s0_sck', 'i2s0_ws', 'i2s1_data0', 'i2s1_data1', 'i2s1_sck', 'i2s1_ws', 'ibi_i3c', 'jitter_bist', 'mdp_vsync0', 'mdp_vsync1', 'mdp_vsync2', 'mdp_vsync3', 'mdp_vsync4', 'mdp_vsync5', 'mdp_vsync6', 'mdp_vsync7', 'mdp_vsync8', 'pcie3_clk', 'pcie4_clk', 'pcie5_clk', 'pcie6a_clk', 'pcie6b_clk', 'phase_flag', 'pll_bist', 'pll_clk', 'prng_rosc0', 'prng_rosc1', 'prng_rosc2', 'prng_rosc3', 'qdss_cti', 'qdss_gpio', 'qspi00', 'qspi01', 'qspi02', 'qspi03', 'qspi0_clk', 'qspi0_cs0', 'qspi0_cs1', 'qup0_se0', 'qup0_se1', 'qup0_se2', 'qup0_se3', 'qup0_se4', 'qup0_se5', 'qup0_se6', 'qup0_se7', 'qup1_se0', 'qup1_se1', 'qup1_se2', 'qup1_se3', 'qup1_se4', 'qup1_se5', 'qup1_se6', 'qup1_se7', 'qup2_se0', 'qup2_se1', 'qup2_se2', 'qup2_se3', 'qup2_se4', 'qup2_se5', 'qup2_se6', 'qup2_se7', 'sd_write', 'sdc4_clk', 'sdc4_cmd', 'sdc4_data0', 'sdc4_data1', 'sdc4_data2', 'sdc4_data3', 'sys_throttle', 'tb_trig', 'tgu_ch0', 'tgu_ch1', 'tgu_ch2', 'tgu_ch3', 'tgu_ch4', 'tgu_ch5', 'tgu_ch6', 'tgu_ch7', 'tmess_prng0', 'tmess_prng1', 'tmess_prng2', 'tmess_prng3', 'tsense_pwm1', 'tsense_pwm2', 'sense_pwm3', 'tsense_pwm4', 'usb0_dp', 'usb0_phy', 'usb0_sbrx', 'usb0_sbtx', 'usb1_dp', 'usb1_phy', 'usb1_sbrx', 'usb1_sbtx', 'usb2_dp', 'usb2_phy', 'usb2_sbrx', 'usb2_sbtx', 'vsense_trigger']
	from schema $id: http://devicetree.org/schemas/pinctrl/qcom,x1e80100-tlmm.yaml#
arch/arm64/boot/dts/qcom/x1e78100-lenovo-thinkpad-t14s.dtb: pinctrl@f100000: edp-hpd-active-state: 'oneOf' conditional failed, one must be fixed:
	'function', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
	'edp_hot' is not one of ['aon_cci', 'aoss_cti', 'atest_char', 'atest_char0', 'atest_char1', 'atest_char2', 'atest_char3', 'atest_usb', 'audio_ext', 'audio_ref', 'cam_aon', 'cam_mclk', 'cci_async', 'cci_i2c', 'cci_timer0', 'cci_timer1', 'cci_timer2', 'cci_timer3', 'cci_timer4', 'cmu_rng0', 'cmu_rng1', 'cmu_rng2', 'cmu_rng3', 'cri_trng', 'dbg_out', 'ddr_bist', 'ddr_pxi0', 'ddr_pxi1', 'ddr_pxi2', 'ddr_pxi3', 'ddr_pxi4', 'ddr_pxi5', 'ddr_pxi6', 'ddr_pxi7', 'edp0_hot', 'edp0_lcd', 'edp1_hot', 'edp1_lcd', 'eusb0_ac', 'eusb1_ac', 'eusb2_ac', 'eusb3_ac', 'eusb5_ac', 'eusb6_ac', 'gcc_gp1', 'gcc_gp2', 'gcc_gp3', 'gpio', 'i2s0_data0', 'i2s0_data1', 'i2s0_sck', 'i2s0_ws', 'i2s1_data0', 'i2s1_data1', 'i2s1_sck', 'i2s1_ws', 'ibi_i3c', 'jitter_bist', 'mdp_vsync0', 'mdp_vsync1', 'mdp_vsync2', 'mdp_vsync3', 'mdp_vsync4', 'mdp_vsync5', 'mdp_vsync6', 'mdp_vsync7', 'mdp_vsync8', 'pcie3_clk', 'pcie4_clk', 'pcie5_clk', 'pcie6a_clk', 'pcie6b_clk', 'phase_flag', 'pll_bist', 'pll_clk', 'prng_rosc0', 'prng_rosc1', 'prng_rosc2', 'prng_rosc3', 'qdss_cti', 'qdss_gpio', 'qspi00', 'qspi01', 'qspi02', 'qspi03', 'qspi0_clk', 'qspi0_cs0', 'qspi0_cs1', 'qup0_se0', 'qup0_se1', 'qup0_se2', 'qup0_se3', 'qup0_se4', 'qup0_se5', 'qup0_se6', 'qup0_se7', 'qup1_se0', 'qup1_se1', 'qup1_se2', 'qup1_se3', 'qup1_se4', 'qup1_se5', 'qup1_se6', 'qup1_se7', 'qup2_se0', 'qup2_se1', 'qup2_se2', 'qup2_se3', 'qup2_se4', 'qup2_se5', 'qup2_se6', 'qup2_se7', 'sd_write', 'sdc4_clk', 'sdc4_cmd', 'sdc4_data0', 'sdc4_data1', 'sdc4_data2', 'sdc4_data3', 'sys_throttle', 'tb_trig', 'tgu_ch0', 'tgu_ch1', 'tgu_ch2', 'tgu_ch3', 'tgu_ch4', 'tgu_ch5', 'tgu_ch6', 'tgu_ch7', 'tmess_prng0', 'tmess_prng1', 'tmess_prng2', 'tmess_prng3', 'tsense_pwm1', 'tsense_pwm2', 'sense_pwm3', 'tsense_pwm4', 'usb0_dp', 'usb0_phy', 'usb0_sbrx', 'usb0_sbtx', 'usb1_dp', 'usb1_phy', 'usb1_sbrx', 'usb1_sbtx', 'usb2_dp', 'usb2_phy', 'usb2_sbrx', 'usb2_sbtx', 'vsense_trigger']
	from schema $id: http://devicetree.org/schemas/pinctrl/qcom,x1e80100-tlmm.yaml#
arch/arm64/boot/dts/qcom/x1e80100-crd.dtb: pinctrl@f100000: edp-hpd-active-state: 'oneOf' conditional failed, one must be fixed:
	'function', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
	'edp_hot' is not one of ['aon_cci', 'aoss_cti', 'atest_char', 'atest_char0', 'atest_char1', 'atest_char2', 'atest_char3', 'atest_usb', 'audio_ext', 'audio_ref', 'cam_aon', 'cam_mclk', 'cci_async', 'cci_i2c', 'cci_timer0', 'cci_timer1', 'cci_timer2', 'cci_timer3', 'cci_timer4', 'cmu_rng0', 'cmu_rng1', 'cmu_rng2', 'cmu_rng3', 'cri_trng', 'dbg_out', 'ddr_bist', 'ddr_pxi0', 'ddr_pxi1', 'ddr_pxi2', 'ddr_pxi3', 'ddr_pxi4', 'ddr_pxi5', 'ddr_pxi6', 'ddr_pxi7', 'edp0_hot', 'edp0_lcd', 'edp1_hot', 'edp1_lcd', 'eusb0_ac', 'eusb1_ac', 'eusb2_ac', 'eusb3_ac', 'eusb5_ac', 'eusb6_ac', 'gcc_gp1', 'gcc_gp2', 'gcc_gp3', 'gpio', 'i2s0_data0', 'i2s0_data1', 'i2s0_sck', 'i2s0_ws', 'i2s1_data0', 'i2s1_data1', 'i2s1_sck', 'i2s1_ws', 'ibi_i3c', 'jitter_bist', 'mdp_vsync0', 'mdp_vsync1', 'mdp_vsync2', 'mdp_vsync3', 'mdp_vsync4', 'mdp_vsync5', 'mdp_vsync6', 'mdp_vsync7', 'mdp_vsync8', 'pcie3_clk', 'pcie4_clk', 'pcie5_clk', 'pcie6a_clk', 'pcie6b_clk', 'phase_flag', 'pll_bist', 'pll_clk', 'prng_rosc0', 'prng_rosc1', 'prng_rosc2', 'prng_rosc3', 'qdss_cti', 'qdss_gpio', 'qspi00', 'qspi01', 'qspi02', 'qspi03', 'qspi0_clk', 'qspi0_cs0', 'qspi0_cs1', 'qup0_se0', 'qup0_se1', 'qup0_se2', 'qup0_se3', 'qup0_se4', 'qup0_se5', 'qup0_se6', 'qup0_se7', 'qup1_se0', 'qup1_se1', 'qup1_se2', 'qup1_se3', 'qup1_se4', 'qup1_se5', 'qup1_se6', 'qup1_se7', 'qup2_se0', 'qup2_se1', 'qup2_se2', 'qup2_se3', 'qup2_se4', 'qup2_se5', 'qup2_se6', 'qup2_se7', 'sd_write', 'sdc4_clk', 'sdc4_cmd', 'sdc4_data0', 'sdc4_data1', 'sdc4_data2', 'sdc4_data3', 'sys_throttle', 'tb_trig', 'tgu_ch0', 'tgu_ch1', 'tgu_ch2', 'tgu_ch3', 'tgu_ch4', 'tgu_ch5', 'tgu_ch6', 'tgu_ch7', 'tmess_prng0', 'tmess_prng1', 'tmess_prng2', 'tmess_prng3', 'tsense_pwm1', 'tsense_pwm2', 'sense_pwm3', 'tsense_pwm4', 'usb0_dp', 'usb0_phy', 'usb0_sbrx', 'usb0_sbtx', 'usb1_dp', 'usb1_phy', 'usb1_sbrx', 'usb1_sbtx', 'usb2_dp', 'usb2_phy', 'usb2_sbrx', 'usb2_sbtx', 'vsense_trigger']
	from schema $id: http://devicetree.org/schemas/pinctrl/qcom,x1e80100-tlmm.yaml#
arch/arm64/boot/dts/qcom/x1e80100-microsoft-romulus13.dtb: pinctrl@f100000: edp-hpd-active-state: 'oneOf' conditional failed, one must be fixed:
	'function', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+'
	'edp_hot' is not one of ['aon_cci', 'aoss_cti', 'atest_char', 'atest_char0', 'atest_char1', 'atest_char2', 'atest_char3', 'atest_usb', 'audio_ext', 'audio_ref', 'cam_aon', 'cam_mclk', 'cci_async', 'cci_i2c', 'cci_timer0', 'cci_timer1', 'cci_timer2', 'cci_timer3', 'cci_timer4', 'cmu_rng0', 'cmu_rng1', 'cmu_rng2', 'cmu_rng3', 'cri_trng', 'dbg_out', 'ddr_bist', 'ddr_pxi0', 'ddr_pxi1', 'ddr_pxi2', 'ddr_pxi3', 'ddr_pxi4', 'ddr_pxi5', 'ddr_pxi6', 'ddr_pxi7', 'edp0_hot', 'edp0_lcd', 'edp1_hot', 'edp1_lcd', 'eusb0_ac', 'eusb1_ac', 'eusb2_ac', 'eusb3_ac', 'eusb5_ac', 'eusb6_ac', 'gcc_gp1', 'gcc_gp2', 'gcc_gp3', 'gpio', 'i2s0_data0', 'i2s0_data1', 'i2s0_sck', 'i2s0_ws', 'i2s1_data0', 'i2s1_data1', 'i2s1_sck', 'i2s1_ws', 'ibi_i3c', 'jitter_bist', 'mdp_vsync0', 'mdp_vsync1', 'mdp_vsync2', 'mdp_vsync3', 'mdp_vsync4', 'mdp_vsync5', 'mdp_vsync6', 'mdp_vsync7', 'mdp_vsync8', 'pcie3_clk', 'pcie4_clk', 'pcie5_clk', 'pcie6a_clk', 'pcie6b_clk', 'phase_flag', 'pll_bist', 'pll_clk', 'prng_rosc0', 'prng_rosc1', 'prng_rosc2', 'prng_rosc3', 'qdss_cti', 'qdss_gpio', 'qspi00', 'qspi01', 'qspi02', 'qspi03', 'qspi0_clk', 'qspi0_cs0', 'qspi0_cs1', 'qup0_se0', 'qup0_se1', 'qup0_se2', 'qup0_se3', 'qup0_se4', 'qup0_se5', 'qup0_se6', 'qup0_se7', 'qup1_se0', 'qup1_se1', 'qup1_se2', 'qup1_se3', 'qup1_se4', 'qup1_se5', 'qup1_se6', 'qup1_se7', 'qup2_se0', 'qup2_se1', 'qup2_se2', 'qup2_se3', 'qup2_se4', 'qup2_se5', 'qup2_se6', 'qup2_se7', 'sd_write', 'sdc4_clk', 'sdc4_cmd', 'sdc4_data0', 'sdc4_data1', 'sdc4_data2', 'sdc4_data3', 'sys_throttle', 'tb_trig', 'tgu_ch0', 'tgu_ch1', 'tgu_ch2', 'tgu_ch3', 'tgu_ch4', 'tgu_ch5', 'tgu_ch6', 'tgu_ch7', 'tmess_prng0', 'tmess_prng1', 'tmess_prng2', 'tmess_prng3', 'tsense_pwm1', 'tsense_pwm2', 'sense_pwm3', 'tsense_pwm4', 'usb0_dp', 'usb0_phy', 'usb0_sbrx', 'usb0_sbtx', 'usb1_dp', 'usb1_phy', 'usb1_sbrx', 'usb1_sbtx', 'usb2_dp', 'usb2_phy', 'usb2_sbrx', 'usb2_sbtx', 'vsense_trigger']
	from schema $id: http://devicetree.org/schemas/pinctrl/qcom,x1e80100-tlmm.yaml#

Re: [PATCH v5 1/3] arm64: dts: qcom: x1e80100: add epd hpd pinctrl

[Johan Hovold]

On Wed, Apr 02, 2025 at 03:36:32PM +0100, Christopher Obbard wrote:
> Add edp_hpd_active pinctrl to the X1E80100 device tree.

Please squash this one with the patch adding the user.
 
> Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/x1e80100.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> index 46b79fce92c90d969e3de48bc88e27915d1592bb..5b1b80c445404fd02e9f6e5dab207610b03ff9c5 100644
> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> @@ -6389,6 +6389,11 @@ data-pins {
>  					bias-pull-up;
>  				};
>  			};
> +
> +			edp_hpd_active: edp-hpd-active-state {

Please keep the nodes sorted by name.

> +				pins = "gpio119";
> +				function = "edp_hot";

There is no "edp_hot" function on x1e so I wonder how this has been
tested.

As I mentioned in a comment to an earlier revision this pin has been
configured by the firmware as "edp0_hot".

Since there is also an "edp1_hot" pin, this needs to be reflected in the
node name and label.

Pin configurations really do belong in board files, but unfortunately
this was not followed for x1e. You should still include the bias
configuration (somewhere).

> +			};
>  		};
>  
>  		stm@10002000 {

Johan

Re: [PATCH v5 0/3] Add support for OLED panel used on Snapdragon Lenovo T14s Gen6

[Johan Hovold]

Hi Chris,

On Wed, Apr 02, 2025 at 03:36:31PM +0100, Christopher Obbard wrote:
> The Snapdragon Lenovo T14s Gen6 can be bought with a number of different
> panels. This patch series adds support for the OLED model which has a
> Samsung ATNA40YK20 panel.
> 
> With this patch series the backlight of the OLED eDP panel does not
> illuminate since the brightness is incorrectly read from the eDP panel
> as (to be clear this is not a regression). This is fixed in [0].
> 
> [0]: https://lore.kernel.org/all/20250330-wip-obbardc-qcom-t14s-oled-panel-brightness-v6-1-84ad1cd1078a@linaro.org/

It would be good to get OLED support for the T14s merged. Are you
planning on sending another revision of this series?

> Christopher Obbard (3):
>       arm64: dts: qcom: x1e80100: add epd hpd pinctrl
>       arm64: dts: qcom: x1e78100-t14s: add hpd gpio to dp controller

>       arm64: dts: qcom: x1e78100-t14s-oled: add edp panel

Strictly speaking you could have posted this last patch on it's own as
it doesn't depend on adding the hpd pinctrl.

Johan

Re: [PATCH v5 0/3] Add support for OLED panel used on Snapdragon Lenovo T14s Gen6

[Johan Hovold]

Hi Chris (and Neil),

On Tue, May 20, 2025 at 10:30:29AM +0200, Johan Hovold wrote:

> On Wed, Apr 02, 2025 at 03:36:31PM +0100, Christopher Obbard wrote:
> > The Snapdragon Lenovo T14s Gen6 can be bought with a number of different
> > panels. This patch series adds support for the OLED model which has a
> > Samsung ATNA40YK20 panel.
> > 
> > With this patch series the backlight of the OLED eDP panel does not
> > illuminate since the brightness is incorrectly read from the eDP panel
> > as (to be clear this is not a regression). This is fixed in [0].
> > 
> > [0]: https://lore.kernel.org/all/20250330-wip-obbardc-qcom-t14s-oled-panel-brightness-v6-1-84ad1cd1078a@linaro.org/
> 
> It would be good to get OLED support for the T14s merged. Are you
> planning on sending another revision of this series?

No reply for over a month. Do you intend to respin these or should
someone else take over?

Neil, do you have the OLED version now?

> > Christopher Obbard (3):
> >       arm64: dts: qcom: x1e80100: add epd hpd pinctrl
> >       arm64: dts: qcom: x1e78100-t14s: add hpd gpio to dp controller
> 
> >       arm64: dts: qcom: x1e78100-t14s-oled: add edp panel
> 
> Strictly speaking you could have posted this last patch on it's own as
> it doesn't depend on adding the hpd pinctrl.

Johan

Re: [PATCH v5 0/3] Add support for OLED panel used on Snapdragon Lenovo T14s Gen6

[Neil Armstrong]

On 10/07/2025 12:07, Johan Hovold wrote:
> Hi Chris (and Neil),
> 
> On Tue, May 20, 2025 at 10:30:29AM +0200, Johan Hovold wrote:
> 
>> On Wed, Apr 02, 2025 at 03:36:31PM +0100, Christopher Obbard wrote:
>>> The Snapdragon Lenovo T14s Gen6 can be bought with a number of different
>>> panels. This patch series adds support for the OLED model which has a
>>> Samsung ATNA40YK20 panel.
>>>
>>> With this patch series the backlight of the OLED eDP panel does not
>>> illuminate since the brightness is incorrectly read from the eDP panel
>>> as (to be clear this is not a regression). This is fixed in [0].
>>>
>>> [0]: https://lore.kernel.org/all/20250330-wip-obbardc-qcom-t14s-oled-panel-brightness-v6-1-84ad1cd1078a@linaro.org/
>>
>> It would be good to get OLED support for the T14s merged. Are you
>> planning on sending another revision of this series?
> 
> No reply for over a month. Do you intend to respin these or should
> someone else take over?
> 
> Neil, do you have the OLED version now?

I'm not sure, how do I determine that ? Is there something specific in the type number ?

Neil

> 
>>> Christopher Obbard (3):
>>>        arm64: dts: qcom: x1e80100: add epd hpd pinctrl
>>>        arm64: dts: qcom: x1e78100-t14s: add hpd gpio to dp controller
>>
>>>        arm64: dts: qcom: x1e78100-t14s-oled: add edp panel
>>
>> Strictly speaking you could have posted this last patch on it's own as
>> it doesn't depend on adding the hpd pinctrl.
> 
> Johan

Re: [PATCH v5 0/3] Add support for OLED panel used on Snapdragon Lenovo T14s Gen6

[Rui Miguel Silva]

Hey Neil,

On Tue Jul 22, 2025 at 2:01 PM WEST, Neil Armstrong wrote:

> On 10/07/2025 12:07, Johan Hovold wrote:
>> Hi Chris (and Neil),
>> 
>> On Tue, May 20, 2025 at 10:30:29AM +0200, Johan Hovold wrote:
>> 
>>> On Wed, Apr 02, 2025 at 03:36:31PM +0100, Christopher Obbard wrote:
>>>> The Snapdragon Lenovo T14s Gen6 can be bought with a number of different
>>>> panels. This patch series adds support for the OLED model which has a
>>>> Samsung ATNA40YK20 panel.
>>>>
>>>> With this patch series the backlight of the OLED eDP panel does not
>>>> illuminate since the brightness is incorrectly read from the eDP panel
>>>> as (to be clear this is not a regression). This is fixed in [0].
>>>>
>>>> [0]: https://lore.kernel.org/all/20250330-wip-obbardc-qcom-t14s-oled-panel-brightness-v6-1-84ad1cd1078a@linaro.org/
>>>
>>> It would be good to get OLED support for the T14s merged. Are you
>>> planning on sending another revision of this series?
>> 
>> No reply for over a month. Do you intend to respin these or should
>> someone else take over?
>> 
>> Neil, do you have the OLED version now?
>
> I'm not sure, how do I determine that ? Is there something specific in the type number ?

Yes, yours is the OLED version, the exact models stated above.

Cheers,
     Rui

>
> Neil
>
>> 
>>>> Christopher Obbard (3):
>>>>        arm64: dts: qcom: x1e80100: add epd hpd pinctrl
>>>>        arm64: dts: qcom: x1e78100-t14s: add hpd gpio to dp controller
>>>
>>>>        arm64: dts: qcom: x1e78100-t14s-oled: add edp panel
>>>
>>> Strictly speaking you could have posted this last patch on it's own as
>>> it doesn't depend on adding the hpd pinctrl.
>> 
>> Johan

Re: [PATCH v5 0/3] Add support for OLED panel used on Snapdragon Lenovo T14s Gen6

[Neil Armstrong]

On 22/07/2025 15:48, Rui Miguel Silva wrote:
> Hey Neil,
> 
> On Tue Jul 22, 2025 at 2:01 PM WEST, Neil Armstrong wrote:
> 
>> On 10/07/2025 12:07, Johan Hovold wrote:
>>> Hi Chris (and Neil),
>>>
>>> On Tue, May 20, 2025 at 10:30:29AM +0200, Johan Hovold wrote:
>>>
>>>> On Wed, Apr 02, 2025 at 03:36:31PM +0100, Christopher Obbard wrote:
>>>>> The Snapdragon Lenovo T14s Gen6 can be bought with a number of different
>>>>> panels. This patch series adds support for the OLED model which has a
>>>>> Samsung ATNA40YK20 panel.
>>>>>
>>>>> With this patch series the backlight of the OLED eDP panel does not
>>>>> illuminate since the brightness is incorrectly read from the eDP panel
>>>>> as (to be clear this is not a regression). This is fixed in [0].
>>>>>
>>>>> [0]: https://lore.kernel.org/all/20250330-wip-obbardc-qcom-t14s-oled-panel-brightness-v6-1-84ad1cd1078a@linaro.org/
>>>>
>>>> It would be good to get OLED support for the T14s merged. Are you
>>>> planning on sending another revision of this series?
>>>
>>> No reply for over a month. Do you intend to respin these or should
>>> someone else take over?
>>>
>>> Neil, do you have the OLED version now?
>>
>> I'm not sure, how do I determine that ? Is there something specific in the type number ?
> 
> Yes, yours is the OLED version, the exact models stated above.

Ack thx, I'll test and re-spin this patchset then.

Neil

> 
> Cheers,
>       Rui
> 
>>
>> Neil
>>
>>>
>>>>> Christopher Obbard (3):
>>>>>         arm64: dts: qcom: x1e80100: add epd hpd pinctrl
>>>>>         arm64: dts: qcom: x1e78100-t14s: add hpd gpio to dp controller
>>>>
>>>>>         arm64: dts: qcom: x1e78100-t14s-oled: add edp panel
>>>>
>>>> Strictly speaking you could have posted this last patch on it's own as
>>>> it doesn't depend on adding the hpd pinctrl.
>>>
>>> Johan
> 
> 
> 

Re: [PATCH v5 1/3] arm64: dts: qcom: x1e80100: add epd hpd pinctrl

[Neil Armstrong]

On 11/04/2025 13:49, Johan Hovold wrote:
> On Wed, Apr 02, 2025 at 03:36:32PM +0100, Christopher Obbard wrote:
>> Add edp_hpd_active pinctrl to the X1E80100 device tree.
> 
> Please squash this one with the patch adding the user.
>   
>> Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
>> ---
>>   arch/arm64/boot/dts/qcom/x1e80100.dtsi | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
>> index 46b79fce92c90d969e3de48bc88e27915d1592bb..5b1b80c445404fd02e9f6e5dab207610b03ff9c5 100644
>> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
>> @@ -6389,6 +6389,11 @@ data-pins {
>>   					bias-pull-up;
>>   				};
>>   			};
>> +
>> +			edp_hpd_active: edp-hpd-active-state {
> 
> Please keep the nodes sorted by name.
> 
>> +				pins = "gpio119";
>> +				function = "edp_hot";
> 
> There is no "edp_hot" function on x1e so I wonder how this has been
> tested.
> 
> As I mentioned in a comment to an earlier revision this pin has been
> configured by the firmware as "edp0_hot".

With edp_hot, screen stays black with UI comes up, with edp0_hot it works again.

> 
> Since there is also an "edp1_hot" pin, this needs to be reflected in the
> node name and label.
> 
> Pin configurations really do belong in board files, but unfortunately
> this was not followed for x1e. You should still include the bias
> configuration (somewhere).

Which bias ? do this pin config needs an additional bias config ?

Neil

> 
>> +			};
>>   		};
>>   
>>   		stm@10002000 {
> 
> Johan

Re: [PATCH v5 0/3] Add support for OLED panel used on Snapdragon Lenovo T14s Gen6

[Johan Hovold]

On Wed, Jul 23, 2025 at 08:51:22AM +0200, Neil Armstrong wrote:
> On 22/07/2025 15:48, Rui Miguel Silva wrote:
> > On Tue Jul 22, 2025 at 2:01 PM WEST, Neil Armstrong wrote:
> >> On 10/07/2025 12:07, Johan Hovold wrote:

> >>> Neil, do you have the OLED version now?
> >>
> >> I'm not sure, how do I determine that ? Is there something specific in the type number ?
> > 
> > Yes, yours is the OLED version, the exact models stated above.
> 
> Ack thx, I'll test and re-spin this patchset then.

Thanks. Note that this depends on this series as well which also needs a
minor update:

	https://lore.kernel.org/all/20250330-wip-obbardc-qcom-t14s-oled-panel-brightness-v6-1-84ad1cd1078a@linaro.org/

Can you respin that one as well?

Johan

Re: [PATCH v5 1/3] arm64: dts: qcom: x1e80100: add epd hpd pinctrl

[Johan Hovold]

On Wed, Jul 23, 2025 at 09:03:40AM +0200, Neil Armstrong wrote:
> On 11/04/2025 13:49, Johan Hovold wrote:
> > On Wed, Apr 02, 2025 at 03:36:32PM +0100, Christopher Obbard wrote:
> >> Add edp_hpd_active pinctrl to the X1E80100 device tree.
> > 
> > Please squash this one with the patch adding the user.
> >   
> >> Signed-off-by: Christopher Obbard <christopher.obbard@linaro.org>
> >> ---
> >>   arch/arm64/boot/dts/qcom/x1e80100.dtsi | 5 +++++
> >>   1 file changed, 5 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> >> index 46b79fce92c90d969e3de48bc88e27915d1592bb..5b1b80c445404fd02e9f6e5dab207610b03ff9c5 100644
> >> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> >> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi
> >> @@ -6389,6 +6389,11 @@ data-pins {
> >>   					bias-pull-up;
> >>   				};
> >>   			};
> >> +
> >> +			edp_hpd_active: edp-hpd-active-state {
> > 
> > Please keep the nodes sorted by name.
> > 
> >> +				pins = "gpio119";
> >> +				function = "edp_hot";
> > 
> > There is no "edp_hot" function on x1e so I wonder how this has been
> > tested.
> > 
> > As I mentioned in a comment to an earlier revision this pin has been
> > configured by the firmware as "edp0_hot".
> 
> With edp_hot, screen stays black with UI comes up, with edp0_hot it works again.

Right.

> > Since there is also an "edp1_hot" pin, this needs to be reflected in the
> > node name and label.
> > 
> > Pin configurations really do belong in board files, but unfortunately
> > this was not followed for x1e. You should still include the bias
> > configuration (somewhere).
> 
> Which bias ? do this pin config needs an additional bias config ?

The boot firmware has disabled the bias, but we should not rely on the
firmware to have configured the pin for us.

Johan

Re: [PATCH v5 0/3] Add support for OLED panel used on Snapdragon Lenovo T14s Gen6

[Neil Armstrong]

On 23/07/2025 09:27, Johan Hovold wrote:
> On Wed, Jul 23, 2025 at 08:51:22AM +0200, Neil Armstrong wrote:
>> On 22/07/2025 15:48, Rui Miguel Silva wrote:
>>> On Tue Jul 22, 2025 at 2:01 PM WEST, Neil Armstrong wrote:
>>>> On 10/07/2025 12:07, Johan Hovold wrote:
> 
>>>>> Neil, do you have the OLED version now?
>>>>
>>>> I'm not sure, how do I determine that ? Is there something specific in the type number ?
>>>
>>> Yes, yours is the OLED version, the exact models stated above.
>>
>> Ack thx, I'll test and re-spin this patchset then.
> 
> Thanks. Note that this depends on this series as well which also needs a
> minor update:
> 
> 	https://lore.kernel.org/all/20250330-wip-obbardc-qcom-t14s-oled-panel-brightness-v6-1-84ad1cd1078a@linaro.org/
> 
> Can you respin that one as well?

Sure

> 
> Johan

Re: [PATCH v5 0/3] Add support for OLED panel used on Snapdragon Lenovo T14s Gen6

[Christopher Obbard]

Hi Neil, Johan,


On Wed, 23 Jul 2025 at 07:51, Neil Armstrong <neil.armstrong@linaro.org> wrote:
>
> On 22/07/2025 15:48, Rui Miguel Silva wrote:
> > Hey Neil,
> >
> > On Tue Jul 22, 2025 at 2:01 PM WEST, Neil Armstrong wrote:
> >
> >> On 10/07/2025 12:07, Johan Hovold wrote:
> >>> Hi Chris (and Neil),
> >>>
> >>> On Tue, May 20, 2025 at 10:30:29AM +0200, Johan Hovold wrote:
> >>>
> >>>> On Wed, Apr 02, 2025 at 03:36:31PM +0100, Christopher Obbard wrote:
> >>>>> The Snapdragon Lenovo T14s Gen6 can be bought with a number of different
> >>>>> panels. This patch series adds support for the OLED model which has a
> >>>>> Samsung ATNA40YK20 panel.
> >>>>>
> >>>>> With this patch series the backlight of the OLED eDP panel does not
> >>>>> illuminate since the brightness is incorrectly read from the eDP panel
> >>>>> as (to be clear this is not a regression). This is fixed in [0].
> >>>>>
> >>>>> [0]: https://lore.kernel.org/all/20250330-wip-obbardc-qcom-t14s-oled-panel-brightness-v6-1-84ad1cd1078a@linaro.org/
> >>>>
> >>>> It would be good to get OLED support for the T14s merged. Are you
> >>>> planning on sending another revision of this series?
> >>>
> >>> No reply for over a month. Do you intend to respin these or should
> >>> someone else take over?
> >>>
> >>> Neil, do you have the OLED version now?
> >>
> >> I'm not sure, how do I determine that ? Is there something specific in the type number ?
> >
> > Yes, yours is the OLED version, the exact models stated above.
>
> Ack thx, I'll test and re-spin this patchset then.

Sorry for the delay. I've just sent a v5 of this patch. I will look at
the eDP brightness patch next...


> Neil
>
> >
> > Cheers,
> >       Rui
> >
> >>
> >> Neil
> >>
> >>>
> >>>>> Christopher Obbard (3):
> >>>>>         arm64: dts: qcom: x1e80100: add epd hpd pinctrl
> >>>>>         arm64: dts: qcom: x1e78100-t14s: add hpd gpio to dp controller
> >>>>
> >>>>>         arm64: dts: qcom: x1e78100-t14s-oled: add edp panel
> >>>>
> >>>> Strictly speaking you could have posted this last patch on it's own as
> >>>> it doesn't depend on adding the hpd pinctrl.
> >>>
> >>> Johan
> >
> >
> >
>