The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Akira Yokosawa <akiyks@gmail.com>, mchehab+huawei@kernel.org
Cc: corbet@lwn.net, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, Akira Yokosawa <akiyks@gmail.com>
Subject: Re: [PATCH 1/2] docs: kernel-doc: avoid script crash on ancient Python
Date: Tue, 29 Jul 2025 16:19:45 +0300	[thread overview]
Message-ID: <e9cf21e5332616f2fb58a90fe8ba6f91359915b8@intel.com> (raw)
In-Reply-To: <8251d567-5218-4fa1-aed2-f38ec089989d@gmail.com>

On Tue, 29 Jul 2025, Akira Yokosawa <akiyks@gmail.com> wrote:
> Hi,
>
> On Mon, 28 Jul 2025 16:54:28 +0200, Mauro Carvalho Chehab wrote:
>> While we do need at least 3.6 for kernel-doc to work, and at least
>> 3.7 for it to output functions and structs with parameters at the
>> right order, let the python binary be compatible with legacy
>                               code?
>
>> versions.
>> 
> [...]
>> 
>> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
>> ---
>>  scripts/kernel-doc.py | 37 ++++++++++++++++++++++++++-----------
>>  1 file changed, 26 insertions(+), 11 deletions(-)
>> 
>> diff --git a/scripts/kernel-doc.py b/scripts/kernel-doc.py
>> index fc3d46ef519f..d4f9188d6a19 100755
>> --- a/scripts/kernel-doc.py
>> +++ b/scripts/kernel-doc.py
>> @@ -1,9 +1,19 @@
>> -#!/usr/bin/env python3
>> +#!/usr/bin/env python
>
> This would conflict with my existing setup which has
> /usr/bin/python3 only.
>
> Please don't do this!

Agreed, this breaks more than it fixes.

Python 2.7 reached end-of-life over five years ago. Do we really have to
cater for ancient stuff? Which actual real world cases do not have
Python 3+ available? Please just let it go, and see if anyone ever
notices?

BR,
Jani.


-- 
Jani Nikula, Intel

  reply	other threads:[~2025-07-29 13:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-28 14:54 [PATCH 0/2] Better handle and document Python needs for Kernel build Mauro Carvalho Chehab
2025-07-28 14:54 ` [PATCH 1/2] docs: kernel-doc: avoid script crash on ancient Python Mauro Carvalho Chehab
2025-07-29 10:08   ` Akira Yokosawa
2025-07-29 13:19     ` Jani Nikula [this message]
2025-07-29 13:57       ` Jonathan Corbet
2025-07-28 14:54 ` [PATCH 2/2] docs: changes: better document Python needs Mauro Carvalho Chehab
2025-07-29 10:35   ` Akira Yokosawa
2025-07-29 13:37     ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e9cf21e5332616f2fb58a90fe8ba6f91359915b8@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=akiyks@gmail.com \
    --cc=corbet@lwn.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab+huawei@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox