From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A84611E4AE for ; Thu, 8 May 2025 22:52:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746744757; cv=none; b=EIWdEvzT0Zy68DWvONSfCjOflY5HxJ2JIyb6QfRi6WwQ/NsuqlcA8GfRQOsHG5GZMDCFl+CX6aBokAUj4KTFvnnshjuloT8hOfnfq2YDHElWJvI2xSX4d+qRjvaoFhD3ppz0RJmp0iGAyiCb39F9D5iFT2NIlkPq0oqO9+3LDbg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1746744757; c=relaxed/simple; bh=Z0Y846iHN4tsFymQyVnFc+uRd774FOZ+CFSaABkuboo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=G0CBJncP6sGQfEGb2PXX7cGiCdUeAzZV44hG1CRBycmfLMVj0XLBPWt/3HdDtJoREJqq3EQAodrBgbN5ryjI3+MitA3/qMxkqXmFjoPvhTXYNw7IqGBuR4jnrn37nrsi779IvC3pCuDilMogQpgv2S7qE+bxbKv+QotgJk2MSrU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=EKbQ/BkL; arc=none smtp.client-ip=95.215.58.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="EKbQ/BkL" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1746744753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l3eDGiLxYlAt+/pMDts6bkeRPseipyTsamG8BWSmPH8=; b=EKbQ/BkLtro67RmyoXLZUIy72RkL8jlkGAN+UDFxJ1EYZ+117bX1YZg9mMcQENFY45Dozo eUAesbz7L1oprxsUfZDZx7GXX/WHqJb/yhKlV/LSimNrWWxtzGq0HV3V7LZwcYHEbeMguh tLiiSnVn9z/2O0oqaurAkYha+HfvzF0= Date: Thu, 8 May 2025 23:51:50 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH net-next] net: gianfar: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set() To: Vladimir Oltean , netdev@vger.kernel.org Cc: =?UTF-8?Q?K=C3=B6ry_Maincent?= , Claudiu Manoil , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Richard Cochran , linux-kernel@vger.kernel.org References: <20250508143659.1944220-1-vladimir.oltean@nxp.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: <20250508143659.1944220-1-vladimir.oltean@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 08/05/2025 15:36, Vladimir Oltean wrote: > New timestamping API was introduced in commit 66f7223039c0 ("net: add > NDOs for configuring hardware timestamping") from kernel v6.6. It is > time to convert the gianfar driver to the new API, so that the > ndo_eth_ioctl() path can be removed completely. > > Don't propagate the unnecessary "config.flags = 0;" assignment to > gfar_hwtstamp_get(), because dev_get_hwtstamp() provides a zero > initialized struct kernel_hwtstamp_config. > > After removing timestamping logic from gfar_ioctl(), the rest is > equivalent to phy_do_ioctl_running(), so provide that directly as our > ndo_eth_ioctl() implementation. > > Signed-off-by: Vladimir Oltean > Tested-by: Vladimir Oltean # LS1021A Reviewed-by: Vadim Fedorenko