From: Joe Perches <joe@perches.com>
To: Antonio Borneo <borneo.antonio@gmail.com>,
Andy Whitcroft <apw@canonical.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] checkpatch: fix minor typo and mixed space+tab in indentation
Date: Wed, 22 Jan 2020 09:26:58 -0800 [thread overview]
Message-ID: <e9de2dda118caca92e2cf678cccf76fa097cb734.camel@perches.com> (raw)
In-Reply-To: <20200122163852.124417-2-borneo.antonio@gmail.com>
On Wed, 2020-01-22 at 17:38 +0100, Antonio Borneo wrote:
> Fix spelling of "concatenation".
> Don't use tab after space in indentation.
>
> Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
I've no objection to any of these 3 patches.
Andrew, might you pick them up please?
https://lore.kernel.org/patchwork/patch/1183806/
https://lore.kernel.org/patchwork/patch/1183805/
https://lore.kernel.org/patchwork/patch/1183804/
> ---
>
> v1 -> v2
> rebased
>
> ---
> scripts/checkpatch.pl | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 30da08d9646a..4c1be774b0ed 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -4582,7 +4582,7 @@ sub process {
> ($op eq '>' &&
> $ca =~ /<\S+\@\S+$/))
> {
> - $ok = 1;
> + $ok = 1;
> }
>
> # for asm volatile statements
> @@ -4917,7 +4917,7 @@ sub process {
> # conditional.
> substr($s, 0, length($c), '');
> $s =~ s/\n.*//g;
> - $s =~ s/$;//g; # Remove any comments
> + $s =~ s/$;//g; # Remove any comments
> if (length($c) && $s !~ /^\s*{?\s*\\*\s*$/ &&
> $c !~ /}\s*while\s*/)
> {
> @@ -4956,7 +4956,7 @@ sub process {
> # if and else should not have general statements after it
> if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/) {
> my $s = $1;
> - $s =~ s/$;//g; # Remove any comments
> + $s =~ s/$;//g; # Remove any comments
> if ($s !~ /^\s*(?:\sif|(?:{|)\s*\\?\s*$)/) {
> ERROR("TRAILING_STATEMENTS",
> "trailing statements should be on next line\n" . $herecurr);
> @@ -5132,7 +5132,7 @@ sub process {
> {
> }
>
> - # Flatten any obvious string concatentation.
> + # Flatten any obvious string concatenation.
> while ($dstat =~ s/($String)\s*$Ident/$1/ ||
> $dstat =~ s/$Ident\s*($String)/$1/)
> {
next prev parent reply other threads:[~2020-01-22 17:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-08 12:27 [PATCH 1/4] checkpatch: fix multiple const * types Antonio Borneo
2019-05-08 12:27 ` [PATCH 2/4] checkpatch: add --fix for warning LINE_CONTINUATIONS Antonio Borneo
2019-05-08 14:19 ` Joe Perches
2019-05-08 12:27 ` [PATCH 3/4] checkpatch: fix minor typo and mixed space+tab in indentation Antonio Borneo
2020-01-22 16:38 ` [PATCH V2] " Antonio Borneo
2020-01-22 17:26 ` Joe Perches [this message]
2019-05-08 12:27 ` [PATCH 4/4] checkpatch: replace magic value for TAB size Antonio Borneo
2019-05-08 14:52 ` Joe Perches
2019-05-08 15:32 ` Antonio Borneo
2019-05-08 17:02 ` Joe Perches
2020-01-22 16:38 ` [PATCH V6] checkpatch: add command-line option " Antonio Borneo
2019-05-08 14:51 ` [PATCH 1/4] checkpatch: fix multiple const * types Joe Perches
2019-05-08 15:26 ` Antonio Borneo
2019-05-08 17:43 ` [PATCH v2] " Antonio Borneo
2019-09-04 9:37 ` Antonio Borneo
2020-01-22 16:38 ` [PATCH V3] " Antonio Borneo
-- strict thread matches above, loose matches on Subject: below --
2019-05-08 17:43 [PATCH v2] checkpatch: add command-line option for TAB size Antonio Borneo
2019-05-08 17:56 ` Joe Perches
2019-05-08 18:19 ` Antonio Borneo
2019-05-08 18:36 ` [PATCH v3] " Antonio Borneo
2019-05-08 21:14 ` [PATCH v2] " Elliott, Robert (Servers)
2019-05-08 21:59 ` Joe Perches
2019-05-08 22:03 ` Antonio Borneo
2019-05-09 7:21 [PATCH v4] " Antonio Borneo
2019-05-09 8:03 ` Joe Perches
2019-05-09 9:26 ` Antonio Borneo
2019-05-09 9:39 ` [PATCH v5] " Antonio Borneo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9de2dda118caca92e2cf678cccf76fa097cb734.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=borneo.antonio@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox