From: John Hubbard <jhubbard@nvidia.com>
To: Shuah Khan <shuah@kernel.org>
Cc: "Jason A . Donenfeld" <Jason@zx2c4.com>,
Andy Lutomirski <luto@kernel.org>,
Mark Brown <broonie@kernel.org>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Colin Ian King <colin.i.king@gmail.com>,
Valentin Obst <kernel@valentinobst.de>,
<linux-kselftest@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>, <llvm@lists.linux.dev>,
Thomas Gleixner <tglx@linutronix.de>,
Carlos Llamas <cmllamas@google.com>
Subject: Shuah, Andy L: [PATCH v3 0/3] selftests/vDSO: fix clang build errors, and Makefile cleanup
Date: Mon, 17 Jun 2024 13:15:49 -0700 [thread overview]
Message-ID: <e9de90dd-c541-45bf-a364-0e7aaf320314@nvidia.com> (raw)
In-Reply-To: <102e70cd-3979-4ea5-8df4-d3b2ea01003b@nvidia.com>
On 6/14/24 4:34 PM, John Hubbard wrote:
> On 6/14/24 4:31 PM, John Hubbard wrote:
>> Hi,
>>
>> Jason A. Donenfeld, I've added you because I ended up looking through
>> your latest "implement getrandom() in vDSO" series [1], which also
>> touches this Makefile, so just a heads up about upcoming (minor) merge
>> conflicts.
>
> Belatedly adding Carlos Llamas and Thomas Gleixner to Cc.
Hi Shuah, Andy, Thomas,
Patches 2 and 3 fix up the Makefile, and I'm particularly eager to get
those merged into 6.10, because the existing Makefile is leading people
astray. See the thread in [2] for an example of that.
As a result, Jason Donenfeld is now waiting for this, for his "implement
getrandom() in vDSO" series.
The Makefile is more of a kselftest infrastructure thing in a way, so
maybe Shuah can pull this in? I'm casting about for ways to move forward.
[2] https://lore.kernel.org/13483c92-cac5-4a3a-891f-22eb006c533b@nvidia.com
thanks,
--
John Hubbard
NVIDIA
>>
>> Changes since v2:
>>
>> 1. Added two patches, both of which apply solely to the Makefile.
>> These provide a smaller, cleaner, and more accurate Makefile.
>>
>> 2. Added Reviewed-by and Tested-by tags for the original patch, which
>> fixes all of the clang errors and warnings for this selftest.
>>
>> 3. Removed an obsolete blurb from the commit description of the original
>> patch, now that Valentin Obst LLVM build fix has been merged.
>>
>>
>> [1] https://lore.kernel.org/20240614190646.2081057-1-Jason@zx2c4.com
>>
>>
>> John Hubbard (3):
>> selftests/vDSO: fix clang build errors and warnings
>> selftests/mm: remove partially duplicated "all:" target in Makefile
>> selftests/vDSO: remove duplicate compiler invocations from Makefile
>>
>> tools/testing/selftests/vDSO/Makefile | 29 ++++++++-----------
>> tools/testing/selftests/vDSO/parse_vdso.c | 16 ++++++----
>> .../selftests/vDSO/vdso_standalone_test_x86.c | 18 ++++++++++--
>> 3 files changed, 39 insertions(+), 24 deletions(-)
>>
>>
>> base-commit: 2ccbdf43d5e758f8493a95252073cf9078a5fea5
>
> thanks,
prev parent reply other threads:[~2024-06-17 20:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 23:31 [PATCH v3 0/3] selftests/vDSO: fix clang build errors, and Makefile cleanup John Hubbard
2024-06-14 23:31 ` [PATCH v3 1/3] selftests/vDSO: fix clang build errors and warnings John Hubbard
2024-06-14 23:38 ` John Hubbard
2024-07-02 18:12 ` Edward Liaw
2024-07-02 18:25 ` John Hubbard
2024-07-02 18:49 ` Edward Liaw
2024-07-02 19:24 ` John Hubbard
2024-06-14 23:31 ` [PATCH v3 2/3] selftests/mm: remove partially duplicated "all:" target in Makefile John Hubbard
2024-06-14 23:31 ` [PATCH v3 3/3] selftests/vDSO: remove duplicate compiler invocations from Makefile John Hubbard
2024-06-14 23:34 ` [PATCH v3 0/3] selftests/vDSO: fix clang build errors, and Makefile cleanup John Hubbard
2024-06-17 20:15 ` John Hubbard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e9de90dd-c541-45bf-a364-0e7aaf320314@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=Jason@zx2c4.com \
--cc=broonie@kernel.org \
--cc=cmllamas@google.com \
--cc=colin.i.king@gmail.com \
--cc=kernel@valentinobst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=luto@kernel.org \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox