From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D91B5C10DCE for ; Wed, 18 Mar 2020 17:29:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B514F20724 for ; Wed, 18 Mar 2020 17:29:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727041AbgCRR3d (ORCPT ); Wed, 18 Mar 2020 13:29:33 -0400 Received: from mga05.intel.com ([192.55.52.43]:5332 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726680AbgCRR3c (ORCPT ); Wed, 18 Mar 2020 13:29:32 -0400 IronPort-SDR: YXBJPFW5nY1/mOmsrimVTRtOujw1V730sdrwruVdLJb5shhFYolp9U863qJfB0DDr2hCgvkEzs rCDyK8l2cgSg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2020 10:29:32 -0700 IronPort-SDR: 8wjTKwEGjtOqK84tOMlzANuDJyel22KWeBhiweWj8uGXFRt612yrbs31gBHCbTRjoygKPMcdg3 t+rUMhfSR2wQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,568,1574150400"; d="scan'208";a="418024231" Received: from nali1-mobl3.amr.corp.intel.com (HELO [10.255.33.194]) ([10.255.33.194]) by orsmga005.jf.intel.com with ESMTP; 18 Mar 2020 10:29:30 -0700 Subject: Re: snd_hda_intel/sst-acpi sound breakage on suspend/resume since 5.6-rc1 To: Dominik Brodowski Cc: cezary.rojewski@intel.com, alsa-devel@alsa-project.org, curtis@malainey.com, Keyon Jie , tiwai@suse.com, linux-kernel@vger.kernel.org, liam.r.girdwood@linux.intel.com, broonie@kernel.org References: <20200318063022.GA116342@light.dominikbrodowski.net> <41d0b2b5-6014-6fab-b6a2-7a7dbc4fe020@linux.intel.com> <20200318123930.GA2433@light.dominikbrodowski.net> <20200318162029.GA3999@light.dominikbrodowski.net> <20200318171912.GA6203@light.dominikbrodowski.net> From: Pierre-Louis Bossart Message-ID: Date: Wed, 18 Mar 2020 12:29:30 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200318171912.GA6203@light.dominikbrodowski.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/18/20 12:19 PM, Dominik Brodowski wrote: > On Wed, Mar 18, 2020 at 12:08:24PM -0500, Pierre-Louis Bossart wrote: >> On 3/18/20 11:20 AM, Dominik Brodowski wrote: >>> On Wed, Mar 18, 2020 at 10:13:54AM -0500, Pierre-Louis Bossart wrote: >>>> >>>> >>>>>>> While 5.5.x works fine, mainline as of ac309e7744be (v5.6-rc6+) causes me >>>>>>> some sound-related trouble: after boot, the sound works fine -- but once I >>>>>>> suspend and resume my broadwell-based XPS13, I need to switch to headphone >>>>>>> and back to speaker to hear something. But what I hear isn't music but >>>>>>> garbled output. >>>> >>>> It's my understanding that the use of the haswell driver is opt-in for Dell >>>> XPS13 9343. When we run the SOF driver on this device, we have to explicitly >>>> bypass an ACPI quirk that forces HDAudio to be used: >>>> >>>> https://github.com/thesofproject/linux/commit/944b6a2d620a556424ed4195c8428485fcb6c2bd >>>> >>>> Have you tried to run in plain vanilla HDAudio mode? >>> >>> I had (see 18d78b64fddc), but not any more in years (and I'd like to keep >>> using I2S, which has worked flawlessly in these years). >> >> ok. I don't think Intel folks have this device available, or it's used for >> other things, but if you want to bisect on you may want to use [1] to solve >> DRM issues. I used it to make Broadwell/Samus work again with SOF. >> >> [1] https://gitlab.freedesktop.org/drm/intel/uploads/ef10c6c27fdc53d114f827bb72b078aa/0001-drm-i915-psr-Force-PSR-probe-only-after-full-initial.patch.txt >> >> An alternate path would be to switch to SOF. It's still viewed as a >> developer option but Broadwell/Samus work reliably for me and we have a >> Broadwell-rt286 platform used for CI. > > What do you mean with SOF? And no other ideas on the root cause than a > tedious bisect? Sound Open Firmware (SOF) [1]. You can build your own audio firmware for Broadwell and the driver is supported in the mainline (you'd need to disable the legacy driver [2]). I can't think of any changes to that haswell/broadwell legacy driver, apart from Takashi's buffer management changes 3f93b1ed4ac1e2. But there were multiple changes to the ASoC core, so it's possible that they impact suspend/resume. Just a blind guess. [1] https://thesofproject.github.io/latest/index.html [2] https://github.com/thesofproject/kconfig/blob/023cc25cd0b26a9757592d0bbbbe719825dd728d/sof-dev-defconfig#L20