Re: [PATCH 4/8] platform/x86/intel/sdsi: Add netlink SPDM transport

Jiri Pirko
2024-02-01T09:26:37Z

Thu, Feb 01, 2024 at 02:07:43AM CET, david.e.box@linux.intel.com wrote:

[...]

>+ -
>+ name: spdm-req
>+ type: binary
>+ -
>+ name: spdm-rsp
>+ type: binary

I don't understand the need to use netlink for this. Basically what you
do is you just use it to pass binary blobs to and from FW.
Advantages, like well-defined attributes, notifications etc, for which
it makes sense to use Netlink are not utilized at all.
Also, I don't thing it is good idea to have hw-driver-specific genl
family. I'm not aware of anything like that so far. Leave netlink
for use of generic and abstracted APIs.

Can't you just have a simple misc device for this?

Thanks.

>+ -
>+ name: spdm-rsp-size
>+ type: u32
>+ -
>+ name: spdm-req-size
>+ type: u32
>+ - …