Re: [PATCH V2 5/7] arm64/perf: Drive BRBE from perf event states

kernel test robot
2022-09-08T15:32:30Z

Hi Anshuman,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on acme/perf/core]
[also build test WARNING on tip/perf/core arm64/for-next/core linus/master v6.0-rc4 next-20220908]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Anshuman-Khandual/arm64-perf-Enable-branch-stack-sampling/20220908-131425
base: https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git perf/core
config: arm64-randconfig-r025-20220907 (https://download.01.org/0day-ci/archive/20220908/202209082350.lDY2EvGx-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 1546df49f5a6d09df78f569e4137ddb365a3e827)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/5c7c07e050abb38b80d0c129fdef3a6f4b761017
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Anshuman-Khandual/arm64-perf-Enable-branch-stack-sampling/20220908-131425
git checkout 5c7c07e050abb38b80d0c129fdef3a6f4b761017
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/perf/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/perf/arm_pmu.c:535:12: warning: stack frame size (2064) exceeds limit (2048) in 'armpmu_event_init' [-Wframe-larger-than]
static int armpmu_event_init(struct perf_event *event)
^
1 warning generated.

vim +/armpmu_event_init +535 drivers/perf/arm_pmu.c

1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles 2010-02-02 534
b0a873ebbf87bf arch/arm/kernel/perf_event.c Peter Zijlstra 2010-06-11 @535 static int armpmu_event_init(struct perf_event *event)
1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles 2010-02-02 536 {
8a16b34e21199e arch/arm/kernel/perf_event.c Mark Rutland 2011-04-28 537 struct arm_pmu *armpmu = to_arm_pmu(event->pmu);
1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles 2010-02-02 538
cc88116da0d18b arch/arm/kernel/perf_event.c Mark Rutland 2015-05-13 539 /*
cc88116da0d18b arch/arm/kernel/perf_event.c Mark Rutland 2015-05-13 540 * Reject CPU-affine events for CPUs that are of a different class to
cc88116da0d18b arch/arm/kernel/perf_event.c Mark Rutland 2015-05-13 541 * that which this PMU handles. Process-following events (where
cc88116da0d18b arch/arm/kernel/perf_event.c Mark Rutland 2015-05-13 542 * event->cpu == -1) can be migrated between CPUs, and thus we have to
cc88116da0d18b arch/arm/kernel/perf_event.c Mark Rutland 2015-05-13 543 * reject them later (in armpmu_add) if they're scheduled on a
cc88116da0d18b arch/arm/kernel/perf_event.c Mark Rutland 2015-05-13 544 * different class of CPU.
cc88116da0d18b arch/arm/kernel/perf_event.c Mark Rutland 2015-05-13 545 */
cc88116da0d18b arch/arm/kernel/perf_event.c Mark Rutland 2015-05-13 546 if (event->cpu != -1 &&
cc88116da0d18b arch/arm/kernel/perf_event.c Mark Rutland 2015-05-13 547 !cpumask_test_cpu(event->cpu, &armpmu->supported_cpus))
cc88116da0d18b arch/arm/kernel/perf_event.c Mark Rutland 2015-05-13 548 return -ENOENT;
cc88116da0d18b arch/arm/kernel/perf_event.c Mark Rutland 2015-05-13 549
2481c5fa6db023 arch/arm/kernel/perf_event.c Stephane Eranian 2012-02-09 550 /* does not support taken branch sampling */
2481c5fa6db023 arch/arm/kernel/perf_event.c Stephane Eranian 2012-02-09 551 if (has_branch_stack(event))
2481c5fa6db023 arch/arm/kernel/perf_event.c Stephane Eranian 2012-02-09 552 return -EOPNOTSUPP;
2481c5fa6db023 arch/arm/kernel/perf_event.c Stephane Eranian 2012-02-09 553
e1f431b57ef9e4 arch/arm/kernel/perf_event.c Mark Rutland 2011-04-28 554 if (armpmu->map_event(event) == -ENOENT)
b0a873ebbf87bf arch/arm/kernel/perf_event.c Peter Zijlstra 2010-06-11 555 return -ENOENT;
b0a873ebbf87bf arch/arm/kernel/perf_event.c Peter Zijlstra 2010-06-11 556
c09adab01e4aee drivers/perf/arm_pmu.c Mark Rutland 2017-03-10 557 return __hw_perf_event_init(event);
1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles 2010-02-02 558 }
1b8873a0c6ec51 arch/arm/kernel/perf_event.c Jamie Iles 2010-02-02 559

--
0-DAY CI Kernel Test Service