* [PATCH] drivers/tty/moxa: Fix spelling mistake in comment
@ 2025-06-05 0:09 shanmukh.iyer
2025-06-09 8:26 ` Jiri Slaby
2025-06-09 12:39 ` Hugo Villeneuve
0 siblings, 2 replies; 5+ messages in thread
From: shanmukh.iyer @ 2025-06-05 0:09 UTC (permalink / raw)
To: gregkh; +Cc: jirislaby, linux-kernel, linux-serial, trivial, Shanmukh Iyer
From: Shanmukh Iyer <shanmukh.iyer@polymtl.ca>
Corrected to "maximum" as my very first patch to the kernel.
Just to get used to the contribution workflow.
Signed-off-by: Shanmukh Iyer <shanmukh.iyer@polymtl.ca>
---
drivers/tty/moxa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c
index 329b30fac8fc..d32fb37e2e1c 100644
--- a/drivers/tty/moxa.c
+++ b/drivers/tty/moxa.c
@@ -1628,9 +1628,9 @@ static void MoxaPortFlushData(struct moxa_port *port, int mode)
*
* return: 0 : this port is invalid or baud < 50
* 50 - 115200 : the real baud rate set to the port, if
- * the argument baud is large than maximun
+ * the argument baud is large than maximum
* available baud rate, the real setting
- * baud rate will be the maximun baud rate.
+ * baud rate will be the maximum baud rate.
*
*
* Function 12: Configure the port.
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers/tty/moxa: Fix spelling mistake in comment
2025-06-05 0:09 [PATCH] drivers/tty/moxa: Fix spelling mistake in comment shanmukh.iyer
@ 2025-06-09 8:26 ` Jiri Slaby
2025-06-09 12:39 ` Hugo Villeneuve
1 sibling, 0 replies; 5+ messages in thread
From: Jiri Slaby @ 2025-06-09 8:26 UTC (permalink / raw)
To: shanmukh.iyer, gregkh; +Cc: linux-kernel, linux-serial, trivial, Shanmukh Iyer
On 05. 06. 25, 2:09, shanmukh.iyer@gmail.com wrote:
> From: Shanmukh Iyer <shanmukh.iyer@polymtl.ca>
>
> Corrected to "maximum" as my very first patch to the kernel.
> Just to get used to the contribution workflow.
>
> Signed-off-by: Shanmukh Iyer <shanmukh.iyer@polymtl.ca>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
--
js
suse labs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers/tty/moxa: Fix spelling mistake in comment
2025-06-05 0:09 [PATCH] drivers/tty/moxa: Fix spelling mistake in comment shanmukh.iyer
2025-06-09 8:26 ` Jiri Slaby
@ 2025-06-09 12:39 ` Hugo Villeneuve
2025-06-09 23:34 ` [PATCH v2] drivers/tty/moxa.c: " shanmukh.iyer
1 sibling, 1 reply; 5+ messages in thread
From: Hugo Villeneuve @ 2025-06-09 12:39 UTC (permalink / raw)
To: shanmukh.iyer
Cc: gregkh, jirislaby, linux-kernel, linux-serial, trivial,
Shanmukh Iyer
On Wed, 4 Jun 2025 20:09:03 -0400
shanmukh.iyer@gmail.com wrote:
Hi Shanmukh,
> From: Shanmukh Iyer <shanmukh.iyer@polymtl.ca>
>
> Corrected to "maximum" as my very first patch to the kernel.
> Just to get used to the contribution workflow.
>
> Signed-off-by: Shanmukh Iyer <shanmukh.iyer@polymtl.ca>
> ---
> drivers/tty/moxa.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c
> index 329b30fac8fc..d32fb37e2e1c 100644
> --- a/drivers/tty/moxa.c
> +++ b/drivers/tty/moxa.c
> @@ -1628,9 +1628,9 @@ static void MoxaPortFlushData(struct moxa_port *port, int mode)
> *
> * return: 0 : this port is invalid or baud < 50
> * 50 - 115200 : the real baud rate set to the port, if
> - * the argument baud is large than maximun
> + * the argument baud is large than maximum
while at it:
s/large/larger
> * available baud rate, the real setting
> - * baud rate will be the maximun baud rate.
> + * baud rate will be the maximum baud rate.
> *
> *
> * Function 12: Configure the port.
> --
> 2.34.1
>
>
--
Hugo Villeneuve
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] drivers/tty/moxa.c: Fix spelling mistake in comment
2025-06-09 12:39 ` Hugo Villeneuve
@ 2025-06-09 23:34 ` shanmukh.iyer
2025-06-10 4:56 ` Jiri Slaby
0 siblings, 1 reply; 5+ messages in thread
From: shanmukh.iyer @ 2025-06-09 23:34 UTC (permalink / raw)
To: hugo; +Cc: gregkh, jirislaby, linux-kernel, linux-serial, shanmukh.iyer,
trivial
From: Shanmukh Iyer <shanmukh.iyer@gmail.com>
Corrected some spelling and grammar in the comments, such as:
- Units (baud -> baud rate)
- Sentence flow
- typos
This is part of my first patch to get familiar with
the kernel's patch contribution workflow.
Signed-off-by: Shanmukh Iyer <shanmukh.iyer@gmail.com>
---
drivers/tty/moxa.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c
index 329b30fac8fc..bf86f24e5655 100644
--- a/drivers/tty/moxa.c
+++ b/drivers/tty/moxa.c
@@ -1627,10 +1627,11 @@ static void MoxaPortFlushData(struct moxa_port *port, int mode)
* long baud : baud rate (50 - 115200)
*
* return: 0 : this port is invalid or baud < 50
- * 50 - 115200 : the real baud rate set to the port, if
- * the argument baud is large than maximun
- * available baud rate, the real setting
- * baud rate will be the maximun baud rate.
+ * 50 - 115200 : the real baud rate is set to the port, if
+ * the argument baud rate is larger than
+ * the maximum available baud rate, the
+ * real setting baud rate will be the
+ * maximum baud rate.
*
*
* Function 12: Configure the port.
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] drivers/tty/moxa.c: Fix spelling mistake in comment
2025-06-09 23:34 ` [PATCH v2] drivers/tty/moxa.c: " shanmukh.iyer
@ 2025-06-10 4:56 ` Jiri Slaby
0 siblings, 0 replies; 5+ messages in thread
From: Jiri Slaby @ 2025-06-10 4:56 UTC (permalink / raw)
To: shanmukh.iyer, hugo; +Cc: gregkh, linux-kernel, linux-serial, trivial
On 10. 06. 25, 1:34, shanmukh.iyer@gmail.com wrote:
> From: Shanmukh Iyer <shanmukh.iyer@gmail.com>
>
> Corrected some spelling and grammar in the comments, such as:
> - Units (baud -> baud rate)
> - Sentence flow
> - typos
>
> This is part of my first patch to get familiar with
> the kernel's patch contribution workflow.
>
> Signed-off-by: Shanmukh Iyer <shanmukh.iyer@gmail.com>
> ---
v2 changelog missing here now.
> drivers/tty/moxa.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/tty/moxa.c b/drivers/tty/moxa.c
> index 329b30fac8fc..bf86f24e5655 100644
> --- a/drivers/tty/moxa.c
> +++ b/drivers/tty/moxa.c
> @@ -1627,10 +1627,11 @@ static void MoxaPortFlushData(struct moxa_port *port, int mode)
> * long baud : baud rate (50 - 115200)
> *
> * return: 0 : this port is invalid or baud < 50
> - * 50 - 115200 : the real baud rate set to the port, if
> - * the argument baud is large than maximun
> - * available baud rate, the real setting
> - * baud rate will be the maximun baud rate.
> + * 50 - 115200 : the real baud rate is set to the port, if
the new "is" looks superfluous.
> + * the argument baud rate is larger than
> + * the maximum available baud rate, the
> + * real setting baud rate will be the
> + * maximum baud rate.
> *
> *
> * Function 12: Configure the port.
--
js
suse labs
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2025-06-10 4:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-06-05 0:09 [PATCH] drivers/tty/moxa: Fix spelling mistake in comment shanmukh.iyer
2025-06-09 8:26 ` Jiri Slaby
2025-06-09 12:39 ` Hugo Villeneuve
2025-06-09 23:34 ` [PATCH v2] drivers/tty/moxa.c: " shanmukh.iyer
2025-06-10 4:56 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).