From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F7232CCC5 for ; Thu, 17 Jul 2025 11:46:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752752770; cv=none; b=dlflAIFfZxxbUDohgXA9/BZBk2kVOVBobmtpxuEXARAE38ucw3Nvfz8/QVQpaG5hzOx7Gx7t0A2+WyhSAHryav5tMOQzRYs1k8AFaNAnog8MKxgf8MYNK4QrfuM8bz9NHGn0fnkjgEh1Yy0+sazhTsI9LCybjLy619QSUGoUO5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752752770; c=relaxed/simple; bh=y5Yvsl4fGOPbGkM+LLjwuxdkLlvSVR7Mj0EaWJvOXyo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=twlDrjr4pNrX13PK7qtNN9JnjJ1YOyb1kRvK3O2vjMYWulY7nKdOnivQnODA4SS0TH2V1wbj6yObAOZ9GVlFSN30bTgS54AmtNSDG5FJ0Bwr2apn05aBMwcvp86uR+qVeXIiksfkROTLc6boqe10l/UqbaZAwatMyIUTETJe+pg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GCkX2a96; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GCkX2a96" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752752768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=f3CNnOqez6AzkBc0azQI5WcTOpAKQZ1WjefmRJbSD+o=; b=GCkX2a96l1NJI7SCSTPx0BhcJi2OopMdNEofOIDF9yyUaGnDvjsmACrAyjz7sbH4P7fsSL m0JFVqFQarxAxo0zmjQNBHg3zH1qBbNOiNlxk+ZNyfYNoKNFuejbLgrM7/R6lXbFffFoaw BI3SGYZxzBqRFrlpKIencpQBcBXlbE8= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-137-Gudn0nRzMDWg0rlsBRey8Q-1; Thu, 17 Jul 2025 07:46:07 -0400 X-MC-Unique: Gudn0nRzMDWg0rlsBRey8Q-1 X-Mimecast-MFC-AGG-ID: Gudn0nRzMDWg0rlsBRey8Q_1752752766 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-456267c79deso2603665e9.1 for ; Thu, 17 Jul 2025 04:46:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752752766; x=1753357566; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=f3CNnOqez6AzkBc0azQI5WcTOpAKQZ1WjefmRJbSD+o=; b=jr1AnD6ZAhvpegRkMS58PaJzTVtDu/Kmw5/+FgPS22G0YOsPEv8JWs+sCkghQxIFDP NE+z6c5RSvRD+2vSl8oTE30+3ySHbolfwpt9MLOMr6gC2Px8RbBRADFhNsHxzj/kXTMU rtKKN4SF7hILBkbjtO8fdsespsw4ENbD6dzIIhDI1RWOFdBvueGlKDvBwFiN6s5I4Dwr VAxJdk2pZ0M/ZwzxX3tGrGnE6g+1k7wF54T335vRakl/9oJ8w/+LIFlrZTdQ6zi34y0G uGLx0G3eosU1B+GFt4n/58Fo2Aqcl+RKcGUlL4mqMvWmZEVg4uMvjJVFeAKAcygAVmPB 9ySw== X-Forwarded-Encrypted: i=1; AJvYcCXD9q9y93cyWePztTPkFIP3f1ZsXdXTqNvVd6ndkNB9qSRsObP4sG1k74yOLqjCRY6SoSMZORHd3RWdSHs=@vger.kernel.org X-Gm-Message-State: AOJu0YzYragfeJqtroA1mkGEmq1bDmfjRJ8sawKhCArzLe/z6YgQYDBq V/XfYIaIsECaseIOF5gsRKs5gJeJcfAbqzDNYySV2XOSdWUwP8JIF0LJhZZh0oRw0cqDbambBm5 4RVNi1ZfcSDCVkwR0nEtpv9shDmGfHVFtFcPjnbk2PYYfhn/XlGpIaT+dnvR1K+jDRA== X-Gm-Gg: ASbGncuvkGHWt/Ap6iWWF3wj16LNJ7tlkmOO7GmgoGynzmn98wDop9ZSeFPgi9IZYwm buE050zHqyXBjHK1exwVimRLyDqK8pQlGhdmOtbirYnx9QZtaR3lTvtWSR+HxWKYfkhN8GxDSA7 4V6X6XEHeb355GQN4YH+OFUnSwbrwoG2gILLhSyZppHJwsR52Q0+hiJuzgCE4P3oxaPUTEa95gL GQnTwvu9RQAMoBMuSpVD4KBNbnLce6wOmOzqktNuQcN/K7AT2awjCqEQUPO5n2MPCDNvVQHCpM5 7LZ4kVzTyHc7EYeOeV/77dSXd/JTRW9Pfx0fjrem9AbTTiJG32ghMOI0rSG4oexhfIgNxxUDcya h2J+1dey49e2+q/VDb+VjkpaBsQa3bNYGTUOvsX6ZvcUzpyKNH3zwrDbvHGDvVbIT X-Received: by 2002:a05:600c:a10f:b0:454:ad94:4b3d with SMTP id 5b1f17b1804b1-4562e37a0f7mr44076105e9.1.1752752765699; Thu, 17 Jul 2025 04:46:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHmFjfdXEG/fRnZhxAAlgeVgrboqZitpFuKt4eHOADc0jjqpqiFBONXu1paEh0mp24W2TnnLQ== X-Received: by 2002:a05:600c:a10f:b0:454:ad94:4b3d with SMTP id 5b1f17b1804b1-4562e37a0f7mr44075725e9.1.1752752765217; Thu, 17 Jul 2025 04:46:05 -0700 (PDT) Received: from ?IPV6:2003:d8:2f1f:3600:dc8:26ee:9aa9:fdc7? (p200300d82f1f36000dc826ee9aa9fdc7.dip0.t-ipconnect.de. [2003:d8:2f1f:3600:dc8:26ee:9aa9:fdc7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8dc91d8sm20291948f8f.42.2025.07.17.04.46.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Jul 2025 04:46:04 -0700 (PDT) Message-ID: Date: Thu, 17 Jul 2025 13:46:03 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/5] mm: add static PMD zero page To: "Pankaj Raghav (Samsung)" Cc: Suren Baghdasaryan , Ryan Roberts , Baolin Wang , Borislav Petkov , Ingo Molnar , "H . Peter Anvin" , Vlastimil Babka , Zi Yan , Mike Rapoport , Dave Hansen , Michal Hocko , Lorenzo Stoakes , Andrew Morton , Thomas Gleixner , Nico Pache , Dev Jain , "Liam R . Howlett" , Jens Axboe , linux-kernel@vger.kernel.org, willy@infradead.org, linux-mm@kvack.org, x86@kernel.org, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Darrick J . Wong" , mcgrof@kernel.org, gost.dev@samsung.com, hch@lst.de, Pankaj Raghav References: <20250707142319.319642-1-kernel@pankajraghav.com> <20250707142319.319642-4-kernel@pankajraghav.com> <26fded53-b79d-4538-bc56-3d2055eb5d62@redhat.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAmgsLPQFCRvGjuMACgkQTd4Q 9wD/g1o0bxAAqYC7gTyGj5rZwvy1VesF6YoQncH0yI79lvXUYOX+Nngko4v4dTlOQvrd/vhb 02e9FtpA1CxgwdgIPFKIuXvdSyXAp0xXuIuRPQYbgNriQFkaBlHe9mSf8O09J3SCVa/5ezKM OLW/OONSV/Fr2VI1wxAYj3/Rb+U6rpzqIQ3Uh/5Rjmla6pTl7Z9/o1zKlVOX1SxVGSrlXhqt kwdbjdj/csSzoAbUF/duDuhyEl11/xStm/lBMzVuf3ZhV5SSgLAflLBo4l6mR5RolpPv5wad GpYS/hm7HsmEA0PBAPNb5DvZQ7vNaX23FlgylSXyv72UVsObHsu6pT4sfoxvJ5nJxvzGi69U s1uryvlAfS6E+D5ULrV35taTwSpcBAh0/RqRbV0mTc57vvAoXofBDcs3Z30IReFS34QSpjvl Hxbe7itHGuuhEVM1qmq2U72ezOQ7MzADbwCtn+yGeISQqeFn9QMAZVAkXsc9Wp0SW/WQKb76 FkSRalBZcc2vXM0VqhFVzTb6iNqYXqVKyuPKwhBunhTt6XnIfhpRgqveCPNIasSX05VQR6/a OBHZX3seTikp7A1z9iZIsdtJxB88dGkpeMj6qJ5RLzUsPUVPodEcz1B5aTEbYK6428H8MeLq NFPwmknOlDzQNC6RND8Ez7YEhzqvw7263MojcmmPcLelYbfOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCaCwtJQUJG8aPFAAKCRBN3hD3AP+DWlDnD/4k2TW+HyOOOePVm23F5HOhNNd7nNv3 Vq2cLcW1DteHUdxMO0X+zqrKDHI5hgnE/E2QH9jyV8mB8l/ndElobciaJcbl1cM43vVzPIWn 01vW62oxUNtEvzLLxGLPTrnMxWdZgxr7ACCWKUnMGE2E8eca0cT2pnIJoQRz242xqe/nYxBB /BAK+dsxHIfcQzl88G83oaO7vb7s/cWMYRKOg+WIgp0MJ8DO2IU5JmUtyJB+V3YzzM4cMic3 bNn8nHjTWw/9+QQ5vg3TXHZ5XMu9mtfw2La3bHJ6AybL0DvEkdGxk6YHqJVEukciLMWDWqQQ RtbBhqcprgUxipNvdn9KwNpGciM+hNtM9kf9gt0fjv79l/FiSw6KbCPX9b636GzgNy0Ev2UV m00EtcpRXXMlEpbP4V947ufWVK2Mz7RFUfU4+ETDd1scMQDHzrXItryHLZWhopPI4Z+ps0rB CQHfSpl+wG4XbJJu1D8/Ww3FsO42TMFrNr2/cmqwuUZ0a0uxrpkNYrsGjkEu7a+9MheyTzcm vyU2knz5/stkTN2LKz5REqOe24oRnypjpAfaoxRYXs+F8wml519InWlwCra49IUSxD1hXPxO WBe5lqcozu9LpNDH/brVSzHCSb7vjNGvvSVESDuoiHK8gNlf0v+epy5WYd7CGAgODPvDShGN g3eXuA== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 17.07.25 12:34, Pankaj Raghav (Samsung) wrote: >>> Then, we'd only need a config option to allow for that to happen. >> >> Something incomplete and very hacky just to give an idea. It would try allocating >> it if there is actual code running that would need it, and then have it >> stick around forever. >> > Thanks a lot for this David :) I think this is a much better idea and > reduces the amount code and reuse the existing infrastructure. > > I will try this approach in the next version. > > >> + /* >> + * Our raised reference will prevent the shrinker from ever having >> + * success -> static. >> + */ >> + if (atomic_read(&huge_zero_folio_is_static)) >> + return huge_zero_folio; >> + /* TODO: memblock allocation if buddy is not up yet? Or Reject that earlier. */ > > Do we need memblock allocation? At least the use cases I forsee for > static pmd zero page are all after the mm is up. So I don't see why we > need to allocate it via memblock. Even better! We might want to detect whether allocation of the huge zeropage failed a couple of times and then just give up. Otherwise, each and every user of the largest zero folio will keep allocating it. -- Cheers, David / dhildenb