From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-102.mailbox.org (mout-p-102.mailbox.org [80.241.56.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF36D3D6480; Tue, 3 Mar 2026 14:15:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.152 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772547356; cv=none; b=KuPm3gg/M7QrlqOlYKU91Xo4lRGYmlMeXVTS1v2wH4DSwAW5ojzT+ACbjVJxaAeyUwie6wMP+JLdoR106Utk2tvyN0ls8QhR3JL8s2oHJQ/rUsd6/yN71cS+0L4WhkrIwXtDBGFDjMJYKscP7hh6jlYu+EUloXwKFknSozLXYII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772547356; c=relaxed/simple; bh=Gicao+9lu9MvYgyTTephIYFRDsgSVj1OSu5Lvq1Ev10=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FfLYZANS04mN4zm3huHlmNb38rDvvnxsOac5qudMKHnblBuGofQBK0CrrmIj5pe1kEjHtzBMqrCy9M8Iq1jGkdlh28x/OFMyfe0gec5SV9Gc1cX6xpJ4MWDG/zlv4PG+2lOXPZVjWpizO2F8sZGsqlCKiRHkfSr9C4VgVP0lnjk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=bX7R4Mos; arc=none smtp.client-ip=80.241.56.152 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="bX7R4Mos" Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4fQHs25dxRz9vCJ; Tue, 3 Mar 2026 15:15:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1772547350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vkxg76Zvr5nEIh4+DPVppUp2uw6hT8c9cXZv6TYN+wg=; b=bX7R4MosXKdYmrqTRLni21XP9YeHU4+puTDdwo5DE1ey5ibk3lwt1H7ZlBSo936dgmW8Sc WhaJvZgZP5JvrFb25A9EgTbzJdEPOEmpjcGDZfHA1jFj8onefDPmXSQihGuIkLsmzKTTrD up3ty7Bs9dIdCbyDOHj80JnhfuHR1t3+/U/xPq0uvROodBWBoTI3gWvhA4JOVbWKeYASpX XKjwgrd8voOmcyWdNT5Noq/hHHzhqLo6YVM9hfku00nnwc/uSOWjnWXt4tWPWVOPqDBJ4s FiFoKzCYbmHaSNZQpEX3AgMgQu2bMf1oTlPedkzbKPDtFl2SF+J3CKGr4ozWZQ== Message-ID: Date: Tue, 3 Mar 2026 15:15:27 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH v2 2/2] drm/bridge: waveshare-dsi: Add support for 1..4 DSI data lanes To: Luca Ceresoli , Maxime Ripard Cc: dri-devel@lists.freedesktop.org, Joseph Guo , Conor Dooley , David Airlie , Jernej Skrabec , Jonas Karlman , Krzysztof Kozlowski , Laurent Pinchart , Maarten Lankhorst , Neil Armstrong , Rob Herring , Robert Foss , Simona Vetter , Thomas Zimmermann , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org References: <20260115024004.660986-1-marek.vasut+renesas@mailbox.org> <20260115024004.660986-2-marek.vasut+renesas@mailbox.org> <3af09657-78ce-4bc6-b8d5-b346a3b86c5b@mailbox.org> <20260303-free-kudu-from-vega-20fb3e@houat> <13afd1fc-7201-4210-a697-8977d47857e7@mailbox.org> Content-Language: en-US From: Marek Vasut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-MBO-RS-META: mj734nhz7wpm6zqbqdizwigeorrak6mj X-MBO-RS-ID: afe2d02ea44f4e40261 On 3/3/26 2:32 PM, Luca Ceresoli wrote: > Hi Marek, > > On Tue Mar 3, 2026 at 1:59 PM CET, Marek Vasut wrote: >> On 3/3/26 8:56 AM, Maxime Ripard wrote: >>> On Mon, Mar 02, 2026 at 10:35:31PM +0100, Marek Vasut wrote: >>>> On 2/6/26 12:48 PM, Marek Vasut wrote: >>>>> On 1/15/26 3:39 AM, Marek Vasut wrote: >>>>>> Parse the data lane count out of DT. Limit the supported data lanes >>>>>> to 1..4 which is the maximum available DSI pairs on the connector of >>>>>> any known panels which may use this bridge. Internally, this bridge >>>>>> is an ChipOne ICN6211 which loads its register configuration from a >>>>>> dedicated storage and its I2C does not seem to be accessible. The >>>>>> ICN6211 also supports up to 4 DSI lanes, so this is a hard limit. >>>>>> >>>>>> To avoid any breakage on old DTs where the parsing of data lanes from >>>>>> DT may fail, fall back to the original hard-coded value of 2 lanes and >>>>>> warn user. >>>>>> >>>>>> The lane configuration is preconfigured in the bridge for each of the >>>>>> WaveShare panels. The 13.3" DSI panel works with 4-lane configuration, >>>>>> others seem to use 2-lane configuration. This is a hardware property, >>>>>> so the actual count should come from DT. >>>>>> >>>>>> Reviewed-by: Joseph Guo >>>>>> Signed-off-by: Marek Vasut >>>>> >>>>> Is it OK to apply these two patches now ? >>>> >>>> Can this be applied now ? >>> >>> It looks like you have a reviewed-by already, what's stoping you from >>> applying it yourself? >> I generally try to avoid applying my own patches, but if that is OK >> here, I will apply them ? > > I fid it a bit weird as well, but it's the common practice in drm-misc, so > I do it when there are enough R-by / A-by. > > One thing I'm never sure about is the definition of "enough R-by / A-by" > though. I used to kind of assume at least a maintainer listed in > MAINTAINERS should approve the patch. But that also seems not a rule for > drm-misc, at least for patches that impact only a specific driver and not > core or otherwise shared code, and/or which look "obviously correct". > > Based on the above, I'm applying this series right now. Thank you