From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: "Tanzir Hasan" <tanzirh@google.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Christian Brauner" <brauner@kernel.org>,
"Carlos Llamas" <cmllamas@google.com>,
"Suren Baghdasaryan" <surenb@google.com>
Cc: linux-kernel@vger.kernel.org, Nick Desaulniers <nnn@google.com>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] android: removed asm-generic/errno-base.h
Date: Thu, 4 Jan 2024 16:36:00 +0100 [thread overview]
Message-ID: <eacd168f-22dd-4e11-8907-0c79ee33f595@wanadoo.fr> (raw)
In-Reply-To: <20231226-binderfs-v1-1-66829e92b523@google.com>
Le 26/12/2023 à 18:09, Tanzir Hasan a écrit :
> asm-generic/errno-base.h can be replaced by linux/errno.h and the file
> will still build correctly. It is an asm-generic file which should be
> avoided if possible.
>
> Suggested-by: Al Viro <viro@zeniv.linux.org.uk>
> Signed-off-by: Tanzir Hasan <tanzirh@google.com>
> ---
> drivers/android/binderfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/android/binderfs.c b/drivers/android/binderfs.c
> index 1224ab7aa070..d04ff6029480 100644
> --- a/drivers/android/binderfs.c
> +++ b/drivers/android/binderfs.c
> @@ -29,7 +29,7 @@
> #include <linux/uaccess.h>
> #include <linux/user_namespace.h>
> #include <linux/xarray.h>
> -#include <uapi/asm-generic/errno-base.h>
> +#include <linux/errno.h>
linux/errno.h is already included a few lines above.
CJ
> #include <uapi/linux/android/binder.h>
> #include <uapi/linux/android/binderfs.h>
>
>
> ---
> base-commit: 606d9c29e71fbf52fcfd3fcc3ad92e444c8e1d47
> change-id: 20231218-binderfs-a758e162e0ba
>
> Best regards,
next prev parent reply other threads:[~2024-01-04 15:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-26 17:09 [PATCH] android: removed asm-generic/errno-base.h Tanzir Hasan
2024-01-04 15:09 ` Carlos Llamas
2024-01-04 15:36 ` Christophe JAILLET [this message]
2024-01-04 16:08 ` Joel Fernandes
2024-01-04 17:18 ` Carlos Llamas
2024-01-04 17:32 ` Tanzir Hasan
2024-01-04 18:16 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eacd168f-22dd-4e11-8907-0c79ee33f595@wanadoo.fr \
--to=christophe.jaillet@wanadoo.fr \
--cc=arve@android.com \
--cc=brauner@kernel.org \
--cc=cmllamas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=nnn@google.com \
--cc=surenb@google.com \
--cc=tanzirh@google.com \
--cc=tkjos@android.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox