From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753127AbcGVTZ4 (ORCPT ); Fri, 22 Jul 2016 15:25:56 -0400 Received: from mail-sn1nam01on0125.outbound.protection.outlook.com ([104.47.32.125]:6992 "EHLO NAM01-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752182AbcGVTZy (ORCPT ); Fri, 22 Jul 2016 15:25:54 -0400 X-Greylist: delayed 79221 seconds by postgrey-1.27 at vger.kernel.org; Fri, 22 Jul 2016 15:25:54 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=linda.knippers@hpe.com; Subject: Re: [PATCH] Revert "cpufreq: pcc-cpufreq: update default value of cpuinfo_transition_latency" To: Viresh Kumar , "Rafael J. Wysocki" , Andreas Herrmann References: <20160722151411.GB11711@suselix.suse.de> <20160722153656.GR3122@ubuntu> CC: Jacob Tanenbaum , , , From: Linda Knippers Message-ID: Date: Fri, 22 Jul 2016 15:25:43 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160722153656.GR3122@ubuntu> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [50.187.52.22] X-ClientProxiedBy: BY2PR1001CA0050.namprd10.prod.outlook.com (10.164.163.18) To CS1PR84MB0231.NAMPRD84.PROD.OUTLOOK.COM (10.162.190.153) X-MS-Office365-Filtering-Correlation-Id: 2bacbffa-ea04-45c5-d107-08d3b265ff0f X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0231;2:hIoiWtQzYdHOaX/rfgkj4OykaCBij0Ssg27co1t1kFPTVVYiUaQ+ItVpgnVJ7rIp00aFJh+slzDhmTpOwt8nWqoRA4U1AT8VRD6oCL0+P5sii0sZIzQRBDurMqQghUOqXj7P5c5w4M37W1Dtb4r5L+1wXgzJ8sHIfpOy7EnvP4UFkPNikWldbFMdN8qbugYp;3:4XkxC/efsONzmGcq+GtaqhGNoxKCZ/x9NpVy7xOygGQO2zc2YmNvcK3gfEgBckmjzeElQtA01SKXpOqZUBl9+xTl3UAk08smq9VGHdqdoi/EyUmol2Bx1rhVHpbPw9t0;25:/5eyhkkI2SxOzlQgcm1usZe1Tl5re5pMUyemv/7IqTShACu1qDNlEeGzUaK2HrlK67iXDn8uDPvLCMw87azKHApnoVWMwui1AMFisMgiQDIkukncXq4EBg7vm1amDksyZJvgvKiEDofguqYwSnIL6sYZbp4HeyCTDdQpooLl6DNJNQrspunCo3CPirZkTyTtkqLmRRVOOrHEhAU138BgLOW2+4vYaudxVgepXT/FaibgF9lHBszSHShQDN7DUBafqzHqLCY8yMJOX2Lpus09r8bh6Kk4Q1cXDMydFIsShBdHkh4RBYobaDuk00WMJ9hKwSLemzvjpnJkomSxsgsHyiAgDpFUvl/lKhGISGv9aUaXGzYMBXrc4sdDVG3PG+GnKdn/nYpmm7RowHwKwB17uczagcMjaHEVZr4ztDd2LIM=;31:/K6lojX+wqVhGlrDMhVy/lSLp/Xq9jJQ1Ihq0AEKNQA77YvY0KbGnQ+dBGqvEKEU+HmFo+2ELnJq18bPpuTHsBNQSEowDvylymSS5S2g8oJoCg2XTxrRCYmSpDrhNGxDcSLZcX+B+IMO7hvsSmiJutI2ePOdnKsXT983a/EP4eSMyh30TY53nQ+Xe3VAlCy6JJ5/vCo8QnzY5zebAhZLWA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0231; X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0231;20:BnQd/rtaf09Ex6353YA3RGREyxLbP7LRuJHahn48Z7PUttRcxsvnQdsC5biP/yyolxNnXE8EkaybW+LKn1u8tf6o7MHls5mG3NNMj0q6OnthJ7zuKsubovA47r548iVWeThHCgKbCyXaI2vmw0lVh7inST2Hb8yju5cnINMkKyRsBhQPY9pBetKpXGnPCtn4PnfAIWrR+MYVa43yD5ebZKgLTzzdchBRYes2Uyj0uVfk6ZFK17mb1A9GXohK2pZ3FR4IAbBHE+rNw7RBiz49ldg1DlRWFbDVMST2/cJ0VnsLsVrv1boCMuKJc/vCsnNmYRcRjuZYoSzp8ZsirJlaDG/rWqF5b0+S0VOR12qh1souirPVOTpW/XEW3HlK3iP6kzgVU0+ZZi8QF53cVSioD14rjHAhs+rStiU6M3eGf2uPg0N3yfweHgJwfD2p7Tf3A3QT6cN4QLz/06eZCu+/e9XWmg3w5TPlVW7n5tz+A5WxLOH29u+C5GD/Kp8KWtQk;4:WCeXGbl4vBcJlXlJS6LHbTG4VGbp/52pp/3IZfMOCIPWeyGzJdswBp3USw4ie8LTRuFOIqh5v0vDOvIdaOIZJwyNZJVzQeUDL79Pil68i+zb5HaoTwcj7K8V78bcpIblHuJnBqk7GavAe/GBkly4x/v/CB8lEgnR6OSiCg2MLU4unAqIYqdPS6t1Xu9nAjWK5UV+rOLVwkKS4oekE7Ei1ZTtHcVwbhUJmq80lhKGLWv82mnCKD0yG2k8PsXUblBswTJ5d43v9yiq36WImvSLcpcXDLalYrgPlUNDYARfP6+eRawrfpAvYrm4Q3YJqHTKikUtIOWytFf2T/nnXTAEWuVh4e1nrXE9tVKbOdPhtyWZk+q2YLwlItHMTBa5KnW+zB6nfESIGgbCyzNyVYEQ7Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:CS1PR84MB0231;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0231; X-Forefront-PRVS: 0011612A55 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(199003)(377424004)(377454003)(189002)(24454002)(42186005)(586003)(105586002)(33646002)(2906002)(31696002)(575784001)(86362001)(8676002)(4326007)(36756003)(47776003)(68736007)(31686004)(117156001)(5001770100001)(64126003)(4001350100001)(97736004)(23746002)(101416001)(77096005)(83506001)(189998001)(2950100001)(106356001)(66066001)(3846002)(76176999)(230700001)(50986999)(54356999)(81156014)(81166006)(7846002)(65806001)(7736002)(92566002)(65956001)(305945005)(50466002)(6116002)(65826006);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0231;H:[192.168.1.7];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CS1PR84MB0231;23:EBhN4rREVpI9u0Fn7uHZbxRhoP49AldFmQRkP?= =?Windows-1252?Q?phxrnaU+7Dz+Lwhd8s67LE0R+AgQfB6ufMYy84IDzIYFyw62P7mN5zB1?= =?Windows-1252?Q?IwsFMQhL8rxRDGdN0cjG4BAMftGQ0oGcn1nKiFdqMx5ZnP9201g9264n?= =?Windows-1252?Q?IP7NwieIZq30AkPrF6lxHr4z+GV0cWoqts0epSBI/LDZLVqsACXXYsji?= =?Windows-1252?Q?JN4ZZYPwUEg8pfdwPlM47mWIPQL9Raz0VHy5WjcR8ii7HS/w97FcrtLF?= =?Windows-1252?Q?Cl88zDOe0ZWOK9judzTRYpVd2dJuQOLvg0FvzqAC981MFuB0dzQtBNCL?= =?Windows-1252?Q?WO6iBB/gysjeKQAHFH5v82WLPfN6lgVXG1Siag0mxGdB5G13DqR+TrIm?= =?Windows-1252?Q?NFNt6tWRJTvJqyjXGyUvpjHAVBwT+T3Wd3xI8msfl6OqoUNdxwUWc8ft?= =?Windows-1252?Q?KtTPmrW8m5g5F7rFVQzHkmNeeSM2aJ86nI5K2fJo+b3QIC2OtapVU15s?= =?Windows-1252?Q?plg4oaN6o95yp5qRg8VLUD6BVNUI5oASd0gmSnuPwQR0F7r48UaEpkFX?= =?Windows-1252?Q?GaWaYmSiaD2LUKkvTTE8KmM4lK1O1/eWoIy6OAL3JW4mTIPu69SO0Q7i?= =?Windows-1252?Q?2dOnPHq6R3stAOit3a3mhkztdrovu7mX6BtMLFYGI0kosGbblRDAttEb?= =?Windows-1252?Q?68T50k9siVHrvXiiH5h8ncUNRupb6H3MqjNEkOZBSGxnGcad65qmm7aw?= =?Windows-1252?Q?Gji3DnjCvAcNgQbHDqYX8jsFWDw3H8zGzAOB9/+SbSd/3R28Nd4PHb2X?= =?Windows-1252?Q?+aePveM0crPABUvQB5gHcc1kCZ8ZyAsk0yXiQENLzV6DSo+DNs5AjZPI?= =?Windows-1252?Q?a8ge0Ire3Z+iLd+u4BFMNRnsX6MC/SDwFeuCmL/EQWHWcxtH/r3HNbQX?= =?Windows-1252?Q?IVGkEU+akMvzmJDZJCXDVOmNDDtfo4TsIOfjJDzMQIGj5qM+B567Gk9f?= =?Windows-1252?Q?waMFwyssZEORuE//fI5fTCFtRAFmfYD98CJR3wwcQMeY73nxkhGEu+Us?= =?Windows-1252?Q?KgVAIE499lnUpzzLmGjSFQAeAdqvjpGdatRG9VzIM2dKO9ETUXv7pkuc?= =?Windows-1252?Q?4cMgYG3n35ja68zAXZR2gdqVr+1bK+ShxjSKnKl43Hc/8vvSF/yIY7dj?= =?Windows-1252?Q?/I62j1Ar/AB3Y0dS/nkb+HNVy2onboqaK8bk6swNi3PwNgzcZB7UfGPm?= =?Windows-1252?Q?6I0tB3StkUtq5eag2AXMI0fV8drNfXt00eRl/2iqyfNN6taupd1jXXLK?= =?Windows-1252?Q?8IJ8r4LZWz+tonBSVGwLkURokmkqENuiiv+30t++CVgFmSB4zXVwRuaz?= =?Windows-1252?Q?WY1/Bqwh8rM5KhSMkxFS5rB/S+QlZmWRg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CS1PR84MB0231;6:IGWM5MOEh9QCUNLtY53THLEUkjgt7yWGyhjoZtum6OV+r/57hmQKZAUpkNmKElH8tY6brLTbiEReqQMSUKrsBlFnBfVm9jBjbolmo7gapU2gVHiCktHAi9OVKQs0x+C8qXHkI1iZBmfLohtxUQ/ZkozJlK5P6MP4EFfHmsih4fkRDuNowSVLGVn7YU4VejldL4quiy5gEB3I0wGYSUAF+3GM0Y/9zB3OBvSmWmxmLw9lFhAuphjfQ+X9rXJ6q1GQC3Mk3lsvhNSgiN6nNu0fxz5LRbaN2la9RNP/DCefO2n+smUNAxAuuQdn19tfyP26xCGtEyskqxJvWjUj8vOx3Q==;5:wxTV0+3m81GNRi9v4Caj3mq7/or+t7+c3ckpzlXj6BOX4e0gERn6u0G8cYg1bSgzyMQ0Ot109+WBwgw+DXI4nUj0xeQ5B8iDEYZmkT46NprjnpujQLuZHtayRmNs+AgcYj+1Xj1iRikDJc7acNoB6g==;24:hmgh8gM4tVKEolCKXM+u+TgRqPynjaAOGOepbeCGLnzLAEKuq33GAB45wxeStKcEHXfXSR/9zimLT0FX3pe2QaJ3Xb1cSy3yb8zM85j14co=;7:1SsZ9lDRKImWVXViJ2eY53UdHeQYrq3tWGC562YuMkhAUGp9niZXaUYOH6RxR1PyxTlIMSQ5WTCB9m/qHTkNXTCde69N3+jAPPG09qwx71cfnXZVAf5Q7C5sZqLm8UvWzhDN7fqZcZs1h2mTHcaqau7IlZX32Qnd8AmalAkkjLyU6WL/9bBxRfVtVec5b8eInPfRioy9xpwyjAkbwF0QQ18RLKfpO/372RwjY74shrso4bwdsHI14Vk9ZsN9OFhT SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Jul 2016 19:25:51.6286 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0231 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/22/2016 11:36 AM, Viresh Kumar wrote: > On 22-07-16, 17:14, Andreas Herrmann wrote: >> diff --git a/drivers/cpufreq/pcc-cpufreq.c b/drivers/cpufreq/pcc-cpufreq.c >> index a7ecb9a..3f0ce2a 100644 >> --- a/drivers/cpufreq/pcc-cpufreq.c >> +++ b/drivers/cpufreq/pcc-cpufreq.c >> @@ -555,8 +555,6 @@ static int pcc_cpufreq_cpu_init(struct cpufreq_policy *policy) >> policy->min = policy->cpuinfo.min_freq = >> ioread32(&pcch_hdr->minimum_frequency) * 1000; >> >> - policy->cpuinfo.transition_latency = CPUFREQ_ETERNAL; >> - >> pr_debug("init: policy->max is %d, policy->min is %d\n", >> policy->max, policy->min); >> out: > > Hi Rafael, > > I am very confused on this, can you help me understand ? > > - CPUFREQ_ETERNAL = -1 > - unsigned int transition_latency = CPUFREQ_ETERNAL, will set it to UINT_MAX. > - Many drivers do it today > > cpufreq.c > > if (policy->governor->max_transition_latency && > policy->cpuinfo.transition_latency > > policy->governor->max_transition_latency) { > > - And this check will always fail, unless max_transition_latency is zero. > > What am I missing ? I don't know what's missing but I can reproduce the problem. -- ljk