From: Stephen Boyd <sboyd@kernel.org>
To: Hao Ge <gehao618@163.com>
Cc: Hao Ge <gehao@kylinos.cn>,
angelogioacchino.delregno@collabora.com, matthias.bgg@gmail.com,
mturquette@baylibre.com, wenst@chromium.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] mediatek/clk-mt8173-apmixedsys: use devm_of_iomap to avoid resource leak in clk_mt8173_apmixed_probe
Date: Thu, 11 May 2023 15:37:45 -0700 [thread overview]
Message-ID: <ead66129a75a558badf81b07955b7cec.sboyd@kernel.org> (raw)
In-Reply-To: <20230511092654.6d8fab41@haoge-QiTianM428-A376>
Quoting Hao Ge (2023-05-10 18:26:54)
> On Wed, 10 May 2023 14:18:08 -0700
> Stephen Boyd <sboyd@kernel.org> wrote:
>
> > Quoting Hao Ge (2023-05-08 19:12:14)
> > > Use devm_platform_ioremap_resource to take the place of of_iomap for
> > > avoid that we don't called iounmap when return some error or remove
> > > device.
> > >
> > > Fixes: 4c02c9af3cb9 ("clk: mediatek: mt8173: Break down clock
> > > drivers and allow module build") Signed-off-by: Hao Ge
> > > <gehao@kylinos.cn> ---
> >
> > Is this v3?
> Hi Stephen
>
> yes,Perhaps you are too busy,I have not received a response
> in the future, so you are unsure about the status of V2.
> So I adjusted the code and title make changes smaller and
> sent V3 for it.It is precisely because of these that I did
> not continue the original mail thread.
>
I'm waiting for the usual mediatek clk driver folks to review the patch.
next prev parent reply other threads:[~2023-05-11 22:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 2:12 [PATCH] mediatek/clk-mt8173-apmixedsys: use devm_of_iomap to avoid resource leak in clk_mt8173_apmixed_probe Hao Ge
2023-05-10 21:18 ` Stephen Boyd
2023-05-11 1:26 ` Hao Ge
2023-05-11 22:37 ` Stephen Boyd [this message]
2023-05-12 0:39 ` Chen-Yu Tsai
2023-05-15 11:33 ` AngeloGioacchino Del Regno
-- strict thread matches above, loose matches on Subject: below --
2023-05-11 1:56 Hao Ge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ead66129a75a558badf81b07955b7cec.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=gehao618@163.com \
--cc=gehao@kylinos.cn \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox