From: Krzysztof Kozlowski <krzk@kernel.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: shao.mingyin@zte.com.cn, ulf.hansson@linaro.org,
magnus.damm@gmail.com, linux-pm@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
yang.yang29@zte.com.cn, xu.xin16@zte.com.cn,
yang.tao172@zte.com.cn, ye.xingchen@zte.com.cn
Subject: Re: pmdomain: renesas: rcar: Use str_on_off() helper in rcar_sysc_power() and rcar_gen4_sysc_power()
Date: Sat, 31 May 2025 15:39:55 +0200 [thread overview]
Message-ID: <ead6711d-8e38-43b7-bc50-bcc3f7cddb70@kernel.org> (raw)
In-Reply-To: <CAMuHMdVojqSZVg9xCQBUaonTsaDZ5ORsh_ttueOrhKgr10omiw@mail.gmail.com>
On 30/05/2025 10:07, Geert Uytterhoeven wrote:
> Hi Krzysztof,
>
> On Thu, 29 May 2025 at 08:41, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>> On 29/05/2025 04:13, shao.mingyin@zte.com.cn wrote:
>>> From: Shao Mingyin <shao.mingyin@zte.com.cn>
>>>
>>> Remove hard-coded strings by using the str_on_off() helper function.
>>>
>>> Signed-off-by: Shao Mingyin <shao.mingyin@zte.com.cn>
>>> ---
>>> drivers/pmdomain/renesas/rcar-gen4-sysc.c | 3 ++-
>>> drivers/pmdomain/renesas/rcar-sysc.c | 3 ++-
>>
>> Stop sending such trivial patches one driver per patch, but entire
>> subsystem in one patch. That's a lot of churn, considering this was
>> rejected:
>
> Was it? I only see my Rb, and a review comment asking for more...
>
>> https://lore.kernel.org/all/20250114203547.1013010-1-krzysztof.kozlowski@linaro.org/
Indeed this one was not, but my other patchsets were - several
subsystems clearly expressed that this is just a churn. So if doing
this, because you do not consider it a churn, do it all at once to, not
line by line.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-05-31 13:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 2:13 pmdomain: renesas: rcar: Use str_on_off() helper in rcar_sysc_power() and rcar_gen4_sysc_power() shao.mingyin
2025-05-29 6:41 ` Krzysztof Kozlowski
2025-05-30 8:07 ` Geert Uytterhoeven
2025-05-31 13:39 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ead6711d-8e38-43b7-bc50-bcc3f7cddb70@kernel.org \
--to=krzk@kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=shao.mingyin@zte.com.cn \
--cc=ulf.hansson@linaro.org \
--cc=xu.xin16@zte.com.cn \
--cc=yang.tao172@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
--cc=ye.xingchen@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).