Re: [PATCH v3 03/14] thermal: core: Drop redundant thermal instance checks

Daniel Lezcano
2024-08-21T09:32:36Z

On 19/08/2024 17:52, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Because the trip and cdev pointers are sufficient to identify a thermal
> instance holding them unambiguously, drop the additional thermal zone
> checks from two loops walking the list of thermal instances in a
> thermal zone.
>
> No intentional functional impact.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>

I'm wondering if the thermal_instance 'tz' field could be removed too ?

> ---
>
> v1 -> v3: No changes
>
> ---
> drivers/thermal/thermal_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Index: linux-pm/drivers/thermal/thermal_core.c
> ===================================================================
> --- linux-pm.orig/drivers/thermal/thermal_core.c
> +++ linux-pm/drivers/thermal/thermal_core.c
> @@ -850,7 +850,7 @@ int thermal_bind_cdev_to_trip(struct the
> mutex_lock(&tz->lock);
> mutex_lock(&cdev->lock);
> list_for_each_entry(pos, &tz->thermal_instances, tz_node)
> - if (pos->tz == tz && pos->trip == trip && pos->cdev == cdev) {
> + if (pos->trip == trip && pos->cdev == cdev) {
> result = -EEXIST;
> break;
> }
> @@ -915,7 +915,7 @@ int thermal_unbind_cdev_from_trip(struct
> mutex_lock(&tz->lock);
> mutex_lock(&cdev->lock);
> list_for_each_entry_safe(pos, next, &tz->thermal_instances, tz_node) {
> - if (pos->tz == tz && pos->trip == trip && pos->cdev == cdev) {
> + if (pos->trip == trip && pos->cdev == cdev) {
> list_del(&pos->tz_node);
> list_del(&pos->cdev_node);
>
>
>
>

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |