From: Markus Elfring <Markus.Elfring@web.de>
To: "Василий Ковалев" <kovalevvv@basealt.ru>,
linux-fsdevel@vger.kernel.org, lvc-patches@linuxtesting.org,
syzbot+d98fd19acd08b36ff422@syzkaller.appspotmail.com
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
"Tigran A. Aivazian" <aivazian.tigran@gmail.com>,
dutyrok@altlinux.org
Subject: Re: [fs/bfs 1/2] bfs: fix null-ptr-deref in bfs_move_block
Date: Thu, 11 Jul 2024 08:00:15 +0200 [thread overview]
Message-ID: <eb0374b3-d040-4263-96c8-d0dce88432d6@web.de> (raw)
In-Reply-To: <cd942b65-b6d7-0e0f-be4d-c3b950ee008f@basealt.ru>
> Add a check to ensure that a sb_getblk() call did not return NULL before copying data.
How do you think about another refinement for such a change description?
Detect a failed sb_getblk() call (before copying data)
so that null pointer dereferences should not happen any more.
Regards,
Markus
next prev parent reply other threads:[~2024-07-11 6:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 19:11 [PATCH fs/bfs 0/2] bfs: fix null-ptr-deref and possible warning in bfs_move_block() func kovalev
2024-07-10 19:11 ` [PATCH fs/bfs 1/2] bfs: fix null-ptr-deref in bfs_move_block kovalev
2024-07-10 20:09 ` Markus Elfring
2024-07-10 21:57 ` Василий Ковалев
2024-07-11 6:00 ` Markus Elfring [this message]
2024-07-11 16:40 ` kernel test robot
2024-07-10 19:11 ` [PATCH fs/bfs 2/2] bfs: add buffer_uptodate check before mark_buffer_dirty call kovalev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb0374b3-d040-4263-96c8-d0dce88432d6@web.de \
--to=markus.elfring@web.de \
--cc=aivazian.tigran@gmail.com \
--cc=dutyrok@altlinux.org \
--cc=kovalevvv@basealt.ru \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-patches@linuxtesting.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+d98fd19acd08b36ff422@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox