From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752104AbcFKRJu (ORCPT <rfc822;w@1wt.eu>);
	Sat, 11 Jun 2016 13:09:50 -0400
Received: from mout.web.de ([212.227.17.11]:65414 "EHLO mout.web.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751486AbcFKRJt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Sat, 11 Jun 2016 13:09:49 -0400
Subject: Re: [Cocci] [PATCH 3/4] scripts: add glimpse.sh for indexing the
 kernel
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
References: <1465591332-31113-1-git-send-email-mcgrof@kernel.org>
 <1465591332-31113-4-git-send-email-mcgrof@kernel.org>
Cc: cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org,
        Gilles Muller <Gilles.Muller@lip6.fr>,
        Nicolas Palix <nicolas.palix@imag.fr>, Michal Marek <mmarek@suse.com>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <eb07efb3-4d46-00a9-a94f-f0c658f316c5@users.sourceforge.net>
Date: Sat, 11 Jun 2016 19:09:21 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.1.1
MIME-Version: 1.0
In-Reply-To: <1465591332-31113-4-git-send-email-mcgrof@kernel.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:RzDU9x9DhP/GfElmIvcs1Hy807QVfpN5DDvkW3PF47hXsS/Y/fn
 +eY6m0vcfBl7tC94DGJCM1mst7wjDWRH461WcTYswiwMsshOyl59Dd4apPlen7CMnmeyVY6
 GMQ47NqQPF3Qsz/c3mYuCi7scPXvStpEOC+kPT4p1eYTcih0m1OKM0eDIOMJC8aYvtgHw7D
 DvJi5cXE2aQhPPIwpqV9w==
X-UI-Out-Filterresults: notjunk:1;V01:K0:l4ZZezCaLCI=:yx4TrDz19Ick5WVzLq7fpX
 flsoR4FQ2H+uTM0HoRUOH1CJv3eqsofvNrT2ZVQZCJP3B8aMcIe9fDpKFcVunESJwPE26fHxF
 77DJKZETGLUFAs5y032x/XDsEVMlwyz5omm62ELGm575e/C7i7kTUJuHWMBTMfmHPtMvMF+8Q
 Bm0SSwicWFlt9FPu9yXeuqN6Wim9HaIfvvvaV6/v2vKCPT82z1LFaw0m8vzvsVjcLJg/If9qf
 5BT1cmm4Myux1jMeA0o7flW/F7gpP9K37fEoQxdw5uHDSxJArBjzWXnAkio5q+nV63vh8ByKX
 Z7g5rKygglM0VE7R7qe7HQxkERd3cKSCmQrY1U1Q9FpLkZZaaspozwfnDc6BKKcNebNN8JZDM
 rqo9w+H/4leLnTZ94KhULJemv68eCriGgLpR8eC9WccbPrlfrGKgv8QIznzy2Crb8N/B5QEUr
 NKop0nmUJkYG1AqUpUOLSCKFr/3y41R/pIMungfzzV2pS9bMk4NIhd7xUJwrA3htOXKstEAwx
 dw769aHfHsRPdWwCMO08Auqfwi+cVvXVYj8eDqPVazxfz6HQFAER27oGiTRc+OseY2jk7Gw7g
 qGmTeNipB9XMH0TmYEPshaAxPvt2zmZ6wa1zE58W4PZNdiE+2177DnzdZ3aMKsb7bkzznpYvF
 1hO56WtsXKbNxhmEe7CB+5jME5Oi6rZUVnmKyCvMHz3Uxyq9aYMh7in81qzEpOHmhlLiAkCj4
 avCgvzp+OhlA6Igt7HCrAjTJqeU5n9WTFty6CmPLcmAssmLmLytKeEAyw0At9fhbNQ6vBUnYw
 53i9YHN
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Glimpse is a tool you can use to index the kernel. The tool
> was recently open sourced under the ISC license and can be
> obtained at:

How do you think about to mention the script addition also directly in
the commit message?


> @@ -0,0 +1,12 @@
> +#!/bin/bash
> +
> +DIR=$(dirname $(readlink -f $0))
> +DIR="${DIR}/../"

Would you like to use the following variable assignment (instead of two
before)?

+DIR="$(dirname $(readlink -f $0))/../"


By the way: How are the chances to achieve further software improvements?
https://github.com/gvelez17/glimpse/issues

Regards,
Markus