From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0571A387581 for ; Sat, 9 May 2026 21:35:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778362558; cv=none; b=rdoIwwNfa45jHha+o120qAx6qIjNegpW19DWMTsej+WvUsbv1rCPzEMmxtP5wWNMecPK6NE9FxpUHHf0zuvUKVFQnbOAvI86qtO2iyUvrU5CNaW185amfaY33K5pVwXfdAtB6IdKh0175m04Fqm+nKxb+aUqVYs9UIdwGkrCwH4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778362558; c=relaxed/simple; bh=J67uTUzOtJv34a1o3K1+pm6HLFFypjoFMklnf6FHSa8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YZ/dazuxw66F6/0nZfn1o3edODWK2yav+n82C7iwDlx1HUthlAup0MQ36D+f2oMK4bCYEPW9ReEtI/g/L0MOIGtO9zy0/+FPK9UumAIK+A0JRxenpsEZlyqB2YDg7N1RGnK8e2y1jzb+XW4DX5r5sbX1I/pb9f0x0Pue0guEeZo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=ahvZ3RAg; arc=none smtp.client-ip=209.85.210.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="ahvZ3RAg" Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-7dcd17e19b6so1834853a34.1 for ; Sat, 09 May 2026 14:35:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1778362556; x=1778967356; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=E/ekXA5bmU61aG7UyRq3M0hlEU3MeLb60TJwuJg45PY=; b=ahvZ3RAg9YmKWyMxux+4iay/owfd3ZX+hm7wP/IpMuo9Xm+S2Uyz/uOjQehbfHWeug 0c6OJauURQpOL4xmdZCdlBZvzSQgEV/eKTHIkyz/WbGfKVf3JX16cPOGOGYJ9KUwAx7L 8rB3YmzeB7Cc+kzGEOjnT4Hk0EaotqZoPRR2AllEmNAVTbE3T/fd8Q/fjnvz1dtxMD9X 5/sP6ByZieeDA0rE2AzTk3liukVESii8PsTbqFM6dg2s/rHlBgkzT5Gueb2GEPwrnt7s FtjDMbbyKQMUE2YwZDHH9wClCNa2Wnsyv23RmyRUYk/jpvkHkxigNPBpQISHE2Daai4d ZJiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778362556; x=1778967356; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=E/ekXA5bmU61aG7UyRq3M0hlEU3MeLb60TJwuJg45PY=; b=dbtbJHSN9fa/WEty+e72zq/QcKcXBZK5Jq0VKvbp5Jp7AcZDxH0MbW+P2yvDiv7Gcu v/5RlkEBIVhhx2tbl/jWbl4AQwteof2hLjK6AUkhlcBYkF3B05x2lD3I6o0zeXOt872l psQ8IN7/3/wShYrZ7iaRktSTaiuXYe7aR6bOQVSha5ic1Gi8AzApUrDtJQ0bI7+eJq90 U1naJ7ynkjACzTrOG4+5KSaUrSFwrQwkUN5hBtEKmnfKVw8/F4QXOd7Z1Kxtve5NsDHy OK5JMoMwg22jvi7eH7aiaDQ3gdstLOW+Kj24mZnOKHrucFBzF+OFYAdvqYxSit0rbFYa 5uQA== X-Forwarded-Encrypted: i=1; AFNElJ/pbf1MNLQmirvecd9pysADXiN215qC1i3BReXYXBGWlhfd/jrCEaGpP5yW8ZdeOm90yuuwdw8nF2esFnU=@vger.kernel.org X-Gm-Message-State: AOJu0YywTvm301wMaRnmvXlHDHYw1j4uVQnLvspvl/VpnHmgDL1PH65I iloe7j2rvXmKP1gnRzJiTSJsrU5xRDBKm4W/l9G9F5DWS1Czk9dFyC+IprjDIapYbsM= X-Gm-Gg: Acq92OFdtELytNKgoMnZ6g4Aokj8+QndaaAcgJuOGF1sMwg/8QxwQnBHcWd4pwOvWUu bC8Cc60cQiZpkA6fatppwmFV3fGZg96jPpm23RHWXafTxTW4DU8PIU/oHC9ypxdmMkHJMrEore3 d/cN5rWzykIngNEcsq2SbAI9tB8bHugYptpZ1KumOzCj5a02AdocnZQMTWpFw999HysJHjLO3Ej OtOt3RuoIhX7+zqurMi3Ym4qgPf8ufAjmNIkO1gIhmximwPTEHS+e7D7BRH8eXh4N3lFl1crS2o DsGRI50OFlQwnaqyODgyYuMtceLMlvsPOYrqEU0xVE91Itrw9KmhLgKN6JAD9gHq4qHCsSY//+W rIxqVF+q2W2ntC6IzJc08hU9HCshlAIqQi3ldiFryIR+uo3l6254VepMenAtDJoHYiwh6KP5K7P OtXkNphHg78ZXP2pVlw0CBHO4yp7Zqizspl68OaP8jIQPnzQGewxvwCBbUHO+s3+7wp5SJz0Ck5 Q== X-Received: by 2002:a05:6830:2a10:b0:7db:d229:d51e with SMTP id 46e09a7af769-7e381f98af6mr2630712a34.12.1778362555980; Sat, 09 May 2026 14:35:55 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:3548:c22e:ea52:dbc7? ([2600:8803:e7e4:500:3548:c22e:ea52:dbc7]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e367c04e00sm3715141a34.7.2026.05.09.14.35.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 May 2026 14:35:55 -0700 (PDT) Message-ID: Date: Sat, 9 May 2026 16:35:53 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/9] iio: hid-sensors: cleanup codestyle warning To: Sanjay Chitroda , jikos@kernel.org, jic23@kernel.org, srinivas.pandruvada@linux.intel.com Cc: nuno.sa@analog.com, andy@kernel.org, sakari.ailus@linux.intel.com, linux-input@vger.kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260509101040.791404-1-sanjayembedded@gmail.com> <20260509101040.791404-3-sanjayembedded@gmail.com> Content-Language: en-US From: David Lechner In-Reply-To: <20260509101040.791404-3-sanjayembedded@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/9/26 5:10 AM, Sanjay Chitroda wrote: > From: Sanjay Chitroda > > Reported by checkpatch: > FILE: drivers/iio/common/hid-sensors/hid-sensor-trigger.c checkpatch (or any other linter) says so is not a good reason for a change. They are suggestions, not requirements. If the code is improved, say why this is better. I.e. improve readability. > > WARNING: Missing a blank line after declarations > > Signed-off-by: Sanjay Chitroda > --- > drivers/iio/common/hid-sensors/hid-sensor-trigger.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c > index 28d050b45c74..98fadc61a68a 100644 > --- a/drivers/iio/common/hid-sensors/hid-sensor-trigger.c > +++ b/drivers/iio/common/hid-sensors/hid-sensor-trigger.c > @@ -313,7 +313,9 @@ static int __maybe_unused hid_sensor_resume(struct device *dev) > { > struct iio_dev *indio_dev = dev_get_drvdata(dev); > struct hid_sensor_common *attrb = iio_device_get_drvdata(indio_dev); > + > schedule_work(&attrb->work); > + > return 0; > } > > @@ -321,6 +323,7 @@ static int __maybe_unused hid_sensor_runtime_resume(struct device *dev) > { > struct iio_dev *indio_dev = dev_get_drvdata(dev); > struct hid_sensor_common *attrb = iio_device_get_drvdata(indio_dev); > + > return _hid_sensor_power_state(attrb, true); > } >