From: Juergen Gross <jgross@suse.com>
To: Borislav Petkov <bp@alien8.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
x86@kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v2] x86/paravirt: Cleanup native_patch()
Date: Tue, 11 Sep 2018 11:44:26 +0200 [thread overview]
Message-ID: <eb3dd51b-1807-b5ea-58c6-714fdee7f173@suse.com> (raw)
In-Reply-To: <20180911091510.GA12094@zn.tnic>
On 11/09/18 11:15, Borislav Petkov wrote:
> When CONFIG_PARAVIRT_SPINLOCKS=n, it fires
>
> arch/x86/kernel/paravirt_patch_64.c: In function ‘native_patch’:
> arch/x86/kernel/paravirt_patch_64.c:89:1: warning: label ‘patch_site’ defined but not used [-Wunused-label]
> patch_site:
>
> but those labels can simply be removed by directly calling the
> respective functions there.
>
> Get rid of local variables too, while at it. Also, simplify function
> flow for better readability.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: x86@kernel.org
> Cc: virtualization@lists.linux-foundation.org
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
next prev parent reply other threads:[~2018-09-11 9:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 10:49 [PATCH] x86/paravirt: Get rid of patch_site label Borislav Petkov
2018-09-07 10:51 ` Borislav Petkov
2018-09-07 20:10 ` [PATCH v2] x86/paravirt: Get rid of patch_site and patch_default labels Borislav Petkov
2018-09-08 5:45 ` Juergen Gross
2018-09-08 15:28 ` [PATCH] x86/paravirt: Cleanup native_patch() Borislav Petkov
2018-09-10 6:54 ` Juergen Gross
2018-09-10 7:01 ` Borislav Petkov
2018-09-10 8:33 ` Juergen Gross
2018-09-11 9:15 ` [PATCH v2] " Borislav Petkov
2018-09-11 9:44 ` Juergen Gross [this message]
2018-09-11 15:34 ` [tip:x86/paravirt] x86/paravirt: Clean up native_patch() tip-bot for Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb3dd51b-1807-b5ea-58c6-714fdee7f173@suse.com \
--to=jgross@suse.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox