Re: [PATCH v3 02/14] serial: liteuart: use bit number macros

Ilpo Järvinen
2022-11-15T15:34:21Z

On Sat, 12 Nov 2022, Gabriel Somlo wrote:

> Replace magic bit constants (e.g., 1, 2, 4) with BIT(x) expressions.
>
> Signed-off-by: Gabriel Somlo <gsomlo@gmail.com>
> ---
> drivers/tty/serial/liteuart.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/liteuart.c b/drivers/tty/serial/liteuart.c
> index 32b81bd03d0c..1497d4cdc221 100644
> --- a/drivers/tty/serial/liteuart.c
> +++ b/drivers/tty/serial/liteuart.c
> @@ -38,8 +38,8 @@
> #define OFF_EV_ENABLE 0x14
>
> /* events */
> -#define EV_TX 0x1
> -#define EV_RX 0x2
> +#define EV_TX BIT(0)
> +#define EV_RX BIT(1)
>
> struct liteuart_port {
> struct uart_port port;
>

This seems to assume some random header provides BIT() for you?

--
i.