public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Yuwei Guan <Yuwei.Guan@zeekrlife.com>, paolo.valente@linaro.org
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] block, bfq: remove unused variable for bfq_queue
Date: Tue, 11 Oct 2022 10:26:04 -0600	[thread overview]
Message-ID: <eb59cf48-03c8-7ce9-7e00-4b824cef150d@kernel.dk> (raw)
In-Reply-To: <20221010132907.1252-1-Yuwei.Guan@zeekrlife.com>

On 10/10/22 7:29 AM, Yuwei Guan wrote:
> it defined in d0edc24, but there's nowhere to use it,
> so remove it.

A few things wrong with this patch:

1) It's whitespace damaged, and hence will not apply directly.
2) It should have a fixes tag, and the sha used should be 12
    chars. 8 is too short.

Can you resend it?

> Disclaimer?The information transmitted is intended only for the person
> or entity to which it is addressed and may contain confidential and/or
> privileged material. Any review, retransmission, dissemination or
> other use of, or taking of any action in reliance upon, this
> information by persons or entities other than the intended recipient
> is prohibited. If you received this in error , please contact the
> sender and delete the material from any computer .

And please get rid of this, it's just spam and doesn't apply on a public
mailing list.

-- 
Jens Axboe

  parent reply	other threads:[~2022-10-11 16:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-10 13:29 [PATCH] block, bfq: remove unused variable for bfq_queue Yuwei Guan
2022-10-11  8:32 ` Paolo VALENTE
2022-10-11 16:26 ` Jens Axboe [this message]
2022-10-12  6:31   ` Yuwei Guan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=eb59cf48-03c8-7ce9-7e00-4b824cef150d@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=Yuwei.Guan@zeekrlife.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paolo.valente@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox