From: Jiri Slaby <jslaby@suse.cz>
To: Gen Zhang <blackgod016574@gmail.com>,
hubcap@omnibond.com, martin@omnibond.com
Cc: devel@lists.orangefs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] orangefs-debugfs: fix a missing-check bug in debug_string_to_mask()
Date: Wed, 5 Jun 2019 08:32:43 +0200 [thread overview]
Message-ID: <eb5b0178-626d-e142-c1e4-7805f28e1e24@suse.cz> (raw)
In-Reply-To: <20190530090455.GA3059@zhanggen-UX430UQ>
On 30. 05. 19, 11:04, Gen Zhang wrote:
> In debug_string_to_mask(), 'strsep_fodder' is allocated by kstrdup().
> It returns NULL when fails. So 'strsep_fodder' should be checked.
>
> Signed-off-by: Gen Zhang <blackgod016574.gmail>
> ---
> diff --git a/fs/orangefs/orangefs-debugfs.c b/fs/orangefs/orangefs-debugfs.c
> index 87b1a6f..a9a9aac 100644
> --- a/fs/orangefs/orangefs-debugfs.c
> +++ b/fs/orangefs/orangefs-debugfs.c
> @@ -888,6 +888,8 @@ static void debug_string_to_mask(char *debug_string, void *mask, int type)
> char *unchecked_keyword;
> int i;
> char *strsep_fodder = kstrdup(debug_string, GFP_KERNEL);
> + if (!strsep_fodder)
> + return;
> char *original_pointer;
You should get a compiler error/warning about mixing declarations with code.
thanks,
--
js
suse labs
prev parent reply other threads:[~2019-06-05 6:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 9:04 [PATCH] orangefs-debugfs: fix a missing-check bug in debug_string_to_mask() Gen Zhang
2019-06-05 6:32 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb5b0178-626d-e142-c1e4-7805f28e1e24@suse.cz \
--to=jslaby@suse.cz \
--cc=blackgod016574@gmail.com \
--cc=devel@lists.orangefs.org \
--cc=hubcap@omnibond.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@omnibond.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox