From: Shuah Khan <skhan@linuxfoundation.org>
To: Alessandro Zanni <alessandro.zanni87@gmail.com>,
nm@ti.com, ssantosh@kernel.org
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, anupnewsmail@gmail.com,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] soc: ti: knav_qmss_queue: remove useless statement
Date: Tue, 24 Sep 2024 10:20:23 -0600 [thread overview]
Message-ID: <eb73ec97-dcf7-41ac-ae88-20611fcff72b@linuxfoundation.org> (raw)
In-Reply-To: <20240924132025.22046-1-alessandro.zanni87@gmail.com>
On 9/24/24 07:20, Alessandro Zanni wrote:
> Remove the statement "continue" at the end of the loop where it
> becomes useless.
How did you find the problem? Change log should say how you found
it.
>
> Signed-off-by: Alessandro Zanni <alessandro.zanni87@gmail.com>
> ---
> drivers/soc/ti/knav_qmss_queue.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
> index 6c98738e548a..1cc54905b398 100644
> --- a/drivers/soc/ti/knav_qmss_queue.c
> +++ b/drivers/soc/ti/knav_qmss_queue.c
> @@ -723,7 +723,6 @@ static void kdesc_empty_pool(struct knav_pool *pool)
> if (!desc) {
> dev_dbg(pool->kdev->dev,
> "couldn't unmap desc, continuing\n");
> - continue;
> }
> }
> WARN_ON(i != pool->num_desc);
thanks,
-- Shuah
next prev parent reply other threads:[~2024-09-24 16:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 13:20 [PATCH] soc: ti: knav_qmss_queue: remove useless statement Alessandro Zanni
2024-09-24 16:20 ` Shuah Khan [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-09-24 21:46 Alessandro Zanni
2024-10-25 14:02 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eb73ec97-dcf7-41ac-ae88-20611fcff72b@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=alessandro.zanni87@gmail.com \
--cc=anupnewsmail@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox