[PATCH] soc: ti: knav_qmss_queue: remove useless statement

[PATCH] soc: ti: knav_qmss_queue: remove useless statement

[Alessandro Zanni]

Remove the statement "continue" at the end of the loop where it
becomes useless.

Signed-off-by: Alessandro Zanni <alessandro.zanni87@gmail.com>
---
 drivers/soc/ti/knav_qmss_queue.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
index 6c98738e548a..1cc54905b398 100644
--- a/drivers/soc/ti/knav_qmss_queue.c
+++ b/drivers/soc/ti/knav_qmss_queue.c
@@ -723,7 +723,6 @@ static void kdesc_empty_pool(struct knav_pool *pool)
 		if (!desc) {
 			dev_dbg(pool->kdev->dev,
 				"couldn't unmap desc, continuing\n");
-			continue;
 		}
 	}
 	WARN_ON(i != pool->num_desc);
-- 
2.43.0

Re: [PATCH] soc: ti: knav_qmss_queue: remove useless statement

[Shuah Khan]

On 9/24/24 07:20, Alessandro Zanni wrote:
> Remove the statement "continue" at the end of the loop where it
> becomes useless.

How did you find the problem? Change log should say how you found
it.

> 
> Signed-off-by: Alessandro Zanni <alessandro.zanni87@gmail.com>
> ---
>   drivers/soc/ti/knav_qmss_queue.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
> index 6c98738e548a..1cc54905b398 100644
> --- a/drivers/soc/ti/knav_qmss_queue.c
> +++ b/drivers/soc/ti/knav_qmss_queue.c
> @@ -723,7 +723,6 @@ static void kdesc_empty_pool(struct knav_pool *pool)
>   		if (!desc) {
>   			dev_dbg(pool->kdev->dev,
>   				"couldn't unmap desc, continuing\n");
> -			continue;
>   		}
>   	}
>   	WARN_ON(i != pool->num_desc);

thanks,
-- Shuah

[PATCH] soc: ti: knav_qmss_queue: remove useless statement

[Alessandro Zanni]

Remove the statement "continue" at the end of the loop
where it becomes useless.

Problem found with Coccinelle static analisys tool,
using continue.cocci script
(coccinelle.gitlabpages.inria.fr/website/rules/continue.cocci)

Signed-off-by: Alessandro Zanni <alessandro.zanni87@gmail.com>
---
 drivers/soc/ti/knav_qmss_queue.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/soc/ti/knav_qmss_queue.c b/drivers/soc/ti/knav_qmss_queue.c
index 6c98738e548a..1cc54905b398 100644
--- a/drivers/soc/ti/knav_qmss_queue.c
+++ b/drivers/soc/ti/knav_qmss_queue.c
@@ -723,7 +723,6 @@ static void kdesc_empty_pool(struct knav_pool *pool)
 		if (!desc) {
 			dev_dbg(pool->kdev->dev,
 				"couldn't unmap desc, continuing\n");
-			continue;
 		}
 	}
 	WARN_ON(i != pool->num_desc);
-- 
2.43.0

Re: [PATCH] soc: ti: knav_qmss_queue: remove useless statement

[Nishanth Menon]

Hi Alessandro Zanni,

On Tue, 24 Sep 2024 23:46:10 +0200, Alessandro Zanni wrote:
> Remove the statement "continue" at the end of the loop
> where it becomes useless.
> 
> Problem found with Coccinelle static analisys tool,
> using continue.cocci script
> (coccinelle.gitlabpages.inria.fr/website/rules/continue.cocci)
> 
> [...]

I have applied the following to branch ti-drivers-soc-next on [1] with some
minor fixups in commit message. Thank you!

[1/1] soc: ti: knav_qmss_queue: remove useless statement
      commit: 74280c3d73143dcb976491fc085ccb0437cb5f0e

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D