From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74C3B22CF07; Mon, 13 Jan 2025 11:35:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736768143; cv=none; b=AqaHfItnfSitQdDOzjk/D4NfT2ruobTSf0YKdhizUclog4i5+6vTOIh4gRq8AP2lCf/4txFFqh5WYbdhKHuONS1N13XNdj2B0T8grj4/9/Uw5f+Axd4oETVhUAKoqb6T2p4Jn7mboCrsQmoxPZz3b6a+OrrnoQ+ACKTowO8XQAg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736768143; c=relaxed/simple; bh=oGFhBInv1GRa5ya9fSnahpEiZAFr7o5nMSpPLDknsZU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ogntxWMP/1j0VVTDUaRP7TjwoLOIbhP8E2NfGTD6oPVvEPhLNO2czcreAcm9fcL3yZA6LrmTZcGIM7HDYPAXfKcm8Dq+6eElI1MHLBXM19/kH7lt/Nxib1IbQdxIek5nwYZZWMNPS2LFwh8cownthw6rwPNtK987jL/JpkHzVVg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tsp631Gx; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tsp631Gx" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D0E6C4CED6; Mon, 13 Jan 2025 11:35:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736768143; bh=oGFhBInv1GRa5ya9fSnahpEiZAFr7o5nMSpPLDknsZU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=tsp631Gxk8S3AFpH0igeU/jzV8q9yMMX4lqYNaAbGg99uBKEnlRBi50n7rxNrnxYI qPwb3PTyIidtSrGG+RKCjvhgMNfPEFUtV8G9n2Ow+0NR6AngkHCPCgyxYR7SZWYZfk d1XNbEks3CGoX9ss6dN8gXeSkk/5c4ZbtjQI5fE1C/OrEqHe154Bz+B+UdzdWUqrMi +ZA3h0bkII2+K6UTGyhFX74kOtdhJDll//ddo24KKVnjK0RhTN74/kqgxTjlDBLcAG xwNHxGRK2UfFGFxg1exUXR4X94NfaKvt1UicesbFnYs5mGlvoR5ivTEN9gKaGehIJ4 hQXIopJdWbq1w== Message-ID: Date: Mon, 13 Jan 2025 12:35:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: arm: fsl: Update i.MX95 compatible To: Peng Fan Cc: Peng Fan , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "imx@lists.linux.dev" , "linux-arm-kernel@lists.infradead.org" References: <20250104-imx9-machine-v1-0-18a78e41456b@nxp.com> <20250104-imx9-machine-v1-1-18a78e41456b@nxp.com> <4666f8e9-d19e-45bd-be9c-a7f111168d66@kernel.org> <8d2746ba-47d2-429b-9df0-9448a4516ef1@kernel.org> <20250109024058.GA31833@localhost.localdomain> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20250109024058.GA31833@localhost.localdomain> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 09/01/2025 03:40, Peng Fan wrote: > On Mon, Jan 06, 2025 at 07:12:29AM +0100, Krzysztof Kozlowski wrote: >> On 06/01/2025 03:51, Peng Fan wrote: >>>> Subject: Re: [PATCH 1/2] dt-bindings: arm: fsl: Update i.MX95 >>>> compatible >>>> >>>> On 04/01/2025 13:13, Peng Fan (OSS) wrote: >>>>> From: Peng Fan >>>>> >>>>> i.MX95 features a System Controller and SCMI Spec 3.2 compatible >>>>> firmware System Manager(SM) runs on the controller. >>>>> Add "fsl,imx-sm" compatible string as fallback for "fsl,imx95" to >>>>> indicate it is compatible with i.MX System Manager. >>>> >>>> I see little value in generic compatible like that. All these are >>>> aarch64 so why not adding that compatible? >>>> >>>> How this generic compatible would be used? >>>> >>>> And by what exactly? >>> >>> There will be more i.MX9 chips with System Manager. I would >>> not expand the list here each time to support a new SoC. >>> >>> https://elixir.bootlin.com/linux/v6.13-rc3/source/drivers/pinctrl/pinctrl-scmi.c#L508 >>> https://elixir.bootlin.com/linux/v6.13-rc3/source/drivers/pinctrl/freescale/pinctrl-imx-scmi.c#L290 >> >> Problem is that compatible is way too generic to be used by Linux drivers. > > Is "fsl,imx9-sm" feasible here? It is better, but I am still not happy with the generic meaning of it. You claim now that certain SoCs will be compatible with imx9-sm, so with some sort of "sm". What is the meaning of sm in terms of ABI and interfaces? What do you exactly define here? And what happens if some other feature will require one more compatible and then one more? You will have: compatible = "fsl,imx95-19x19-evk", "fsl,imx95", "fsl,imx9-sm", "fsl,imx9-foo", "fsl,imx9-bar", "fsl,imx9-whatnot"; You add compatible for some unspecified interface called "System Manager" just to solve Linux driver issue. Best regards, Krzysztof