From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 460DD1922F1 for ; Wed, 18 Dec 2024 23:14:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734563671; cv=none; b=AiZXwNpCSncaRSEWSpSIhcxZiwgVt36e9+gyr63HCZmcY3GzUTANw/SJmRvhj2tWLwVjLAY0ZOYKgUMg8uHu3Fzf8nZYyXfhJd4iIC411fsA9fDbkW+UlQo5iDfjRkEjlB5e+neJdOv6tUeyhJ6u12xtO1uqUNwoK4+vJ7V/4tY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734563671; c=relaxed/simple; bh=lyAMNMv5eKSuulZNEc/bdNCuyulKLn44+4F3l6KUPRs=; h=Date:Message-ID:MIME-Version:Content-Type:From:To:Cc:Subject: References:In-Reply-To; b=YIGzWnA1x1nGStCMNfBrHng2Tkn1f25l68CrdgVJ4iSVtC5p6A5V1V1AAmmz0kGN/ADtpNMM9z4mj/P9gwAcWk8/iZjA9qxsPZbVDARiylz+9HPOIUSwx/bfjuCycTMO97mWJmacMVCu5x9oSu4SpQqUpFexnox8GhWEIAlefZc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=duz3P9po; arc=none smtp.client-ip=209.85.219.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="duz3P9po" Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-6dd15d03eacso2462926d6.0 for ; Wed, 18 Dec 2024 15:14:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1734563669; x=1735168469; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:from:to:cc:subject:date:message-id :reply-to; bh=fFXlSpmqndisihDpwgewGal8XJGyYG+RFQb6zfcXijY=; b=duz3P9poAea/erOck2V9RvuKIPsuXiWKV6q3VWqs8apR/YYXIY5ukfnVtX7DcZk6rd JKsmBdUEWzQFz5W0Ywg6t2uRces73wp3t8Ll7ACoGjyKmywv2M3IrhASqoBM+V+DpZ8P /z9YaNOxGeAN9uB3vJtQaeEtuDFU2TSDH2+he+2dprN+40kW7heGDZKvLKZDVLdPt3Nr UympnUN+vyJdP1kYH3j7GPexVO4yBX0WPw5d2tvBeg/mOpmB4TY1YkSQuIOFd1KPlGhq zW9joLHbUXxdv/xn00Ar3KSlD2iLMxr4lCFnyvBUo01ufOqNrnF0PksEwPlYY0oEfQNb cxwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734563669; x=1735168469; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :mime-version:message-id:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=fFXlSpmqndisihDpwgewGal8XJGyYG+RFQb6zfcXijY=; b=VUCQOBDiJXMR77AnsKrJXVGrzSR9+wNUA9kMh6D0oZ5L7h8GfJrNi/4/eMxVQXxK6f GU95Uu079+wu2ATKjbRVwrVkVorwb9CeUcN+8cPtnrtlskCj87Ezfy6JsmxwjB3yueGD XZkeT7M7fSZm+WhRdIhI8dv6NxNUMcpRZLN1pQEtRrc7mqCppukBbK6M3R0IcQkR+t/S VwDArXovIoS24s62LdhjCDv1wGyvpnDIOdJkRqb1/riTSAbN7032I3g6nb8VYiBivKaV knf5A1NAP1cna/9rpus/exqrD7I3y8BCtOv/4to0J4/vC3ZwydzRCODgoWuaoa76655v 1piw== X-Forwarded-Encrypted: i=1; AJvYcCXMp/BCSPuD7XYV1T/nKK//FUv2WiC5gpmS4QTV0ToyQIqLPZQd1ToiG1wX1fHB3B+SwY+zRl/UQ18Yhnc=@vger.kernel.org X-Gm-Message-State: AOJu0YyEKa3kyLLqOjmRYfBtM5DSdg2DaC1dpVCioyUWqcslbAcdExcn /2L2BIuk0EhXWodRGWseUqYUrrkwm2djqoQdVf+qyXIJqprcjCuWeoepAgRu8g== X-Gm-Gg: ASbGncs9dHNawDDbKrxpt7D3WJc2wIt4QwkE6ShwQ1LDDGt11k7FSZr+nx3zYDjZqdg Lip46Qooui++df87W4Mwa5Fbv7qErPN2OslfGhImmF/gpjNNyl1nLr7uAIl/sZX+VcKHLUqLsHe 0C1oRBBJGUZ/wjopvj3AkECJTpzdoT8t4mPjJPQChCut45955+AFF2CZT8fXIJZ8aVgZbzQ3Jm4 qDqqwim3YnE7sQ0gmvZmugq4Nx3hTlxYfbtggOdbxzGfG9ORxw= X-Google-Smtp-Source: AGHT+IF812hW3SafWF2rQUyIrEzOBwO01YXN1q6BdXWRjDtGlUPqECITyxWs+43CjiDrTg6b9jZQaA== X-Received: by 2002:a05:6214:3107:b0:6d8:a3f2:4cc with SMTP id 6a1803df08f44-6dd15547264mr22536116d6.5.1734563669239; Wed, 18 Dec 2024 15:14:29 -0800 (PST) Received: from localhost ([70.22.175.108]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6dd181d3d90sm690556d6.106.2024.12.18.15.14.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2024 15:14:28 -0800 (PST) Date: Wed, 18 Dec 2024 18:14:28 -0500 Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: pstg-pwork:20241218_1749/pstg-lib:20241217_2346/pstg-pwork:20241218_1749 From: Paul Moore To: Amit Vadhavana , jmorris@namei.org, serge@hallyn.com, casey@schaufler-ca.com, shuah@kernel.org Cc: ricardo@marliere.net, av2082000@gmail.com, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linux.dev, linux-security-module@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] selftests: lsm: Refactor `flags_overset_lsm_set_self_attr` test References: <20241116152136.10635-1-av2082000@gmail.com> In-Reply-To: <20241116152136.10635-1-av2082000@gmail.com> On Nov 16, 2024 Amit Vadhavana wrote: > > Remove the temporary context variable `tctx` to simplify the code. use > the original context `ctx` directly in calls to `lsm_get_self_attr`, > eliminating redundancy without any functional changes. > > Reviewed-by: Casey Schaufler > Reviewed-by: Shuah Khan > Signed-off-by: Amit Vadhavana > --- > V1:- https://lore.kernel.org/all/20241112182810.24761-1-av2082000@gmail.com/ > V1 -> V2 : > write complete sentences instead of bullet points in the change log. > --- > tools/testing/selftests/lsm/lsm_set_self_attr_test.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) Thank you for working on improving the tests, merged into lsm/dev. -- paul-moore.com