Re: [RFC PATCH v2] ARM: dts: Add TS-7553-V2 support

Kris Bahnsen
2022-07-19T17:40:23Z

On Mon, 2022-07-18 at 14:49 +0200, Krzysztof Kozlowski wrote:
> On 15/07/2022 19:54, Kris Bahnsen wrote:
> > On Fri, 2022-07-15 at 08:42 +0200, Krzysztof Kozlowski wrote:
> > > On 14/07/2022 23:26, Kris Bahnsen wrote:
> > > > On Thu, 2022-07-14 at 10:34 +0200, Krzysztof Kozlowski wrote:
> > > > > On 14/07/2022 00:12, Kris Bahnsen wrote:
> > > > > > Add initial support of the i.MX6UL based TS-7553-V2 platform.
> > > > >
> > > > > Use subject prefix matching the subsystem. git log --oneline --
> > > >
> > > > Can you please elaborate? The subject prefix is "ARM: dts:", I'm not
> > > > sure what is missing. Should it be something like
> > > > "ARM: dts: imx6ul-ts7553v2:" in this case?
> > >
> > > Run the command, you will see.
> >
> > I had previously run the command and the output of it did not make sense in
> > the context of your prior comment. Forgive my ignorance, but I'd like to
> > understand specifically what you mean here so we can do the correct thing
> > in the future.
> >
> > $ git log --oneline -- | head -n 20
>
> This obviously does not make sense. -- as you can read in git log help
> and several other Unix/Linux commands is marking path arguments. You
> want to run it on specific subsystem, don't you?

I've looked at commits for imx6ul-* devicetree files and that was how
I derived this commit/subject. I see a number of different patterns
and if one is preferred over the other I would appreciate the
clarification.

e.g. looking at commits of imx6ul-*
"ARM: dts:" is used for a number of initial devicetree commits
"ARM: dts: imx6ul: <board>:" is used a few times
"ARM: dts: imx6ul-<board>:" is also used a few times

For initial commits of a devicetree, or modifications of a devicetree,
what is the preferred pattern moving forward?

Thank you for your continued support.

>
> Best regards,
> Krzysztof
>